[PATCH] docs: Fix backticks in README instructions

carlodelos90 posted 1 patch 11 months ago
There is a newer version of this series
README | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] docs: Fix backticks in README instructions
Posted by carlodelos90 11 months ago
The commands `make pdfdocs` and `make htmldocs` were incorrectly formatted
with only two backticks, which caused confusion and didn't render properly
in some contexts. This change updates the documentation to use triple
backticks for consistency and clarity.

Signed-off-by: carlodelos90 <carlodelos90@gmail.com>
---
 README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README b/README
index fd903645e6de..21294cc9fd04 100644
--- a/README
+++ b/README
@@ -5,8 +5,8 @@ There are several guides for kernel developers and users. These guides can
 be rendered in a number of formats, like HTML and PDF. Please read
 Documentation/admin-guide/README.rst first.
 
-In order to build the documentation, use ``make htmldocs`` or
-``make pdfdocs``.  The formatted documentation can also be read online at:
+In order to build the documentation, use ```make htmldocs``` or
+```make pdfdocs```.  The formatted documentation can also be read online at:
 
     https://www.kernel.org/doc/html/latest/
 
-- 
2.39.5 (Apple Git-154)
Re: [PATCH] docs: Fix backticks in README instructions
Posted by Akira Yokosawa 11 months ago
Hello,

carlodelos90 wrote:
> The commands `make pdfdocs` and `make htmldocs` were incorrectly formatted
> with only two backticks, which caused confusion and didn't render properly
> in some contexts.

Do you mean:

... One example is GitHub where top-level README is assumed to be in
the GitHub dialect of Markdown.

???

>                   This change updates the documentation to use triple
> backticks for consistency and clarity.

Obviously, triple backticks don't work in other contexts.

So your "fix" breaks assumption of others.

I think GitHub can render its README pane in reST format if you add a
symlink of README.rst -> README.  No?

> 
> Signed-off-by: carlodelos90 <carlodelos90@gmail.com>

Do You normally sign a contract using the name of "carlodelos90"?

Signed-off-by should be regarded as a formal statement that you
have the right to submit a patch.

See "Sign your work - the Developer’s Certificate of Origin"
in Documentation/process/submitting-patches.rst.

In your future submissions, please use your real name for signing off
unless you have a good reason not to do so.

I'm not sure if adding a symlink for the sake of GitHub compatibility
is acceptable or not.  But it looks to me worth an attempt at least.

        Thanks, Akira

Re: [PATCH] docs: Fix backticks in README instructions
Posted by Jonathan Corbet 11 months ago
Akira Yokosawa <akiyks@gmail.com> writes:

> carlodelos90 wrote:
>> The commands `make pdfdocs` and `make htmldocs` were incorrectly formatted
>> with only two backticks, which caused confusion and didn't render properly
>> in some contexts.
>
> Do you mean:
>
> ... One example is GitHub where top-level README is assumed to be in
> the GitHub dialect of Markdown.
>
> ???

Indeed, "some contexts" is a uselessly vague description; please say
what the actual problem is.

>>                   This change updates the documentation to use triple
>> backticks for consistency and clarity.
>
> Obviously, triple backticks don't work in other contexts.
>
> So your "fix" breaks assumption of others.
>
> I think GitHub can render its README pane in reST format if you add a
> symlink of README.rst -> README.  No?

The thing is ... *we* don't render that file as RST either.  So perhaps
the best solution is just to use normal "quotes" rather than any sort of
markup?

Thanks,

jon