Hi all,

This patch series continues the work to migrate the *.sh tests into
prog_tests framework.

test_xdp_redirect_multi.sh tests the XDP redirections done through
bpf_redirect_map().

This is already partly covered by test_xdp_veth.c that already tests
map redirections at XDP level. What isn't covered yet by test_xdp_veth is
the use of the broadcast flags (BPF_F_BROADCAST or BPF_F_EXCLUDE_INGRESS)
and XDP egress programs.

Hence, this patch series add test cases to test_xdp_veth.c to get rid of
the test_xdp_redirect_multi.sh:
 - PATCH 1 to 5 rework test_xdp_veth to make it more generic and allow to
   configure different test cases
 - PATCH 6 adds test cases for 'classic' bpf_redirect_map()
 - PATCH 7 & 8 covers the broadcast flags
 - PATCH 9 covers the XDP egress programs
 - PATCH 10 removes test_xdp_redirect_multi.sh

Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>
---
Changes in v2:
- Use serial_test_* to avoid conflict between tests
- Link to v1: https://lore.kernel.org/r/20250121-redirect-multi-v1-0-b215e35ff505@bootlin.com

---
Bastien Curutchet (eBPF Foundation) (10):
      selftests/bpf: test_xdp_veth: Split network configuration
      selftests/bpf: Remove unused argument
      selftests/bpf: test_xdp_veth: Rename config[]
      selftests/bpf: test_xdp_veth: Add prog_config[] table
      selftests/bpf: test_xdp_veth: Add XDP flags to prog_configuration
      selftests/bpf: test_xdp_veth: Add new test cases for XDP flags
      selftests/bpf: Optionally select broadcasting flags
      selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests
      selftests/bpf: test_xdp_veth: Add XDP program on egress test
      selftests/bpf: Remove test_xdp_redirect_multi.sh

 tools/testing/selftests/bpf/Makefile               |   2 -
 .../selftests/bpf/prog_tests/test_xdp_veth.c       | 534 +++++++++++++++++----
 .../testing/selftests/bpf/progs/xdp_redirect_map.c |  89 ++++
 .../selftests/bpf/progs/xdp_redirect_multi_kern.c  |  41 +-
 .../selftests/bpf/test_xdp_redirect_multi.sh       | 214 ---------
 tools/testing/selftests/bpf/xdp_redirect_multi.c   | 226 ---------
 6 files changed, 553 insertions(+), 553 deletions(-)
---
base-commit: 349e0551b929b4712b4d6127f67dfa41ed48d5a2
change-id: 20250103-redirect-multi-245d6eafb5d1

Best regards,
-- 
Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>

On 01/21, Bastien Curutchet (eBPF Foundation) wrote:
> Hi all,
> 
> This patch series continues the work to migrate the *.sh tests into
> prog_tests framework.
> 
> test_xdp_redirect_multi.sh tests the XDP redirections done through
> bpf_redirect_map().
> 
> This is already partly covered by test_xdp_veth.c that already tests
> map redirections at XDP level. What isn't covered yet by test_xdp_veth is
> the use of the broadcast flags (BPF_F_BROADCAST or BPF_F_EXCLUDE_INGRESS)
> and XDP egress programs.
> 
> Hence, this patch series add test cases to test_xdp_veth.c to get rid of
> the test_xdp_redirect_multi.sh:
>  - PATCH 1 to 5 rework test_xdp_veth to make it more generic and allow to
>    configure different test cases
>  - PATCH 6 adds test cases for 'classic' bpf_redirect_map()
>  - PATCH 7 & 8 covers the broadcast flags
>  - PATCH 9 covers the XDP egress programs
>  - PATCH 10 removes test_xdp_redirect_multi.sh
> 
> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>
> ---
> Changes in v2:
> - Use serial_test_* to avoid conflict between tests

Do I understand correctly that we want them serial mostly because of the
hard-coded namespace names? If yes, might be a good idea to follow up
(separately) with a way to generate unique name for each subtest and
unserialize them.

(If you have time/desire, I think there is a bunch of similar cases
where we have to serialize tests, might as well undo that).

I looked briefly through the series, looks good:

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

Hi Stanislav

On 1/23/25 8:45 PM, Stanislav Fomichev wrote:
> On 01/21, Bastien Curutchet (eBPF Foundation) wrote:
>> Hi all,
>>
>> This patch series continues the work to migrate the *.sh tests into
>> prog_tests framework.
>>
>> test_xdp_redirect_multi.sh tests the XDP redirections done through
>> bpf_redirect_map().
>>
>> This is already partly covered by test_xdp_veth.c that already tests
>> map redirections at XDP level. What isn't covered yet by test_xdp_veth is
>> the use of the broadcast flags (BPF_F_BROADCAST or BPF_F_EXCLUDE_INGRESS)
>> and XDP egress programs.
>>
>> Hence, this patch series add test cases to test_xdp_veth.c to get rid of
>> the test_xdp_redirect_multi.sh:
>>   - PATCH 1 to 5 rework test_xdp_veth to make it more generic and allow to
>>     configure different test cases
>>   - PATCH 6 adds test cases for 'classic' bpf_redirect_map()
>>   - PATCH 7 & 8 covers the broadcast flags
>>   - PATCH 9 covers the XDP egress programs
>>   - PATCH 10 removes test_xdp_redirect_multi.sh
>>
>> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>
>> ---
>> Changes in v2:
>> - Use serial_test_* to avoid conflict between tests
> 
> Do I understand correctly that we want them serial mostly because of the
> hard-coded namespace names? If yes, might be a good idea to follow up
> (separately) with a way to generate unique name for each subtest and
> unserialize them.
> 

Yes, that's it. Ok, I'll send a V3 with random namespace names.

> (If you have time/desire, I think there is a bunch of similar cases
> where we have to serialize tests, might as well undo that).
> 

I'll try to look at it.

> I looked briefly through the series, looks good:
> 
> Acked-by: Stanislav Fomichev <sdf@fomichev.me>


Best regards,
Bastien