[PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support

Vijendar Mukunda posted 23 patches 11 months ago
include/sound/acp70_chip_offset_byte.h   | 484 +++++++++++++
sound/soc/amd/Kconfig                    |  12 +
sound/soc/amd/Makefile                   |   1 +
sound/soc/amd/acp/Makefile               |   2 +-
sound/soc/amd/acp/acp-sdw-legacy-mach.c  |  16 +
sound/soc/amd/acp/acp-sdw-mach-common.c  |  34 +
sound/soc/amd/acp/amd-acp70-acpi-match.c | 132 ++++
sound/soc/amd/acp/soc_amd_sdw_common.h   |  11 +
sound/soc/amd/acp70/Makefile             |   9 +
sound/soc/amd/acp70/acp70-pdm-dma.c      | 463 +++++++++++++
sound/soc/amd/acp70/acp70-sdw-dma.c      | 586 ++++++++++++++++
sound/soc/amd/acp70/acp70.h              | 288 ++++++++
sound/soc/amd/acp70/pci-acp70.c          | 833 +++++++++++++++++++++++
sound/soc/amd/mach-config.h              |   1 +
14 files changed, 2871 insertions(+), 1 deletion(-)
create mode 100644 include/sound/acp70_chip_offset_byte.h
create mode 100644 sound/soc/amd/acp/amd-acp70-acpi-match.c
create mode 100644 sound/soc/amd/acp70/Makefile
create mode 100644 sound/soc/amd/acp70/acp70-pdm-dma.c
create mode 100644 sound/soc/amd/acp70/acp70-sdw-dma.c
create mode 100644 sound/soc/amd/acp70/acp70.h
create mode 100644 sound/soc/amd/acp70/pci-acp70.c
[PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support
Posted by Vijendar Mukunda 11 months ago
This patch series includes below changes
	- Add Audio IO support for ACP7.0 and ACP7.1 platforms for
	SoundWire IO and ACP PDM controller combination.
	- Add common driver modules for ACP7.0 and ACP7.1 platforms
	(acp pci driver, Soundwire dma driver, pdm platform driver).
	- Add SoundWire generic machine driver changes for legacy stack
	(No DSP enabled) for ACP7.0 & ACP7.1 platforms.
	- Add SoundWire machines for ACP7.0 & ACP7.1 platforms.

Changes since v1:
	- Change the code sequence for handling SoundWire wake interrupts.
	- Add new patch to restore host wake interrupt mask
	- Add new patch to enable ACP PME during ACP init sequence.
	- Change ACP PCI driver PM ops code sequence.

Vijendar Mukunda (23):
  ASoC: amd: add register header file for ACP7.0 platform
  ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
  ASoC: amd: acp70: add acp init and de-init functions
  ASoC: amd: acp70: add logic for scanning acp child devices
  ASoC: amd: acp70: create platform devices for acp child nodes
  ASoC: amd: acp70: enable driver build for ACP7.0 platform
  ASoC: amd: acp70: add acp pdm platform driver
  ASoC: amd: acp70: add acp pdm driver dma ops and dai ops
  ASoC: amd: acp70: add acp soundwire dma driver
  ASoC: amd: update ACP7.0 KConfig option description
  ASoC: amd: acp70: add soundwire dma driver dma ops
  ASoC: amd: acp70: add acp ip interrupt handler
  ASoC: amd: acp70: add acp pdm driver pm ops
  ASoC: amd: acp70: add pm ops support for soundwire dma driver
  ASoC: amd: acp70: add acp driver pm ops support
  ASoC: amd: acp70: enable wake capability for acp pci driver
  ASoC: amd: acp70: add soundwire wake interrupt handling
  ASoC: amd: acp70: enable soundwire host wake irq mask
  ASoC: amd: acp70: enable acp pme enable during acp init sequence
  ASoC: amd: acp70: create a device node for soundwire machine driver
  ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1
    platforms
  ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform
  ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support

 include/sound/acp70_chip_offset_byte.h   | 484 +++++++++++++
 sound/soc/amd/Kconfig                    |  12 +
 sound/soc/amd/Makefile                   |   1 +
 sound/soc/amd/acp/Makefile               |   2 +-
 sound/soc/amd/acp/acp-sdw-legacy-mach.c  |  16 +
 sound/soc/amd/acp/acp-sdw-mach-common.c  |  34 +
 sound/soc/amd/acp/amd-acp70-acpi-match.c | 132 ++++
 sound/soc/amd/acp/soc_amd_sdw_common.h   |  11 +
 sound/soc/amd/acp70/Makefile             |   9 +
 sound/soc/amd/acp70/acp70-pdm-dma.c      | 463 +++++++++++++
 sound/soc/amd/acp70/acp70-sdw-dma.c      | 586 ++++++++++++++++
 sound/soc/amd/acp70/acp70.h              | 288 ++++++++
 sound/soc/amd/acp70/pci-acp70.c          | 833 +++++++++++++++++++++++
 sound/soc/amd/mach-config.h              |   1 +
 14 files changed, 2871 insertions(+), 1 deletion(-)
 create mode 100644 include/sound/acp70_chip_offset_byte.h
 create mode 100644 sound/soc/amd/acp/amd-acp70-acpi-match.c
 create mode 100644 sound/soc/amd/acp70/Makefile
 create mode 100644 sound/soc/amd/acp70/acp70-pdm-dma.c
 create mode 100644 sound/soc/amd/acp70/acp70-sdw-dma.c
 create mode 100644 sound/soc/amd/acp70/acp70.h
 create mode 100644 sound/soc/amd/acp70/pci-acp70.c

-- 
2.34.1
Re: [PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support
Posted by Mark Brown 10 months, 1 week ago
On Mon, 20 Jan 2025 15:31:07 +0530, Vijendar Mukunda wrote:
> This patch series includes below changes
> 	- Add Audio IO support for ACP7.0 and ACP7.1 platforms for
> 	SoundWire IO and ACP PDM controller combination.
> 	- Add common driver modules for ACP7.0 and ACP7.1 platforms
> 	(acp pci driver, Soundwire dma driver, pdm platform driver).
> 	- Add SoundWire generic machine driver changes for legacy stack
> 	(No DSP enabled) for ACP7.0 & ACP7.1 platforms.
> 	- Add SoundWire machines for ACP7.0 & ACP7.1 platforms.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/23] ASoC: amd: add register header file for ACP7.0 platform
        (no commit info)
[02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
        (no commit info)
[03/23] ASoC: amd: acp70: add acp init and de-init functions
        (no commit info)
[04/23] ASoC: amd: acp70: add logic for scanning acp child devices
        (no commit info)
[05/23] ASoC: amd: acp70: create platform devices for acp child nodes
        (no commit info)
[06/23] ASoC: amd: acp70: enable driver build for ACP7.0 platform
        (no commit info)
[07/23] ASoC: amd: acp70: add acp pdm platform driver
        (no commit info)
[08/23] ASoC: amd: acp70: add acp pdm driver dma ops and dai ops
        (no commit info)
[09/23] ASoC: amd: acp70: add acp soundwire dma driver
        (no commit info)
[10/23] ASoC: amd: update ACP7.0 KConfig option description
        (no commit info)
[11/23] ASoC: amd: acp70: add soundwire dma driver dma ops
        (no commit info)
[12/23] ASoC: amd: acp70: add acp ip interrupt handler
        (no commit info)
[13/23] ASoC: amd: acp70: add acp pdm driver pm ops
        (no commit info)
[14/23] ASoC: amd: acp70: add pm ops support for soundwire dma driver
        (no commit info)
[15/23] ASoC: amd: acp70: add acp driver pm ops support
        (no commit info)
[16/23] ASoC: amd: acp70: enable wake capability for acp pci driver
        (no commit info)
[17/23] ASoC: amd: acp70: add soundwire wake interrupt handling
        (no commit info)
[18/23] ASoC: amd: acp70: enable soundwire host wake irq mask
        (no commit info)
[19/23] ASoC: amd: acp70: enable acp pme enable during acp init sequence
        (no commit info)
[20/23] ASoC: amd: acp70: create a device node for soundwire machine driver
        (no commit info)
[21/23] ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1 platforms
        commit: 638ad2bdb2f994c8bd99cc40e0c4796a8617ccf3
[22/23] ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform
        commit: 187150671d83324f1ca56f7ab5e00f16a3b9f2a9
[23/23] ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support
        commit: d0252b0b945ec67fd09fc764dcadf445fb7757ee

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: [PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support
Posted by Mukunda,Vijendar 10 months, 1 week ago
On 10/02/25 21:59, Mark Brown wrote:
> On Mon, 20 Jan 2025 15:31:07 +0530, Vijendar Mukunda wrote:
>> This patch series includes below changes
>> 	- Add Audio IO support for ACP7.0 and ACP7.1 platforms for
>> 	SoundWire IO and ACP PDM controller combination.
>> 	- Add common driver modules for ACP7.0 and ACP7.1 platforms
>> 	(acp pci driver, Soundwire dma driver, pdm platform driver).
>> 	- Add SoundWire generic machine driver changes for legacy stack
>> 	(No DSP enabled) for ACP7.0 & ACP7.1 platforms.
>> 	- Add SoundWire machines for ACP7.0 & ACP7.1 platforms.
>>
>> [...]
This patch series should be dropped and V3 version should be picked.
> Applied to
>
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!
>
> [01/23] ASoC: amd: add register header file for ACP7.0 platform
>         (no commit info)
> [02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
>         (no commit info)
> [03/23] ASoC: amd: acp70: add acp init and de-init functions
>         (no commit info)
> [04/23] ASoC: amd: acp70: add logic for scanning acp child devices
>         (no commit info)
> [05/23] ASoC: amd: acp70: create platform devices for acp child nodes
>         (no commit info)
> [06/23] ASoC: amd: acp70: enable driver build for ACP7.0 platform
>         (no commit info)
> [07/23] ASoC: amd: acp70: add acp pdm platform driver
>         (no commit info)
> [08/23] ASoC: amd: acp70: add acp pdm driver dma ops and dai ops
>         (no commit info)
> [09/23] ASoC: amd: acp70: add acp soundwire dma driver
>         (no commit info)
> [10/23] ASoC: amd: update ACP7.0 KConfig option description
>         (no commit info)
> [11/23] ASoC: amd: acp70: add soundwire dma driver dma ops
>         (no commit info)
> [12/23] ASoC: amd: acp70: add acp ip interrupt handler
>         (no commit info)
> [13/23] ASoC: amd: acp70: add acp pdm driver pm ops
>         (no commit info)
> [14/23] ASoC: amd: acp70: add pm ops support for soundwire dma driver
>         (no commit info)
> [15/23] ASoC: amd: acp70: add acp driver pm ops support
>         (no commit info)
> [16/23] ASoC: amd: acp70: enable wake capability for acp pci driver
>         (no commit info)
> [17/23] ASoC: amd: acp70: add soundwire wake interrupt handling
>         (no commit info)
> [18/23] ASoC: amd: acp70: enable soundwire host wake irq mask
>         (no commit info)
> [19/23] ASoC: amd: acp70: enable acp pme enable during acp init sequence
>         (no commit info)
> [20/23] ASoC: amd: acp70: create a device node for soundwire machine driver
>         (no commit info)
> [21/23] ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1 platforms
>         commit: 638ad2bdb2f994c8bd99cc40e0c4796a8617ccf3
> [22/23] ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform
>         commit: 187150671d83324f1ca56f7ab5e00f16a3b9f2a9
> [23/23] ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support
>         commit: d0252b0b945ec67fd09fc764dcadf445fb7757ee
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
Re: [PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support
Posted by Mark Brown 10 months, 1 week ago
On Mon, Feb 10, 2025 at 10:16:05PM +0530, Mukunda,Vijendar wrote:
> On 10/02/25 21:59, Mark Brown wrote:

> >> [...]

> This patch series should be dropped and V3 version should be picked.

All the "no commit info"s here:

> > [01/23] ASoC: amd: add register header file for ACP7.0 platform
> >         (no commit info)
> > [02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
> >         (no commit info)
> > [03/23] ASoC: amd: acp70: add acp init and de-init functions
> >         (no commit info)
> > [04/23] ASoC: amd: acp70: add logic for scanning acp child devices
> >         (no commit info)
> > [05/23] ASoC: amd: acp70: create platform devices for acp child nodes
> >         (no commit info)
> > [06/23] ASoC: amd: acp70: enable driver build for ACP7.0 platform
> >         (no commit info)
> > [07/23] ASoC: amd: acp70: add acp pdm platform driver
> >         (no commit info)
> > [08/23] ASoC: amd: acp70: add acp pdm driver dma ops and dai ops
> >         (no commit info)
> > [09/23] ASoC: amd: acp70: add acp soundwire dma driver
> >         (no commit info)
> > [10/23] ASoC: amd: update ACP7.0 KConfig option description
> >         (no commit info)
> > [11/23] ASoC: amd: acp70: add soundwire dma driver dma ops
> >         (no commit info)
> > [12/23] ASoC: amd: acp70: add acp ip interrupt handler
> >         (no commit info)
> > [13/23] ASoC: amd: acp70: add acp pdm driver pm ops
> >         (no commit info)
> > [14/23] ASoC: amd: acp70: add pm ops support for soundwire dma driver
> >         (no commit info)
> > [15/23] ASoC: amd: acp70: add acp driver pm ops support
> >         (no commit info)
> > [16/23] ASoC: amd: acp70: enable wake capability for acp pci driver
> >         (no commit info)
> > [17/23] ASoC: amd: acp70: add soundwire wake interrupt handling
> >         (no commit info)
> > [18/23] ASoC: amd: acp70: enable soundwire host wake irq mask
> >         (no commit info)
> > [19/23] ASoC: amd: acp70: enable acp pme enable during acp init sequence
> >         (no commit info)
> > [20/23] ASoC: amd: acp70: create a device node for soundwire machine driver
> >         (no commit info)

mean that these patches weren't actually applied, it's only these ones:

> > [21/23] ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1 platforms
> >         commit: 638ad2bdb2f994c8bd99cc40e0c4796a8617ccf3
> > [22/23] ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform
> >         commit: 187150671d83324f1ca56f7ab5e00f16a3b9f2a9
> > [23/23] ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support
> >         commit: d0252b0b945ec67fd09fc764dcadf445fb7757ee

which were actually applied out of v3, they just didn't change much if
at all between the two versions and the tooling knew about v2 as well.
Re: [PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support
Posted by Mukunda,Vijendar 10 months, 1 week ago
On 10/02/25 23:34, Mark Brown wrote:
> On Mon, Feb 10, 2025 at 10:16:05PM +0530, Mukunda,Vijendar wrote:
>> On 10/02/25 21:59, Mark Brown wrote:
>>>> [...]
>> This patch series should be dropped and V3 version should be picked.
> All the "no commit info"s here:
>
>>> [01/23] ASoC: amd: add register header file for ACP7.0 platform
>>>         (no commit info)
>>> [02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
>>>         (no commit info)
>>> [03/23] ASoC: amd: acp70: add acp init and de-init functions
>>>         (no commit info)
>>> [04/23] ASoC: amd: acp70: add logic for scanning acp child devices
>>>         (no commit info)
>>> [05/23] ASoC: amd: acp70: create platform devices for acp child nodes
>>>         (no commit info)
>>> [06/23] ASoC: amd: acp70: enable driver build for ACP7.0 platform
>>>         (no commit info)
>>> [07/23] ASoC: amd: acp70: add acp pdm platform driver
>>>         (no commit info)
>>> [08/23] ASoC: amd: acp70: add acp pdm driver dma ops and dai ops
>>>         (no commit info)
>>> [09/23] ASoC: amd: acp70: add acp soundwire dma driver
>>>         (no commit info)
>>> [10/23] ASoC: amd: update ACP7.0 KConfig option description
>>>         (no commit info)
>>> [11/23] ASoC: amd: acp70: add soundwire dma driver dma ops
>>>         (no commit info)
>>> [12/23] ASoC: amd: acp70: add acp ip interrupt handler
>>>         (no commit info)
>>> [13/23] ASoC: amd: acp70: add acp pdm driver pm ops
>>>         (no commit info)
>>> [14/23] ASoC: amd: acp70: add pm ops support for soundwire dma driver
>>>         (no commit info)
>>> [15/23] ASoC: amd: acp70: add acp driver pm ops support
>>>         (no commit info)
>>> [16/23] ASoC: amd: acp70: enable wake capability for acp pci driver
>>>         (no commit info)
>>> [17/23] ASoC: amd: acp70: add soundwire wake interrupt handling
>>>         (no commit info)
>>> [18/23] ASoC: amd: acp70: enable soundwire host wake irq mask
>>>         (no commit info)
>>> [19/23] ASoC: amd: acp70: enable acp pme enable during acp init sequence
>>>         (no commit info)
>>> [20/23] ASoC: amd: acp70: create a device node for soundwire machine driver
>>>         (no commit info)
> mean that these patches weren't actually applied, it's only these ones:
>
>>> [21/23] ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1 platforms
>>>         commit: 638ad2bdb2f994c8bd99cc40e0c4796a8617ccf3
>>> [22/23] ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform
>>>         commit: 187150671d83324f1ca56f7ab5e00f16a3b9f2a9
>>> [23/23] ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support
>>>         commit: d0252b0b945ec67fd09fc764dcadf445fb7757ee
> which were actually applied out of v3, they just didn't change much if
> at all between the two versions and the tooling knew about v2 as well.
Got it. Thanks