1. Patchew
  2. linux
  3. View series

[PATCH V2] dt-bindings: serial: Add a new compatible string for UMS9632

Wenhua Lin posted 1 patch 1 year ago
There is a newer version of this series
Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
[PATCH V2] dt-bindings: serial: Add a new compatible string for UMS9632
Posted by Wenhua Lin 1 year ago 
The sc9632-uart is incompatible
with sc9836-uart, Add sc9632-uart dedicated compatible
for representing uart of the new project UMS9632 SoC.

Change in V2:
-Change commit message in PATCH 2/2.
-Modify the compatible string of enum in PATCH 2/2.

Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
---
 Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
index a2a5056eba04..83582aa6c750 100644
--- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
@@ -17,13 +17,17 @@ properties:
     oneOf:
       - items:
           - enum:
-              - sprd,sc9632-uart
               - sprd,sc9860-uart
               - sprd,sc9863a-uart
               - sprd,ums512-uart
               - sprd,ums9620-uart
           - const: sprd,sc9836-uart
       - const: sprd,sc9836-uart
+      - items:
+          - enum:
+              - sprd,ums9632-uart
+          - const: sprd,sc9632-uart
+      - const: sprd,sc9632-uart
 
   reg:
     maxItems: 1
-- 
2.34.1
Re: [PATCH V2] dt-bindings: serial: Add a new compatible string for UMS9632
Posted by Krzysztof Kozlowski 1 year ago 
On Mon, Jan 20, 2025 at 11:22:12AM +0800, Wenhua Lin wrote:
> The sc9632-uart is incompatible
> with sc9836-uart, Add sc9632-uart dedicated compatible

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Missing full stop.

Your commit msg should explain briefly why sc9632-uart is incompatible
with sc9836-uart.

> for representing uart of the new project UMS9632 SoC.
> 
> Change in V2:
> -Change commit message in PATCH 2/2.
> -Modify the compatible string of enum in PATCH 2/2.

Changelog goes to changelog place, under ---.

> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> index a2a5056eba04..83582aa6c750 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> @@ -17,13 +17,17 @@ properties:
>      oneOf:
>        - items:
>            - enum:
> -              - sprd,sc9632-uart
>                - sprd,sc9860-uart
>                - sprd,sc9863a-uart
>                - sprd,ums512-uart
>                - sprd,ums9620-uart
>            - const: sprd,sc9836-uart
>        - const: sprd,sc9836-uart
> +      - items:
> +          - enum:
> +              - sprd,ums9632-uart
> +          - const: sprd,sc9632-uart

Lists are ordered by fallback, so this goes before list ending
sprd,sc9836-uart. Do not break orders by putting everything always at
the end.

> +      - const: sprd,sc9632-uart

Combine two such const items into enum:
  - enum
      - sprd,sc9632-uart
      - sprd,sc9836-uart

Best regards,
Krzysztof
Re: [PATCH V2] dt-bindings: serial: Add a new compatible string for UMS9632
Posted by wenhua lin 1 year ago 
On Mon, Jan 20, 2025 at 3:48 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Jan 20, 2025 at 11:22:12AM +0800, Wenhua Lin wrote:
> > The sc9632-uart is incompatible
> > with sc9836-uart, Add sc9632-uart dedicated compatible
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Missing full stop.
>
> Your commit msg should explain briefly why sc9632-uart is incompatible
> with sc9836-uart.
>
> > for representing uart of the new project UMS9632 SoC.
> >
> > Change in V2:
> > -Change commit message in PATCH 2/2.
> > -Modify the compatible string of enum in PATCH 2/2.
>
> Changelog goes to changelog place, under ---.
>
> >
> > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> > ---
> >  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> > index a2a5056eba04..83582aa6c750 100644
> > --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> > @@ -17,13 +17,17 @@ properties:
> >      oneOf:
> >        - items:
> >            - enum:
> > -              - sprd,sc9632-uart
> >                - sprd,sc9860-uart
> >                - sprd,sc9863a-uart
> >                - sprd,ums512-uart
> >                - sprd,ums9620-uart
> >            - const: sprd,sc9836-uart
> >        - const: sprd,sc9836-uart
> > +      - items:
> > +          - enum:
> > +              - sprd,ums9632-uart
> > +          - const: sprd,sc9632-uart
>
> Lists are ordered by fallback, so this goes before list ending
> sprd,sc9836-uart. Do not break orders by putting everything always at
> the end.
>
> > +      - const: sprd,sc9632-uart
>
> Combine two such const items into enum:
>   - enum
>       - sprd,sc9632-uart
>       - sprd,sc9836-uart
>

Hi Krzysztof:
   Thank you very much for your review, we will correct it in patch v3.
Thanks

> Best regards,
> Krzysztof
>
Re: [PATCH V2] dt-bindings: serial: Add a new compatible string for UMS9632
Posted by wenhua lin 1 year ago 
On Mon, Jan 20, 2025 at 11:23 AM Wenhua Lin <Wenhua.Lin@unisoc.com> wrote:
>
> The sc9632-uart is incompatible
> with sc9836-uart, Add sc9632-uart dedicated compatible
> for representing uart of the new project UMS9632 SoC.
>
> Change in V2:
> -Change commit message in PATCH 2/2.
> -Modify the compatible string of enum in PATCH 2/2.
>
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> index a2a5056eba04..83582aa6c750 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> @@ -17,13 +17,17 @@ properties:
>      oneOf:
>        - items:
>            - enum:
> -              - sprd,sc9632-uart
>                - sprd,sc9860-uart
>                - sprd,sc9863a-uart
>                - sprd,ums512-uart
>                - sprd,ums9620-uart
>            - const: sprd,sc9836-uart
>        - const: sprd,sc9836-uart
> +      - items:
> +          - enum:
> +              - sprd,ums9632-uart
> +          - const: sprd,sc9632-uart
> +      - const: sprd,sc9632-uart
>
>    reg:
>      maxItems: 1
> --
> 2.34.1
>

Hi Krzysztof:
PATCH V2 dt_binding_check test result:
cixi.geng1@tj10039pcu:~/p/sprdikt/kernel$ make DT_CHECKER_FLAGS=-m
dt_binding_check W=1 O=$OUT/dt-out
DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/sprd-uart.yaml
make[1]: Entering directory '/home/cixi.geng1/p/sprdikt/out/dt-out'
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
/home/cixi.geng1/p/sprdikt/kernel/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml:
io-backends: missing type definition
/home/cixi.geng1/p/sprdikt/kernel/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml:
post-init-providers: missing type definition
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/dtc/dtc.o
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/util.o
  LEX     scripts/dtc/dtc-lexer.lex.c
  YACC    scripts/dtc/dtc-parser.tab.[ch]
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
  HOSTLD  scripts/dtc/dtc
  CHKDT   /home/cixi.geng1/p/sprdikt/kernel/Documentation/devicetree/bindings
  LINT    /home/cixi.geng1/p/sprdikt/kernel/Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/serial/sprd-uart.example.dts
  DTC [C] Documentation/devicetree/bindings/serial/sprd-uart.example.dtb
make[1]: Leaving directory '/home/cixi.geng1/p/sprdikt/out/dt-out'

Thanks

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.