[PATCH v1 1/3] dt-bindings: usb: dwc3: Add a property to reserve endpoints

Andy Shevchenko posted 3 patches 11 months ago
There is a newer version of this series
[PATCH v1 1/3] dt-bindings: usb: dwc3: Add a property to reserve endpoints
Posted by Andy Shevchenko 11 months ago
Some of the endpoints may be reserved by hardware for different purposes,
e.g., tracing control and output. This is the case, for instance, on
Intel Merrifield and Moorefield platforms that reserve a few and USB driver
may not use them for the regular transfers. Add the respective bindings.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index 1cd0ca90127d..2ae8e5e85f78 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -109,6 +109,16 @@ properties:
   resets:
     minItems: 1
 
+  snps,reserved-endpoints:
+    description:
+      Reserve endpoints for other needs, e.g, for tracing control and output.
+      When set, the driver will avoid using them for the regular USB transfers.
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    maxItems: 30
+    items:
+      minimum: 2
+      maximum: 31
+
   snps,usb2-lpm-disable:
     description: Indicate if we don't want to enable USB2 HW LPM for host
       mode.
-- 
2.43.0.rc1.1336.g36b5255a03ac
Re: [PATCH v1 1/3] dt-bindings: usb: dwc3: Add a property to reserve endpoints
Posted by Rob Herring 10 months, 3 weeks ago
On Thu, Jan 16, 2025 at 05:40:46PM +0200, Andy Shevchenko wrote:
> Some of the endpoints may be reserved by hardware for different purposes,
> e.g., tracing control and output. This is the case, for instance, on
> Intel Merrifield and Moorefield platforms that reserve a few and USB driver
> may not use them for the regular transfers. Add the respective bindings.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 1cd0ca90127d..2ae8e5e85f78 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -109,6 +109,16 @@ properties:
>    resets:
>      minItems: 1
>  
> +  snps,reserved-endpoints:
> +    description:
> +      Reserve endpoints for other needs, e.g, for tracing control and output.
> +      When set, the driver will avoid using them for the regular USB transfers.
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    maxItems: 30

Please make minItems explicit.

> +    items:
> +      minimum: 2
> +      maximum: 31
> +
>    snps,usb2-lpm-disable:
>      description: Indicate if we don't want to enable USB2 HW LPM for host
>        mode.
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
>
Re: [PATCH v1 1/3] dt-bindings: usb: dwc3: Add a property to reserve endpoints
Posted by Andy Shevchenko 10 months, 3 weeks ago
On Thu, Jan 23, 2025 at 04:09:46PM -0600, Rob Herring wrote:
> On Thu, Jan 16, 2025 at 05:40:46PM +0200, Andy Shevchenko wrote:
> > Some of the endpoints may be reserved by hardware for different purposes,
> > e.g., tracing control and output. This is the case, for instance, on
> > Intel Merrifield and Moorefield platforms that reserve a few and USB driver
> > may not use them for the regular transfers. Add the respective bindings.

...

> > +  snps,reserved-endpoints:
> > +    description:
> > +      Reserve endpoints for other needs, e.g, for tracing control and output.
> > +      When set, the driver will avoid using them for the regular USB transfers.
> > +    $ref: /schemas/types.yaml#/definitions/uint8-array
> > +    maxItems: 30
> 
> Please make minItems explicit.

    minItems: 0
    maxItems: 30

Is this what you want to see here?

> > +    items:
> > +      minimum: 2
> > +      maximum: 31

-- 
With Best Regards,
Andy Shevchenko