s390/vfio-ap: Fix indentation in vfio_ap_mdev_ioctl()

[PATCH] s390/vfio-ap: Fix indentation in vfio_ap_mdev_ioctl()

Posted by Thorsten Blum 2 weeks, 6 days ago

Remove any extra indentation to improve the code's readability.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
index a52c2690933f..155e19aef5df 100644
--- a/drivers/s390/crypto/vfio_ap_ops.c
+++ b/drivers/s390/crypto/vfio_ap_ops.c
@@ -2199,8 +2199,8 @@ static ssize_t vfio_ap_mdev_ioctl(struct vfio_device *vdev,
 		ret = vfio_ap_mdev_reset_queues(matrix_mdev);
 		break;
 	case VFIO_DEVICE_GET_IRQ_INFO:
-			ret = vfio_ap_get_irq_info(arg);
-			break;
+		ret = vfio_ap_get_irq_info(arg);
+		break;
 	case VFIO_DEVICE_SET_IRQS:
 		ret = vfio_ap_set_irqs(matrix_mdev, arg);
 		break;
-- 
2.48.0

Re: [PATCH] s390/vfio-ap: Fix indentation in vfio_ap_mdev_ioctl()

Posted by Alexander Gordeev 6 days, 23 hours ago

On Thu, Jan 16, 2025 at 02:11:47PM +0100, Thorsten Blum wrote:
> Remove any extra indentation to improve the code's readability.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> index a52c2690933f..155e19aef5df 100644
> --- a/drivers/s390/crypto/vfio_ap_ops.c
> +++ b/drivers/s390/crypto/vfio_ap_ops.c
> @@ -2199,8 +2199,8 @@ static ssize_t vfio_ap_mdev_ioctl(struct vfio_device *vdev,
>  		ret = vfio_ap_mdev_reset_queues(matrix_mdev);
>  		break;
>  	case VFIO_DEVICE_GET_IRQ_INFO:
> -			ret = vfio_ap_get_irq_info(arg);
> -			break;
> +		ret = vfio_ap_get_irq_info(arg);
> +		break;
>  	case VFIO_DEVICE_SET_IRQS:
>  		ret = vfio_ap_set_irqs(matrix_mdev, arg);
>  		break;

Applied, thanks!

Re: [PATCH] s390/vfio-ap: Fix indentation in vfio_ap_mdev_ioctl()

Posted by Anthony Krowiak 2 weeks, 6 days ago



On 1/16/25 8:11 AM, Thorsten Blum wrote:
> Remove any extra indentation to improve the code's readability.

Ironically, I noticed this the other day and was going to fix it.

Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>

>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>   drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> index a52c2690933f..155e19aef5df 100644
> --- a/drivers/s390/crypto/vfio_ap_ops.c
> +++ b/drivers/s390/crypto/vfio_ap_ops.c
> @@ -2199,8 +2199,8 @@ static ssize_t vfio_ap_mdev_ioctl(struct vfio_device *vdev,
>   		ret = vfio_ap_mdev_reset_queues(matrix_mdev);
>   		break;
>   	case VFIO_DEVICE_GET_IRQ_INFO:
> -			ret = vfio_ap_get_irq_info(arg);
> -			break;
> +		ret = vfio_ap_get_irq_info(arg);
> +		break;
>   	case VFIO_DEVICE_SET_IRQS:
>   		ret = vfio_ap_set_irqs(matrix_mdev, arg);
>   		break;