cpufreq: Introduce a more generic way to boost when cpu is going online

[PATCH 0/2] cpufreq: Introduce a more generic way to boost when cpu is going online

Posted by Lifeng Zheng 3 weeks ago

Since commit f37a4d6b4a2c ("cpufreq: Fix per-policy boost behavior on
SoCs using cpufreq_boost_set_sw()") and commit 102fa9c4b439 ("cpufreq:
Allow drivers to advertise boost enabled"), per-policy boost flag has
already been set to mirror the cpufreq_driver boost during
initialization. However, the current implementation doesn't work for all
cpufreq drivers and may fail in certain situation. A more generic
implementation is needed.

Lifeng Zheng (2):
  cpufreq: Fix re-boost issue after hotplugging a cpu
  cpufreq: Introduce a more generic way to set default per-policy boost
    flag

 drivers/cpufreq/cpufreq.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

-- 
2.33.0

Re: [PATCH 0/2] cpufreq: Introduce a more generic way to boost when cpu is going online

Posted by Rafael J. Wysocki 3 weeks ago

On Wed, Jan 15, 2025 at 11:01 AM Lifeng Zheng <zhenglifeng1@huawei.com> wrote:
>
> Since commit f37a4d6b4a2c ("cpufreq: Fix per-policy boost behavior on
> SoCs using cpufreq_boost_set_sw()") and commit 102fa9c4b439 ("cpufreq:
> Allow drivers to advertise boost enabled"), per-policy boost flag has
> already been set to mirror the cpufreq_driver boost during
> initialization. However, the current implementation doesn't work for all
> cpufreq drivers and may fail in certain situation. A more generic
> implementation is needed.

Can you please be more specific here?

What happens, why it happens and why do you think the way to go is to
reimplement this?

Re: [PATCH 0/2] cpufreq: Introduce a more generic way to boost when cpu is going online

Posted by zhenglifeng (A) 2 weeks, 6 days ago

On 2025/1/15 20:53, Rafael J. Wysocki wrote:

> On Wed, Jan 15, 2025 at 11:01 AM Lifeng Zheng <zhenglifeng1@huawei.com> wrote:
>>
>> Since commit f37a4d6b4a2c ("cpufreq: Fix per-policy boost behavior on
>> SoCs using cpufreq_boost_set_sw()") and commit 102fa9c4b439 ("cpufreq:
>> Allow drivers to advertise boost enabled"), per-policy boost flag has
>> already been set to mirror the cpufreq_driver boost during
>> initialization. However, the current implementation doesn't work for all
>> cpufreq drivers and may fail in certain situation. A more generic
>> implementation is needed.
> 
> Can you please be more specific here?
> 
> What happens, why it happens and why do you think the way to go is to
> reimplement this?

I've explained this in commit log of patch 2. But if you think it is better
to palce here too, I'll do that in v2.