[PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Skitty Chromebooks

Geoffrey Chien posted 2 patches 11 months ago
[PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Skitty Chromebooks
Posted by Geoffrey Chien 11 months ago
Skitty is MT8186 based Chromebook based on the Krabby design.

Skitty also known as the HP Chromebook G1m 11 inch. The device is
a clamshell laptop with an optional touchscreen and keyboard.

The SKU IDs of the Skitty devices map to different touchscreen and
keyboard.

Signed-off-by: Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com>
---
 Documentation/devicetree/bindings/arm/mediatek.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 1d4bb50fcd8d9aadb7b77e144a474b79da005056..b57e86946d7565720fdee31b2bbef288b0508769 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -263,6 +263,14 @@ properties:
           - const: google,steelix-sku196608
           - const: google,steelix
           - const: mediatek,mt8186
+      - description: Google Skitty (HP Chromebook G1m 11 inch)
+        items:
+          - const: google,skitty-sku1
+          - const: google,skitty-sku2
+          - const: google,skitty-sku3
+          - const: google,skitty-sku4
+          - const: google,skitty
+          - const: mediatek,mt8186
       - description: Google Steelix (Lenovo 300e Yoga Chromebook Gen 4)
         items:
           - enum:

-- 
2.34.1
Re: [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Skitty Chromebooks
Posted by Krzysztof Kozlowski 11 months ago
On Wed, Jan 15, 2025 at 03:43:43PM +0800, Geoffrey Chien wrote:
> Skitty is MT8186 based Chromebook based on the Krabby design.
> 
> Skitty also known as the HP Chromebook G1m 11 inch. The device is
> a clamshell laptop with an optional touchscreen and keyboard.
> 
> The SKU IDs of the Skitty devices map to different touchscreen and
> keyboard.
> 
> Signed-off-by: Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com>
> ---
>  Documentation/devicetree/bindings/arm/mediatek.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)

That's a v3? v4? Version properly your patches and provide changelog
under ---. Maybe you even got here tags?

Best regards,
Krzysztof