[PATCH] erofs: fix potential return value overflow of z_erofs_shrink_scan()

Gao Xiang posted 1 patch 11 months ago
fs/erofs/zdata.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] erofs: fix potential return value overflow of z_erofs_shrink_scan()
Posted by Gao Xiang 11 months ago
z_erofs_shrink_scan() could return small numbers due to the mistyped
`freed`.

Although I don't think it has any visible impact.

Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
 fs/erofs/zdata.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 8bafc4d9edbe..057d68eaa5d2 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -915,8 +915,7 @@ unsigned long z_erofs_shrink_scan(struct erofs_sb_info *sbi,
 				  unsigned long nr_shrink)
 {
 	struct z_erofs_pcluster *pcl;
-	unsigned int freed = 0;
-	unsigned long index;
+	unsigned long index, freed = 0;
 
 	xa_lock(&sbi->managed_pslots);
 	xa_for_each(&sbi->managed_pslots, index, pcl) {
-- 
2.43.5
Re: [PATCH] erofs: fix potential return value overflow of z_erofs_shrink_scan()
Posted by Chao Yu 11 months ago
On 1/14/25 12:00, Gao Xiang wrote:
> z_erofs_shrink_scan() could return small numbers due to the mistyped
> `freed`.
> 
> Although I don't think it has any visible impact.

Agreed, it's an extreme case...

> 
> Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,
Re: [PATCH] erofs: fix potential return value overflow of z_erofs_shrink_scan()
Posted by Gao Xiang 11 months ago

On 2025/1/16 16:31, Chao Yu wrote:
> On 1/14/25 12:00, Gao Xiang wrote:
>> z_erofs_shrink_scan() could return small numbers due to the mistyped
>> `freed`.
>>
>> Although I don't think it has any visible impact.
> 
> Agreed, it's an extreme case...

Yeah... also thanks for the review.

Thanks,
Gao Xiang