HID: lenovo: Fix to ensure the data as __le32 instead of u32

[PATCH] HID: lenovo: Fix to ensure the data as __le32 instead of u32

Posted by Vishnu Sankar 11 months, 1 week ago

Ensure that data is treated as __le32 instead of u32 before
applying le32_to_cpu.
This patch fixes the sparse warning "sparse: cast to restricted __le32".

Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
Signed-off-by: Vishnu Sankar <vsankar@lenovo.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501101635.qJrwAOwf-lkp@intel.com/
---
 drivers/hid/hid-lenovo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index 4d00bc4d656e..0d9792750dcf 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -783,7 +783,7 @@ static int lenovo_raw_event(struct hid_device *hdev,
 	if (unlikely((hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB
 			|| hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB2)
 			&& size >= 3 && report->id == 0x03))
-		return lenovo_raw_event_TP_X12_tab(hdev, le32_to_cpu(*(u32 *)data));
+		return lenovo_raw_event_TP_X12_tab(hdev, le32_to_cpu(*(__le32 *)data));
 
 	return 0;
 }
-- 
2.43.0

Re: [PATCH] HID: lenovo: Fix to ensure the data as __le32 instead of u32

Posted by Jiri Kosina 9 months, 2 weeks ago

On Tue, 14 Jan 2025, Vishnu Sankar wrote:

> Ensure that data is treated as __le32 instead of u32 before
> applying le32_to_cpu.
> This patch fixes the sparse warning "sparse: cast to restricted __le32".
> 
> Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
> Signed-off-by: Vishnu Sankar <vsankar@lenovo.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501101635.qJrwAOwf-lkp@intel.com/

Sorry for the delay, this fell in between cracks. Now applied.

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: lenovo: Fix to ensure the data as __le32 instead of u32

Posted by Vishnu Sankar 9 months, 2 weeks ago

Thank you Jiri.

On Wed, Mar 5, 2025 at 5:13 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Tue, 14 Jan 2025, Vishnu Sankar wrote:
>
> > Ensure that data is treated as __le32 instead of u32 before
> > applying le32_to_cpu.
> > This patch fixes the sparse warning "sparse: cast to restricted __le32".
> >
> > Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
> > Signed-off-by: Vishnu Sankar <vsankar@lenovo.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202501101635.qJrwAOwf-lkp@intel.com/
>
> Sorry for the delay, this fell in between cracks. Now applied.
>
> --
> Jiri Kosina
> SUSE Labs
>


-- 

Regards,

      Vishnu Sankar
     +817015150407 (Japan)