arm64: defconfig: Enable BANG BANG Thermal Governor

[PATCH] arm64: defconfig: Enable BANG BANG Thermal Governor

Posted by Garrett Giordano 11 months, 1 week ago

Enable the BANG BANG Thermal Governor to manage the GPIO Fan using
hysteresis on the PHYTEC phyBOARD-Lyra AM625.

Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index c62831e61586..3fd04c689269 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -690,6 +690,7 @@ CONFIG_SENSORS_RASPBERRYPI_HWMON=m
 CONFIG_SENSORS_SL28CPLD=m
 CONFIG_SENSORS_INA2XX=m
 CONFIG_SENSORS_INA3221=m
+CONFIG_THERMAL_GOV_BANG_BANG=y
 CONFIG_THERMAL_GOV_POWER_ALLOCATOR=y
 CONFIG_CPU_THERMAL=y
 CONFIG_DEVFREQ_THERMAL=y
-- 
2.25.1

Re: [Upstream] [PATCH] arm64: defconfig: Enable BANG BANG Thermal Governor

Posted by Daniel Schultz 7 months, 2 weeks ago

Hey,

can someone please take a look at this patch? I can also re-send in case 
it doesn't apply anymore. Thanks!

- Daniel

On 1/13/25 19:56, Garrett Giordano wrote:
> Enable the BANG BANG Thermal Governor to manage the GPIO Fan using
> hysteresis on the PHYTEC phyBOARD-Lyra AM625.
>
> Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
> ---
>   arch/arm64/configs/defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index c62831e61586..3fd04c689269 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -690,6 +690,7 @@ CONFIG_SENSORS_RASPBERRYPI_HWMON=m
>   CONFIG_SENSORS_SL28CPLD=m
>   CONFIG_SENSORS_INA2XX=m
>   CONFIG_SENSORS_INA3221=m
> +CONFIG_THERMAL_GOV_BANG_BANG=y
>   CONFIG_THERMAL_GOV_POWER_ALLOCATOR=y
>   CONFIG_CPU_THERMAL=y
>   CONFIG_DEVFREQ_THERMAL=y

Re: [Upstream] [PATCH] arm64: defconfig: Enable BANG BANG Thermal Governor

Posted by Krzysztof Kozlowski 7 months, 2 weeks ago

On 05/05/2025 10:18, Daniel Schultz wrote:
> Hey,
> 
> can someone please take a look at this patch? I can also re-send in case 
> it doesn't apply anymore. Thanks!

Sounds like a product thingy, so I do not see much need to enable it in
the defconfig.

BTW, the more people you CC, the bigger chance no one will fell
responsible. You Cc-eed ~7 persons not related to your subsystem.

Best regards,
Krzysztof

Re: [Upstream] [PATCH] arm64: defconfig: Enable BANG BANG Thermal Governor

Posted by Daniel Schultz 7 months, 2 weeks ago

On 5/5/25 10:33, Krzysztof Kozlowski wrote:
> On 05/05/2025 10:18, Daniel Schultz wrote:
>> Hey,
>>
>> can someone please take a look at this patch? I can also re-send in case
>> it doesn't apply anymore. Thanks!
>
> Sounds like a product thingy, so I do not see much need to enable it in
> the defconfig.
I'm okay with that. We can handle that downstream but wasn't sure if 
this config would be accepted.
>
> BTW, the more people you CC, the bigger chance no one will fell
> responsible. You Cc-eed ~7 persons not related to your subsystem.

Ah, yes that makes sense. Thank you for the hint!

- Daniel

>
>
> Best regards,
> Krzysztof