[v1] usb: quirks: Add NO_LPM quirk for TOSHIBA TransMemory-Mx device

[PATCH] usb: quirks: Add NO_LPM quirk for TOSHIBA TransMemory-Mx device

Posted by limiao 11 months, 2 weeks ago

From: limiao <limiao@kylinos.cn>

TOSHIBA TransMemory-Mx is a good performence flash device, but it
doesn't work well with LPM on Huawei hisi platform, so let's disable
LPM to resolve the issue.

Signed-off-by: limiao <limiao@kylinos.cn>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 13171454f959..67732c791c93 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -394,6 +394,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Kingston DataTraveler 3.0 */
 	{ USB_DEVICE(0x0951, 0x1666), .driver_info = USB_QUIRK_NO_LPM },
 
+	/* TOSHIBA TransMemory-Mx */
+	{ USB_DEVICE(0x0930, 0x1408), .driver_info = USB_QUIRK_NO_LPM },
+
 	/* NVIDIA Jetson devices in Force Recovery mode */
 	{ USB_DEVICE(0x0955, 0x7018), .driver_info = USB_QUIRK_RESET_RESUME },
 	{ USB_DEVICE(0x0955, 0x7019), .driver_info = USB_QUIRK_RESET_RESUME },
-- 
2.25.1

Re: [PATCH] usb: quirks: Add NO_LPM quirk for TOSHIBA TransMemory-Mx device

Posted by Greg KH 11 months, 2 weeks ago

On Mon, Jan 13, 2025 at 03:51:18PM +0800, limiao wrote:
> From: limiao <limiao@kylinos.cn>
> 
> TOSHIBA TransMemory-Mx is a good performence flash device, but it
> doesn't work well with LPM on Huawei hisi platform, so let's disable
> LPM to resolve the issue.
> 
> Signed-off-by: limiao <limiao@kylinos.cn>

Can we get a "full name" here?  If you want to use your native
characters instead of ascii ones, that too will work quite well.

thanks,

greg k-h

[PATCH V2] usb: quirks: Add NO_LPM quirk for TOSHIBA TransMemory-Mx device

Posted by Miao Li 11 months, 2 weeks ago

From: Miao Li <limiao@kylinos.cn>

TOSHIBA TransMemory-Mx is a good performence flash device, but it
doesn't work well with LPM on Huawei hisi platform, so let's disable
LPM to resolve the issue.

Signed-off-by: Miao Li <limiao@kylinos.cn>
---
V1 -> V2: Modify the format of author's name to full name

 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 13171454f959..67732c791c93 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -394,6 +394,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Kingston DataTraveler 3.0 */
 	{ USB_DEVICE(0x0951, 0x1666), .driver_info = USB_QUIRK_NO_LPM },
 
+	/* TOSHIBA TransMemory-Mx */
+	{ USB_DEVICE(0x0930, 0x1408), .driver_info = USB_QUIRK_NO_LPM },
+
 	/* NVIDIA Jetson devices in Force Recovery mode */
 	{ USB_DEVICE(0x0955, 0x7018), .driver_info = USB_QUIRK_RESET_RESUME },
 	{ USB_DEVICE(0x0955, 0x7019), .driver_info = USB_QUIRK_RESET_RESUME },
-- 
2.25.1