[PATCH V2 1/2] dt-bindings: serial: Add a new compatible string for UMS9632

Wenhua Lin posted 2 patches 11 months, 2 weeks ago
[PATCH V2 1/2] dt-bindings: serial: Add a new compatible string for UMS9632
Posted by Wenhua Lin 11 months, 2 weeks ago
The UMS9632 uses the SC9632 serial device.

Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
---
 Documentation/devicetree/bindings/serial/sprd-uart.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
index f4dbb6dc2b6e..83582aa6c750 100644
--- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
@@ -23,6 +23,11 @@ properties:
               - sprd,ums9620-uart
           - const: sprd,sc9836-uart
       - const: sprd,sc9836-uart
+      - items:
+          - enum:
+              - sprd,ums9632-uart
+          - const: sprd,sc9632-uart
+      - const: sprd,sc9632-uart
 
   reg:
     maxItems: 1
-- 
2.34.1
Re: [PATCH V2 1/2] dt-bindings: serial: Add a new compatible string for UMS9632
Posted by Krzysztof Kozlowski 11 months, 2 weeks ago
On 13/01/2025 04:19, Wenhua Lin wrote:
> The UMS9632 uses the SC9632 serial device.

Why are you sending accepted patches?

> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> index f4dbb6dc2b6e..83582aa6c750 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> @@ -23,6 +23,11 @@ properties:
>                - sprd,ums9620-uart
>            - const: sprd,sc9836-uart
>        - const: sprd,sc9836-uart
> +      - items:
> +          - enum:
> +              - sprd,ums9632-uart
> +          - const: sprd,sc9632-uart
> +      - const: sprd,sc9632-uart

NAK, you are duplicating entries.

Best regards,
Krzysztof