[PATCH v5 0/5] perf test: Add a runs-per-test option

Ian Rogers posted 5 patches 11 months, 1 week ago
tools/perf/Documentation/perf-test.txt |  20 ++-
tools/perf/tests/builtin-test.c        | 223 ++++++++++++-------------
2 files changed, 119 insertions(+), 124 deletions(-)
[PATCH v5 0/5] perf test: Add a runs-per-test option
Posted by Ian Rogers 11 months, 1 week ago
Add a runs-per-test option to perf test inorder to better diagnose
flakes. Each runs executes as if it were a different test, the tests
appear together in the output:

```
$ perf test -r 3 lbr -v
122: perf record LBR tests                                           : Ok
122: perf record LBR tests                                           : Ok
122: perf record LBR tests                                           : Ok
```

v5: Fix the patch that updates the documentation for the sequential
    option, as spotted by Namhyung.
v4: Fix crash in dont_fork mode caused by cleanup work.
v3: Improve perf test documentation, including for the new option, and
    add some example output to the commit messages as requested by
    Namhyung.
v2: In the v1 patch Kan and I noted cleanup that would make the code
    cleaner and less indented:
    https://lore.kernel.org/lkml/20241109160219.49976-1-irogers@google.com/
    Add patches doing some builtin-test.c cleanup and then add the
    runs-per-test flag.

Ian Rogers (5):
  perf test: Rename functions and variables for better clarity
  perf test: Send list output to stdout rather than stderr
  perf test: Fix parallel/sequential option documentation
  perf test: Add a runs-per-test flag
  perf test: Improve verbose documentation

 tools/perf/Documentation/perf-test.txt |  20 ++-
 tools/perf/tests/builtin-test.c        | 223 ++++++++++++-------------
 2 files changed, 119 insertions(+), 124 deletions(-)

-- 
2.47.1.613.gc27f4b7a9f-goog
Re: [PATCH v5 0/5] perf test: Add a runs-per-test option
Posted by Namhyung Kim 11 months ago
On Thu, 09 Jan 2025 20:57:31 -0800, Ian Rogers wrote:

> Add a runs-per-test option to perf test inorder to better diagnose
> flakes. Each runs executes as if it were a different test, the tests
> appear together in the output:
> 
> ```
> $ perf test -r 3 lbr -v
> 122: perf record LBR tests                                           : Ok
> 122: perf record LBR tests                                           : Ok
> 122: perf record LBR tests                                           : Ok
> ```
> 
> [...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung
Re: [PATCH v5 0/5] perf test: Add a runs-per-test option
Posted by Namhyung Kim 11 months, 1 week ago
On Thu, Jan 09, 2025 at 08:57:31PM -0800, Ian Rogers wrote:
> Add a runs-per-test option to perf test inorder to better diagnose
> flakes. Each runs executes as if it were a different test, the tests
> appear together in the output:
> 
> ```
> $ perf test -r 3 lbr -v
> 122: perf record LBR tests                                           : Ok
> 122: perf record LBR tests                                           : Ok
> 122: perf record LBR tests                                           : Ok
> ```
> 
> v5: Fix the patch that updates the documentation for the sequential
>     option, as spotted by Namhyung.
> v4: Fix crash in dont_fork mode caused by cleanup work.
> v3: Improve perf test documentation, including for the new option, and
>     add some example output to the commit messages as requested by
>     Namhyung.
> v2: In the v1 patch Kan and I noted cleanup that would make the code
>     cleaner and less indented:
>     https://lore.kernel.org/lkml/20241109160219.49976-1-irogers@google.com/
>     Add patches doing some builtin-test.c cleanup and then add the
>     runs-per-test flag.
> 
> Ian Rogers (5):
>   perf test: Rename functions and variables for better clarity
>   perf test: Send list output to stdout rather than stderr
>   perf test: Fix parallel/sequential option documentation
>   perf test: Add a runs-per-test flag
>   perf test: Improve verbose documentation

Reviewed-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> 
>  tools/perf/Documentation/perf-test.txt |  20 ++-
>  tools/perf/tests/builtin-test.c        | 223 ++++++++++++-------------
>  2 files changed, 119 insertions(+), 124 deletions(-)
> 
> -- 
> 2.47.1.613.gc27f4b7a9f-goog
>