[RESEND,V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

kyrie.wu posted 1 patch 11 months, 1 week ago
...5-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
rename Documentation/devicetree/bindings/media/{mediatek,mt8195-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} (95%)
[RESEND,V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by kyrie.wu 11 months, 1 week ago
Add mediatek,mt8196-jpgdec compatible to binding document.

Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
---
 ...5-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
 rename Documentation/devicetree/bindings/media/{mediatek,mt8195-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} (95%)

diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml b/Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml
similarity index 95%
rename from Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
rename to Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml
index e5448c60e3eb..5ec98ddad506 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/media/mediatek,mt8195-jpegdec.yaml#
+$id: http://devicetree.org/schemas/media/mediatek,multi-core-jpegdec.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: MediaTek JPEG Decoder
@@ -14,7 +14,9 @@ description:
 
 properties:
   compatible:
-    const: mediatek,mt8195-jpgdec
+    enum:
+      - mediatek,mt8195-jpgdec
+      - mediatek,mt8196-jpgdec
 
   power-domains:
     maxItems: 1
@@ -44,7 +46,9 @@ patternProperties:
 
     properties:
       compatible:
-        const: mediatek,mt8195-jpgdec-hw
+        enum:
+          - mediatek,mt8195-jpgdec-hw
+          - mediatek,mt8196-jpgdec-hw
 
       reg:
         maxItems: 1
-- 
2.46.0
Re: [RESEND,V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by Krzysztof Kozlowski 11 months, 1 week ago
On 10/01/2025 02:27, kyrie.wu wrote:
> Add mediatek,mt8196-jpgdec compatible to binding document.
> 
> Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
> ---
No, why are you resending without improving anything here?

You got comments. Respond to them, implement them, not resend same stuff.

NAK

Best regards,
Krzysztof
Re: [RESEND,V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by Kyrie Wu (吴晗) 8 months, 2 weeks ago
On Fri, 2025-01-10 at 08:40 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 10/01/2025 02:27, kyrie.wu wrote:
> > Add mediatek,mt8196-jpgdec compatible to binding document.
> > 
> > Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
> > ---
> 
> No, why are you resending without improving anything here?
> 
> You got comments. Respond to them, implement them, not resend same
> stuff.
> 
> NAK
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

Thanks for your kind reminder. I made a mistake in the V1, so I
resended it. I will correct all the comments in the V2.

Thank you!

Regards,
Kyrie.
Re: [RESEND,V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by Krzysztof Kozlowski 8 months, 2 weeks ago
On 07/04/2025 08:24, Kyrie Wu (吴晗) wrote:
> On Fri, 2025-01-10 at 08:40 +0100, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 10/01/2025 02:27, kyrie.wu wrote:
>>> Add mediatek,mt8196-jpgdec compatible to binding document.
>>>
>>> Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
>>> ---
>>
>> No, why are you resending without improving anything here?
>>
>> You got comments. Respond to them, implement them, not resend same
>> stuff.
>>
>> NAK
>>
>> Best regards,
>> Krzysztof
> 
> Dear Krzysztof,
> 
> Thanks for your kind reminder. I made a mistake in the V1, so I
> resended it. I will correct all the comments in the V2.

You got review within 30 minutes on v1. You did not respond and the
*next* day (or after some hours) you resent it ignoring that review, so
you totally ignored it.

All this was 3 months ago.

Best regards,
Krzysztof