[PATCH] staging: gpib: Remove commented-out debug code (v4)

Sandeep Salwan posted 1 patch 11 months, 1 week ago
drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
[PATCH] staging: gpib: Remove commented-out debug code (v4)
Posted by Sandeep Salwan 11 months, 1 week ago
Code cleanup. This code has some debug code which is commented out.
Delete it.

Signed-off-by: Sandeep Salwan <salwansandeep5@gmail.com>
---
v4: fix title description
v3: remove leftover braces, re-write commit message
v2: removed commented-out code only
---
 drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
index 53006d0cc79c..fd05f15a683e 100644
--- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
+++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
@@ -30,11 +30,8 @@ int agilent_82350b_accel_read(gpib_board_t *board, uint8_t *buffer, size_t lengt
 	unsigned short event_status;
 	int i, num_fifo_bytes;
 	//hardware doesn't support checking for end-of-string character when using fifo
-	if (tms_priv->eos_flags & REOS) {
-		//pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
-		// tms_priv->eos);
+	if (tms_priv->eos_flags & REOS)
 		return tms9914_read(board, tms_priv, buffer, length, end, bytes_read);
-	}
 
 	clear_bit(DEV_CLEAR_BN, &tms_priv->state);
 
-- 
2.47.1
Re: [PATCH] staging: gpib: Remove commented-out debug code (v4)
Posted by Dan Carpenter 11 months, 1 week ago
On Thu, Jan 09, 2025 at 06:15:09PM -0500, Sandeep Salwan wrote:
> Code cleanup. This code has some debug code which is commented out.
> Delete it.
> 
> Signed-off-by: Sandeep Salwan <salwansandeep5@gmail.com>
> ---
> v4: fix title description

Close.  The v4 in the subject has to go inside the square brackets.
That way it won't be included in the permanent git log.

[PATCH v4] staging: gpib: Remove commented-out debug code

Please send a v5.

regards,
dan carpenter