[PATCH 00/16] selftest/mm: Remove warnings found by adding compiler flags

Muhammad Usama Anjum posted 16 patches 11 months, 1 week ago
tools/testing/selftests/kselftest_harness.h   |  6 +-
tools/testing/selftests/mm/Makefile           |  1 +
tools/testing/selftests/mm/compaction_test.c  |  4 +-
tools/testing/selftests/mm/cow.c              | 48 ++++++++-------
tools/testing/selftests/mm/droppable.c        |  2 +-
tools/testing/selftests/mm/guard-pages.c      |  4 +-
tools/testing/selftests/mm/gup_longterm.c     |  5 +-
tools/testing/selftests/mm/hmm-tests.c        |  4 +-
tools/testing/selftests/mm/hugepage-vmemmap.c |  5 +-
tools/testing/selftests/mm/hugetlb-madvise.c  |  4 +-
.../selftests/mm/hugetlb-read-hwpoison.c      |  6 +-
.../selftests/mm/hugetlb-soft-offline.c       |  2 +-
tools/testing/selftests/mm/hugetlb_dio.c      |  2 +-
.../selftests/mm/hugetlb_fault_after_madv.c   |  6 +-
.../selftests/mm/hugetlb_madv_vs_map.c        |  8 +--
tools/testing/selftests/mm/khugepaged.c       | 16 ++---
.../selftests/mm/ksm_functional_tests.c       |  6 +-
tools/testing/selftests/mm/ksm_tests.c        | 17 +++---
tools/testing/selftests/mm/madv_populate.c    |  2 +-
tools/testing/selftests/mm/map_populate.c     |  2 +-
tools/testing/selftests/mm/memfd_secret.c     |  6 +-
.../testing/selftests/mm/mlock-random-test.c  |  6 +-
tools/testing/selftests/mm/mlock2-tests.c     |  2 +-
tools/testing/selftests/mm/on-fault-limit.c   |  2 +-
tools/testing/selftests/mm/pkey-x86.h         |  4 +-
.../selftests/mm/pkey_sighandler_tests.c      | 21 ++++---
tools/testing/selftests/mm/protection_keys.c  | 34 ++++++-----
tools/testing/selftests/mm/soft-dirty.c       |  8 +--
.../selftests/mm/split_huge_page_test.c       |  4 +-
tools/testing/selftests/mm/thuge-gen.c        | 10 ++--
tools/testing/selftests/mm/uffd-common.c      | 24 ++++----
tools/testing/selftests/mm/uffd-common.h      |  2 +-
tools/testing/selftests/mm/uffd-stress.c      |  4 +-
tools/testing/selftests/mm/uffd-unit-tests.c  | 58 +++++++++----------
tools/testing/selftests/mm/uffd-wp-mremap.c   |  2 +-
.../selftests/mm/virtual_address_range.c      |  2 +-
36 files changed, 180 insertions(+), 159 deletions(-)
[PATCH 00/16] selftest/mm: Remove warnings found by adding compiler flags
Posted by Muhammad Usama Anjum 11 months, 1 week ago
Recently, I reviewed a patch on the mm/kselftest mailing list about a
test which had obvious type mismatch fix in it. It was strange why that
wasn't caught during development and when patch was accepted. This led
me to discover that those extra compiler options to catch these warnings
aren't being used. When I added them, I found tens of warnings in just
mm suite.

In this series, I'm fixing those warnings. The last check adds the
compiler flags with which the warnings have been caught.

Muhammad Usama Anjum (16):
  selftests/mm: remove argc and argv unused parameters
  selftests/mm: Fix unused parameter warnings
  selftests/mm: Fix unused parameter warnings
  selftests/mm: Fix type mismatch warnings
  selftests/mm: kselftest_harness: Fix warnings
  selftests/mm: cow: remove unused variables and fix type mismatch
    errors
  selftests/mm: hmm-tests: Remove always false expressions
  selftests/mm: guard-pages: Fix type mismatch warnings
  selftests/mm: hugetlb-madvise: fix type mismatch issues
  selftests/mm: hugepage-vmemmap: fix type mismatch warnings
  selftests/mm: hugetlb-read-hwpoison: Fix type mismatch warnings
  selftests/mm: khugepaged: Fix type mismatch warnings
  selftests/mm: protection_keys: Fix variables types mismatch warnings
  selftests/mm: thuge-gen: Fix type mismatch warnings
  selftests/mm: uffd-*: Fix all type mismatch warnings
  selftests/mm: Makefile: Add the compiler flags

 tools/testing/selftests/kselftest_harness.h   |  6 +-
 tools/testing/selftests/mm/Makefile           |  1 +
 tools/testing/selftests/mm/compaction_test.c  |  4 +-
 tools/testing/selftests/mm/cow.c              | 48 ++++++++-------
 tools/testing/selftests/mm/droppable.c        |  2 +-
 tools/testing/selftests/mm/guard-pages.c      |  4 +-
 tools/testing/selftests/mm/gup_longterm.c     |  5 +-
 tools/testing/selftests/mm/hmm-tests.c        |  4 +-
 tools/testing/selftests/mm/hugepage-vmemmap.c |  5 +-
 tools/testing/selftests/mm/hugetlb-madvise.c  |  4 +-
 .../selftests/mm/hugetlb-read-hwpoison.c      |  6 +-
 .../selftests/mm/hugetlb-soft-offline.c       |  2 +-
 tools/testing/selftests/mm/hugetlb_dio.c      |  2 +-
 .../selftests/mm/hugetlb_fault_after_madv.c   |  6 +-
 .../selftests/mm/hugetlb_madv_vs_map.c        |  8 +--
 tools/testing/selftests/mm/khugepaged.c       | 16 ++---
 .../selftests/mm/ksm_functional_tests.c       |  6 +-
 tools/testing/selftests/mm/ksm_tests.c        | 17 +++---
 tools/testing/selftests/mm/madv_populate.c    |  2 +-
 tools/testing/selftests/mm/map_populate.c     |  2 +-
 tools/testing/selftests/mm/memfd_secret.c     |  6 +-
 .../testing/selftests/mm/mlock-random-test.c  |  6 +-
 tools/testing/selftests/mm/mlock2-tests.c     |  2 +-
 tools/testing/selftests/mm/on-fault-limit.c   |  2 +-
 tools/testing/selftests/mm/pkey-x86.h         |  4 +-
 .../selftests/mm/pkey_sighandler_tests.c      | 21 ++++---
 tools/testing/selftests/mm/protection_keys.c  | 34 ++++++-----
 tools/testing/selftests/mm/soft-dirty.c       |  8 +--
 .../selftests/mm/split_huge_page_test.c       |  4 +-
 tools/testing/selftests/mm/thuge-gen.c        | 10 ++--
 tools/testing/selftests/mm/uffd-common.c      | 24 ++++----
 tools/testing/selftests/mm/uffd-common.h      |  2 +-
 tools/testing/selftests/mm/uffd-stress.c      |  4 +-
 tools/testing/selftests/mm/uffd-unit-tests.c  | 58 +++++++++----------
 tools/testing/selftests/mm/uffd-wp-mremap.c   |  2 +-
 .../selftests/mm/virtual_address_range.c      |  2 +-
 36 files changed, 180 insertions(+), 159 deletions(-)

-- 
2.39.5
Re: [PATCH 00/16] selftest/mm: Remove warnings found by adding compiler flags
Posted by Andrew Morton 11 months ago
On Thu,  9 Jan 2025 22:38:26 +0500 Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:

> Recently, I reviewed a patch on the mm/kselftest mailing list about a
> test which had obvious type mismatch fix in it. It was strange why that
> wasn't caught during development and when patch was accepted. This led
> me to discover that those extra compiler options to catch these warnings
> aren't being used. When I added them, I found tens of warnings in just
> mm suite.
> 
> In this series, I'm fixing those warnings. The last check adds the
> compiler flags with which the warnings have been caught.

I'm seeing a couple of unresolved issues against this series so I'll drop
v1.  Please let's revisit after -rc1.

https://lkml.kernel.org/r/20250110190057.2294fd5a@pumpkin
https://lkml.kernel.org/r/d9c290e2-f22d-41be-aa68-2aebd3eb1a67@sirena.org.uk