1. Patchew
  2. linux
  3. View series

[V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

kyrie.wu posted 1 patch 11 months, 2 weeks ago
There is a newer version of this series
...5-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
rename Documentation/devicetree/bindings/media/{mediatek,mt8195-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} (95%)
[V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by kyrie.wu 11 months, 2 weeks ago 
Add mediatek,mt8196-jpgdec compatible to binding document.

Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
---
 ...5-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
 rename Documentation/devicetree/bindings/media/{mediatek,mt8195-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} (95%)

diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml b/Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml
similarity index 95%
rename from Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
rename to Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml
index e5448c60e3eb..5ec98ddad506 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/media/mediatek,mt8195-jpegdec.yaml#
+$id: http://devicetree.org/schemas/media/mediatek,multi-core-jpegdec.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: MediaTek JPEG Decoder
@@ -14,7 +14,9 @@ description:
 
 properties:
   compatible:
-    const: mediatek,mt8195-jpgdec
+    enum:
+      - mediatek,mt8195-jpgdec
+      - mediatek,mt8196-jpgdec
 
   power-domains:
     maxItems: 1
@@ -44,7 +46,9 @@ patternProperties:
 
     properties:
       compatible:
-        const: mediatek,mt8195-jpgdec-hw
+        enum:
+          - mediatek,mt8195-jpgdec-hw
+          - mediatek,mt8196-jpgdec-hw
 
       reg:
         maxItems: 1
-- 
2.46.0
Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by Krzysztof Kozlowski 11 months, 2 weeks ago 
On 09/01/2025 14:35, kyrie.wu wrote:
> Add mediatek,mt8196-jpgdec compatible to binding document.

Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch -vX` helps here to create proper versioned
patches. Another useful tool is b4. Skipping the PATCH keyword makes
filtering of emails more difficult thus making the review process less
convenient.

> 
> Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
> ---
>  ...5-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>  rename Documentation/devicetree/bindings/media/{mediatek,mt8195-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} (95%)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml b/Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml
> similarity index 95%
> rename from Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> rename to Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml


Don't rename the file.

> index e5448c60e3eb..5ec98ddad506 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,multi-core-jpegdec.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/media/mediatek,mt8195-jpegdec.yaml#
> +$id: http://devicetree.org/schemas/media/mediatek,multi-core-jpegdec.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
>  title: MediaTek JPEG Decoder
> @@ -14,7 +14,9 @@ description:
>  
>  properties:
>    compatible:
> -    const: mediatek,mt8195-jpgdec
> +    enum:
> +      - mediatek,mt8195-jpgdec
> +      - mediatek,mt8196-jpgdec

Devices look compatible, so express it with fallback.

Best regards,
Krzysztof
Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by Kyrie Wu (吴晗) 8 months, 2 weeks ago 
On Thu, 2025-01-09 at 14:54 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 09/01/2025 14:35, kyrie.wu wrote:
> > Add mediatek,mt8196-jpgdec compatible to binding document.
> 
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch -vX` helps here to create proper versioned
> patches. Another useful tool is b4. Skipping the PATCH keyword makes
> filtering of emails more difficult thus making the review process
> less
> convenient.
> 
> > 
> > Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
> > ---
> >  ...5-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} | 10
> > +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >  rename Documentation/devicetree/bindings/media/{mediatek,mt8195-
> > jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} (95%)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,multi-core-
> > jpegdec.yaml
> > similarity index 95%
> > rename from
> > Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > rename to Documentation/devicetree/bindings/media/mediatek,multi-
> > core-jpegdec.yaml
> 
> 
> Don't rename the file.
> 
> > index e5448c60e3eb..5ec98ddad506 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,multi-core-
> > jpegdec.yaml
> > @@ -1,7 +1,7 @@
> >  # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >  %YAML 1.2
> >  ---
> > -$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek,mt8195-jpegdec.yaml*__;Iw!!CTRNKA9wMg0ARbw!lg1d9e5vm7JQRbUIRKg64b44cKCTOgxo8qiwE2QuYSBLcMHUaaFKbikp6yOXI4lvceYOAwLELlqtbQ$
> > +$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek,multi-core-jpegdec.yaml*__;Iw!!CTRNKA9wMg0ARbw!lg1d9e5vm7JQRbUIRKg64b44cKCTOgxo8qiwE2QuYSBLcMHUaaFKbikp6yOXI4lvceYOAwJqmnSMWA$
> >  $schema: 
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lg1d9e5vm7JQRbUIRKg64b44cKCTOgxo8qiwE2QuYSBLcMHUaaFKbikp6yOXI4lvceYOAwIJtjn37Q$
> > 
> >  title: MediaTek JPEG Decoder
> > @@ -14,7 +14,9 @@ description:
> > 
> >  properties:
> >    compatible:
> > -    const: mediatek,mt8195-jpgdec
> > +    enum:
> > +      - mediatek,mt8195-jpgdec
> > +      - mediatek,mt8196-jpgdec
> 
> Devices look compatible, so express it with fallback.
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

The MT8195 and MT8196 are both multi-hardware chips, I renamed the file
to treat it as a common file, if I don't do that it will need to
recreate a file with similar contents. Is this acceptable?
If the above description is acceptable, I will apply your request in
the next version.

Thanks.

Best regards,
Kyrie
Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by Krzysztof Kozlowski 8 months, 2 weeks ago 
On 07/04/2025 09:13, Kyrie Wu (吴晗) wrote:
> On Thu, 2025-01-09 at 14:54 +0100, Krzysztof Kozlowski wrote:

...


>>>
>>>  properties:
>>>    compatible:
>>> -    const: mediatek,mt8195-jpgdec
>>> +    enum:
>>> +      - mediatek,mt8195-jpgdec
>>> +      - mediatek,mt8196-jpgdec
>>
>> Devices look compatible, so express it with fallback.
>>
>> Best regards,
>> Krzysztof
> 
> Dear Krzysztof,
> 
> The MT8195 and MT8196 are both multi-hardware chips, I renamed the file
> to treat it as a common file, if I don't do that it will need to
> recreate a file with similar contents. Is this acceptable?

No, do not create own rules. I do not see how this is related to my
comment at all.

You responded three months after my review, so entire context including
actual mails in my inbox are gone.

If you disagree with feedback, respond in timely manner. I feel
discussing something after three months like wasting my time.


> If the above description is acceptable, I will apply your request in
> the next version.

Best regards,
Krzysztof
Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Posted by Kyrie Wu (吴晗) 8 months, 2 weeks ago 
On Mon, 2025-04-07 at 09:19 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 07/04/2025 09:13, Kyrie Wu (吴晗) wrote:
> > On Thu, 2025-01-09 at 14:54 +0100, Krzysztof Kozlowski wrote:
> 
> ...
> 
> 
> > > > 
> > > >  properties:
> > > >    compatible:
> > > > -    const: mediatek,mt8195-jpgdec
> > > > +    enum:
> > > > +      - mediatek,mt8195-jpgdec
> > > > +      - mediatek,mt8196-jpgdec
> > > 
> > > Devices look compatible, so express it with fallback.
> > > 
> > > Best regards,
> > > Krzysztof
> > 
> > Dear Krzysztof,
> > 
> > The MT8195 and MT8196 are both multi-hardware chips, I renamed the
> > file
> > to treat it as a common file, if I don't do that it will need to
> > recreate a file with similar contents. Is this acceptable?
> 
> No, do not create own rules. I do not see how this is related to my
> comment at all.
> 
> You responded three months after my review, so entire context
> including
> actual mails in my inbox are gone.
> 
> If you disagree with feedback, respond in timely manner. I feel
> discussing something after three months like wasting my time.
> 
> 
> > If the above description is acceptable, I will apply your request
> > in
> > the next version.
> 
> Best regards,
> Krzysztof

Dear Krzysztof,
 
I'm truly sorry for what I have done. I feel very ashamed and self-
blame after I tried to stand in your shoes. 
 
You contributed a lot of time to help me review my patch, you could
have spent it with your family or your friends, and I failed you in
your selfless kindness. I have not only wasted your precious time but
also disrespected your contribution by ignoring your reply,
undoubtedly.

This was never my intention, and I‘m committed to improving my
communication and collaboration within the community. I value your
expertise and feedback, and I will ensure that I respond promptly and
thoughtfully to any future reviews. (I have improved my email
notifications, and I will share this experience within my team to
remind all developers.)
 
Thank you for your understanding and patience. I hope to rebuild your
trust and continue contributing positively to the community.
 
Sincerely,
Kyrie

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.