Other x1e machines use _dtbs.elf for these firmwares, which matches the
filenames shipped by Windows.

Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
Tested on a Surface Laptop 13 where the firmware appears to load
correctly.

 arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
index f01eb5ab7dc6..85d28fb8d878 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
@@ -706,14 +706,14 @@ &qupv3_2 {
 
 &remoteproc_adsp {
 	firmware-name = "qcom/x1e80100/microsoft/Romulus/qcadsp8380.mbn",
-			"qcom/x1e80100/microsoft/Romulus/adsp_dtb.mbn";
+			"qcom/x1e80100/microsoft/Romulus/adsp_dtbs.elf";
 
 	status = "okay";
 };
 
 &remoteproc_cdsp {
 	firmware-name = "qcom/x1e80100/microsoft/Romulus/qccdsp8380.mbn",
-			"qcom/x1e80100/microsoft/Romulus/cdsp_dtb.mbn";
+			"qcom/x1e80100/microsoft/Romulus/cdsp_dtbs.elf";
 
 	status = "okay";
 };
-- 
2.45.2

On Wed, 08 Jan 2025 23:14:59 +1030, Joel Stanley wrote:
> Other x1e machines use _dtbs.elf for these firmwares, which matches the
> filenames shipped by Windows.
> 
> 

Applied, thanks!

[1/1] arm64: qcom: romulus: Update firmware names
      commit: 983833061d9599a534e44fd6d335080d1a0ba985

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

On 8.01.2025 1:44 PM, Joel Stanley wrote:
> Other x1e machines use _dtbs.elf for these firmwares, which matches the
> filenames shipped by Windows.
> 
> Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---

Right, I renamed these locally.. but it's definitely better to keep
those as-shipped

The commit title should like:

arm64: dts: qcom: x1e80100-romulus: Update firmware nodes

(see git log --oneline path/to/dir for the general format)

but maybe Bjorn can fix that up when applying


Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Thanks!

Konrad