diffconfig: add verification mode

[PATCH 1/2] MAINTAINERS: Add kconfig utility scripts

Posted by Thomas Weißschuh 11 months, 2 weeks ago

There are various utilities in scripts/ which work with kconfig files.
These have currently no maintainer.
As most patches for them are applied through kconfig/kbuild anyways,
add an explicit maintainership entry.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 30cbc3d44cd53e6b1a81d56161004d7ab825d7a9..2bd414fb3e6d6515b57a57a5f3d4d735137edcce 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12385,6 +12385,9 @@ Q:	https://patchwork.kernel.org/project/linux-kbuild/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kbuild
 F:	Documentation/kbuild/kconfig*
 F:	scripts/Kconfig.include
+F:	scripts/checkkconfigsymbols.py
+F:	scripts/config
+F:	scripts/diffconfig
 F:	scripts/kconfig/
 
 KCOV

-- 
2.47.1

Re: [PATCH 1/2] MAINTAINERS: Add kconfig utility scripts

Posted by Masahiro Yamada 10 months, 1 week ago

On Wed, Jan 8, 2025 at 9:34 PM Thomas Weißschuh
<thomas.weissschuh@linutronix.de> wrote:
>
> There are various utilities in scripts/ which work with kconfig files.
> These have currently no maintainer.
> As most patches for them are applied through kconfig/kbuild anyways,
> add an explicit maintainership entry.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 30cbc3d44cd53e6b1a81d56161004d7ab825d7a9..2bd414fb3e6d6515b57a57a5f3d4d735137edcce 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12385,6 +12385,9 @@ Q:      https://patchwork.kernel.org/project/linux-kbuild/list/
>  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kbuild
>  F:     Documentation/kbuild/kconfig*
>  F:     scripts/Kconfig.include
> +F:     scripts/checkkconfigsymbols.py
> +F:     scripts/config
> +F:     scripts/diffconfig
>  F:     scripts/kconfig/


There are a number of random scripts I am unfamiliar with.

I have never used checkkconfigsymbols.py

I may happen to check patches for such tools very reluctantly
and very lazily, but it is daunting to endlessly extend
my obligations, especially to the point where I lost interest.




--
Best Regards
Masahiro Yamada

Re: [PATCH 1/2] MAINTAINERS: Add kconfig utility scripts

Posted by Thomas Weißschuh 10 months, 1 week ago

On Mon, Feb 10, 2025 at 02:23:41PM +0900, Masahiro Yamada wrote:
> On Wed, Jan 8, 2025 at 9:34 PM Thomas Weißschuh
> <thomas.weissschuh@linutronix.de> wrote:
> >
> > There are various utilities in scripts/ which work with kconfig files.
> > These have currently no maintainer.
> > As most patches for them are applied through kconfig/kbuild anyways,
> > add an explicit maintainership entry.
> >
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > ---
> >  MAINTAINERS | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 30cbc3d44cd53e6b1a81d56161004d7ab825d7a9..2bd414fb3e6d6515b57a57a5f3d4d735137edcce 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -12385,6 +12385,9 @@ Q:      https://patchwork.kernel.org/project/linux-kbuild/list/
> >  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kbuild
> >  F:     Documentation/kbuild/kconfig*
> >  F:     scripts/Kconfig.include
> > +F:     scripts/checkkconfigsymbols.py
> > +F:     scripts/config
> > +F:     scripts/diffconfig
> >  F:     scripts/kconfig/
> 
> 
> There are a number of random scripts I am unfamiliar with.
> 
> I have never used checkkconfigsymbols.py
> 
> I may happen to check patches for such tools very reluctantly
> and very lazily, but it is daunting to endlessly extend
> my obligations, especially to the point where I lost interest.

Understood.
My intention is not to extend your obligations beyond your interest.

However I am not entirely sure from your message if this holds for all
three of the added scripts or only checkkconfigsymbols.py.
Until further notice I'll assume it affects all of them and the whole
patch should be dropped.


Thomas

Re: [PATCH 1/2] MAINTAINERS: Add kconfig utility scripts

Posted by Nicolas Schier 11 months, 1 week ago

On Wed 08 Jan 2025 13:34:28 GMT, Thomas Weißschuh wrote:
> There are various utilities in scripts/ which work with kconfig 
> files.
> These have currently no maintainer.
> As most patches for them are applied through kconfig/kbuild anyways,
> add an explicit maintainership entry.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 30cbc3d44cd53e6b1a81d56161004d7ab825d7a9..2bd414fb3e6d6515b57a57a5f3d4d735137edcce 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12385,6 +12385,9 @@ Q:	https://patchwork.kernel.org/project/linux-kbuild/list/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kbuild
>  F:	Documentation/kbuild/kconfig*
>  F:	scripts/Kconfig.include
> +F:	scripts/checkkconfigsymbols.py
> +F:	scripts/config
> +F:	scripts/diffconfig

Thanks!

Does it make sense to add scripts/extract-ikconfig also?  It does not 
handle kconfig language at all, but linux-kbuild would probably still a 
good place for review.

Nevertheless,

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

Kind regards,
Nicolas

Re: [PATCH 1/2] MAINTAINERS: Add kconfig utility scripts

Posted by Thomas Weißschuh 11 months, 1 week ago

On Wed, Jan 15, 2025 at 01:11:06PM +0100, Nicolas Schier wrote:
> On Wed 08 Jan 2025 13:34:28 GMT, Thomas Weißschuh wrote:
> > There are various utilities in scripts/ which work with kconfig 
> > files.
> > These have currently no maintainer.
> > As most patches for them are applied through kconfig/kbuild anyways,
> > add an explicit maintainership entry.
> > 
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > ---
> >  MAINTAINERS | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 30cbc3d44cd53e6b1a81d56161004d7ab825d7a9..2bd414fb3e6d6515b57a57a5f3d4d735137edcce 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -12385,6 +12385,9 @@ Q:	https://patchwork.kernel.org/project/linux-kbuild/list/
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kbuild
> >  F:	Documentation/kbuild/kconfig*
> >  F:	scripts/Kconfig.include
> > +F:	scripts/checkkconfigsymbols.py
> > +F:	scripts/config
> > +F:	scripts/diffconfig
> 
> Thanks!
> 
> Does it make sense to add scripts/extract-ikconfig also?  It does not 
> handle kconfig language at all, but linux-kbuild would probably still a 
> good place for review.

scripts/extract-ikconfig should be maintained together with
kernel/configs.c. Today both are formally unmaintained.
linux-kbuild picking up both looks reasonable to me.

> Nevertheless,
> 
> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

Thanks!