drm/panthor: Remove dead code

[PATCH] drm/panthor: Remove dead code

Posted by Florent Tomasin 11 months, 2 weeks ago

Remove unused function declaration in panthor_gem.h:
- `panthor_gem_prime_import_sg_table()`

Remove duplicate macro definitions:
- `MAX_CSG_PRIO`
- `MIN_CS_PER_CSG`
- `MIN_CSGS`

Signed-off-by: Florent Tomasin <florent.tomasin@arm.com>
---
 drivers/gpu/drm/panthor/panthor_fw.c    | 1 -
 drivers/gpu/drm/panthor/panthor_gem.h   | 5 -----
 drivers/gpu/drm/panthor/panthor_sched.c | 3 ---
 3 files changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
index 68eb4fb4d3a8..4a9c4afa9ad7 100644
--- a/drivers/gpu/drm/panthor/panthor_fw.c
+++ b/drivers/gpu/drm/panthor/panthor_fw.c
@@ -201,7 +201,6 @@ struct panthor_fw_section {
 
 #define MIN_CS_PER_CSG				8
 #define MIN_CSGS				3
-#define MAX_CSG_PRIO				0xf
 
 #define CSF_IFACE_VERSION(major, minor, patch)	\
 	(((major) << 24) | ((minor) << 16) | (patch))
diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/panthor/panthor_gem.h
index e43021cf6d45..5749ef2ebe03 100644
--- a/drivers/gpu/drm/panthor/panthor_gem.h
+++ b/drivers/gpu/drm/panthor/panthor_gem.h
@@ -85,11 +85,6 @@ struct panthor_gem_object *to_panthor_bo(struct drm_gem_object *obj)
 
 struct drm_gem_object *panthor_gem_create_object(struct drm_device *ddev, size_t size);
 
-struct drm_gem_object *
-panthor_gem_prime_import_sg_table(struct drm_device *ddev,
-				  struct dma_buf_attachment *attach,
-				  struct sg_table *sgt);
-
 int
 panthor_gem_create_with_handle(struct drm_file *file,
 			       struct drm_device *ddev,
diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
index 77b184c3fb0c..5844a7f639e0 100644
--- a/drivers/gpu/drm/panthor/panthor_sched.c
+++ b/drivers/gpu/drm/panthor/panthor_sched.c
@@ -88,9 +88,6 @@
 
 #define JOB_TIMEOUT_MS				5000
 
-#define MIN_CS_PER_CSG				8
-
-#define MIN_CSGS				3
 #define MAX_CSG_PRIO				0xf
 
 #define NUM_INSTRS_PER_CACHE_LINE		(64 / sizeof(u64))
-- 
2.34.1

Re: [PATCH] drm/panthor: Remove dead code

Posted by Steven Price 11 months, 2 weeks ago

On 07/01/2025 17:33, Florent Tomasin wrote:
> Remove unused function declaration in panthor_gem.h:
> - `panthor_gem_prime_import_sg_table()`
> 
> Remove duplicate macro definitions:
> - `MAX_CSG_PRIO`
> - `MIN_CS_PER_CSG`
> - `MIN_CSGS`
> 
> Signed-off-by: Florent Tomasin <florent.tomasin@arm.com>

Reviewed-by: Steven Price <steven.price@arm.com>

> ---
>  drivers/gpu/drm/panthor/panthor_fw.c    | 1 -
>  drivers/gpu/drm/panthor/panthor_gem.h   | 5 -----
>  drivers/gpu/drm/panthor/panthor_sched.c | 3 ---
>  3 files changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index 68eb4fb4d3a8..4a9c4afa9ad7 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -201,7 +201,6 @@ struct panthor_fw_section {
>  
>  #define MIN_CS_PER_CSG				8
>  #define MIN_CSGS				3
> -#define MAX_CSG_PRIO				0xf
>  
>  #define CSF_IFACE_VERSION(major, minor, patch)	\
>  	(((major) << 24) | ((minor) << 16) | (patch))
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/panthor/panthor_gem.h
> index e43021cf6d45..5749ef2ebe03 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.h
> +++ b/drivers/gpu/drm/panthor/panthor_gem.h
> @@ -85,11 +85,6 @@ struct panthor_gem_object *to_panthor_bo(struct drm_gem_object *obj)
>  
>  struct drm_gem_object *panthor_gem_create_object(struct drm_device *ddev, size_t size);
>  
> -struct drm_gem_object *
> -panthor_gem_prime_import_sg_table(struct drm_device *ddev,
> -				  struct dma_buf_attachment *attach,
> -				  struct sg_table *sgt);
> -
>  int
>  panthor_gem_create_with_handle(struct drm_file *file,
>  			       struct drm_device *ddev,
> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> index 77b184c3fb0c..5844a7f639e0 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -88,9 +88,6 @@
>  
>  #define JOB_TIMEOUT_MS				5000
>  
> -#define MIN_CS_PER_CSG				8
> -
> -#define MIN_CSGS				3
>  #define MAX_CSG_PRIO				0xf
>  
>  #define NUM_INSTRS_PER_CACHE_LINE		(64 / sizeof(u64))

Re: [PATCH] drm/panthor: Remove dead code

Posted by Boris Brezillon 11 months, 2 weeks ago

On Tue, 7 Jan 2025 17:33:09 +0000
Florent Tomasin <florent.tomasin@arm.com> wrote:

> Remove unused function declaration in panthor_gem.h:
> - `panthor_gem_prime_import_sg_table()`
> 
> Remove duplicate macro definitions:
> - `MAX_CSG_PRIO`
> - `MIN_CS_PER_CSG`
> - `MIN_CSGS`
> 
> Signed-off-by: Florent Tomasin <florent.tomasin@arm.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/panthor/panthor_fw.c    | 1 -
>  drivers/gpu/drm/panthor/panthor_gem.h   | 5 -----
>  drivers/gpu/drm/panthor/panthor_sched.c | 3 ---
>  3 files changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index 68eb4fb4d3a8..4a9c4afa9ad7 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -201,7 +201,6 @@ struct panthor_fw_section {
>  
>  #define MIN_CS_PER_CSG				8
>  #define MIN_CSGS				3
> -#define MAX_CSG_PRIO				0xf
>  
>  #define CSF_IFACE_VERSION(major, minor, patch)	\
>  	(((major) << 24) | ((minor) << 16) | (patch))
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/panthor/panthor_gem.h
> index e43021cf6d45..5749ef2ebe03 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.h
> +++ b/drivers/gpu/drm/panthor/panthor_gem.h
> @@ -85,11 +85,6 @@ struct panthor_gem_object *to_panthor_bo(struct drm_gem_object *obj)
>  
>  struct drm_gem_object *panthor_gem_create_object(struct drm_device *ddev, size_t size);
>  
> -struct drm_gem_object *
> -panthor_gem_prime_import_sg_table(struct drm_device *ddev,
> -				  struct dma_buf_attachment *attach,
> -				  struct sg_table *sgt);
> -
>  int
>  panthor_gem_create_with_handle(struct drm_file *file,
>  			       struct drm_device *ddev,
> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> index 77b184c3fb0c..5844a7f639e0 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -88,9 +88,6 @@
>  
>  #define JOB_TIMEOUT_MS				5000
>  
> -#define MIN_CS_PER_CSG				8
> -
> -#define MIN_CSGS				3
>  #define MAX_CSG_PRIO				0xf
>  
>  #define NUM_INSTRS_PER_CACHE_LINE		(64 / sizeof(u64))