[PATCH] perf test: Mark remaining probe tests as exclusive

James Clark posted 1 patch 11 months, 2 weeks ago
tools/perf/tests/shell/perftool-testsuite_probe.sh    | 2 +-
tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH] perf test: Mark remaining probe tests as exclusive
Posted by James Clark 11 months, 2 weeks ago
Probes are global and other probe tests are already exclusive. These
two tests can throw warnings when run at the same time so mark them as
exclusive too:

  $ perf test -vvv 81 79

  79: perftool-testsuite_probe:
  --- start ---
  test child forked, pid 46419
  ../common/init.sh: line 137: /sys/kernel/debug/tracing/uprobe_events: Device or resource busy

Signed-off-by: James Clark <james.clark@linaro.org>
---
 tools/perf/tests/shell/perftool-testsuite_probe.sh    | 2 +-
 tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/shell/perftool-testsuite_probe.sh b/tools/perf/tests/shell/perftool-testsuite_probe.sh
index a0fec33a0358..7b1bfd0f888f 100755
--- a/tools/perf/tests/shell/perftool-testsuite_probe.sh
+++ b/tools/perf/tests/shell/perftool-testsuite_probe.sh
@@ -1,5 +1,5 @@
 #!/bin/bash
-# perftool-testsuite_probe
+# perftool-testsuite_probe (exclusive)
 # SPDX-License-Identifier: GPL-2.0
 
 test -d "$(dirname "$0")/base_probe" || exit 2
diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
index 47a26f25db9f..cffdd5fc8b95 100755
--- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
+++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
@@ -1,5 +1,5 @@
 #!/bin/sh
-# probe libc's inet_pton & backtrace it with ping
+# probe libc's inet_pton & backtrace it with ping (exclusive)
 
 # Installs a probe on libc's inet_pton function, that will use uprobes,
 # then use 'perf trace' on a ping to localhost asking for just one packet
-- 
2.34.1
Re: [PATCH] perf test: Mark remaining probe tests as exclusive
Posted by Ian Rogers 11 months, 2 weeks ago
On Tue, Jan 7, 2025 at 9:00 AM James Clark <james.clark@linaro.org> wrote:
>
> Probes are global and other probe tests are already exclusive. These
> two tests can throw warnings when run at the same time so mark them as
> exclusive too:
>
>   $ perf test -vvv 81 79
>
>   79: perftool-testsuite_probe:
>   --- start ---
>   test child forked, pid 46419
>   ../common/init.sh: line 137: /sys/kernel/debug/tracing/uprobe_events: Device or resource busy
>
> Signed-off-by: James Clark <james.clark@linaro.org>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian