[PATCH v2 0/6] Expand SoundWire MBQ register map support

Charles Keepax posted 6 patches 11 months, 2 weeks ago
drivers/base/regmap/regmap-sdw-mbq.c    | 219 +++++++++++++++++++++---
include/linux/regmap.h                  |  62 ++++++-
include/linux/soundwire/sdw_registers.h |  30 +++-
include/sound/sdca_function.h           |  33 +++-
sound/soc/codecs/rt722-sdca-sdw.c       | 128 ++++++++------
sound/soc/codecs/rt722-sdca-sdw.h       |  99 ++++++-----
sound/soc/codecs/rt722-sdca.c           | 135 ++++-----------
sound/soc/codecs/rt722-sdca.h           |   4 +-
8 files changed, 454 insertions(+), 256 deletions(-)
[PATCH v2 0/6] Expand SoundWire MBQ register map support
Posted by Charles Keepax 11 months, 2 weeks ago
The current SDCA MBQ (Multi-Byte Quantities) register map only
supports 16-bit types, add support for more sizes and then update
the rt722 driver to use the new support. We also add support for
the deferring feature of MBQs to allow hardware to indicate it is
not currently ready to service a read/write.

Afraid I don't have hardware to test the rt722 change so it is
only build tested, but I thought it good to include a change to
demonstrate the new features in use.

Changes since v1:
 - Fixed a potentially uninitialised variable.
 - Added some extra rt722 registers, Shuming Fan asked for.

Thanks,
Charles

Charles Keepax (6):
  soundwire: SDCA: Add additional SDCA address macros
  ASoC: SDCA: Update list of entity_0 controls
  regmap: sdw-mbq: Add support for further MBQ register sizes
  regmap: sdw-mbq: Add support for SDCA deferred controls
  ASoC: rt722-sdca: Add some missing readable registers
  ASoC: rt722-sdca: Make use of new expanded MBQ regmap

 drivers/base/regmap/regmap-sdw-mbq.c    | 219 +++++++++++++++++++++---
 include/linux/regmap.h                  |  62 ++++++-
 include/linux/soundwire/sdw_registers.h |  30 +++-
 include/sound/sdca_function.h           |  33 +++-
 sound/soc/codecs/rt722-sdca-sdw.c       | 128 ++++++++------
 sound/soc/codecs/rt722-sdca-sdw.h       |  99 ++++++-----
 sound/soc/codecs/rt722-sdca.c           | 135 ++++-----------
 sound/soc/codecs/rt722-sdca.h           |   4 +-
 8 files changed, 454 insertions(+), 256 deletions(-)

-- 
2.39.5
Re: [PATCH v2 0/6] Expand SoundWire MBQ register map support
Posted by Pierre-Louis Bossart 11 months, 2 weeks ago
On 1/7/25 9:44 AM, Charles Keepax wrote:
> The current SDCA MBQ (Multi-Byte Quantities) register map only
> supports 16-bit types, add support for more sizes and then update
> the rt722 driver to use the new support. We also add support for
> the deferring feature of MBQs to allow hardware to indicate it is
> not currently ready to service a read/write.
> 
> Afraid I don't have hardware to test the rt722 change so it is
> only build tested, but I thought it good to include a change to
> demonstrate the new features in use.
> 
> Changes since v1:
>  - Fixed a potentially uninitialised variable.
>  - Added some extra rt722 registers, Shuming Fan asked for.

For the series:

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

> Thanks,
> Charles
> 
> Charles Keepax (6):
>   soundwire: SDCA: Add additional SDCA address macros
>   ASoC: SDCA: Update list of entity_0 controls
>   regmap: sdw-mbq: Add support for further MBQ register sizes
>   regmap: sdw-mbq: Add support for SDCA deferred controls
>   ASoC: rt722-sdca: Add some missing readable registers
>   ASoC: rt722-sdca: Make use of new expanded MBQ regmap
> 
>  drivers/base/regmap/regmap-sdw-mbq.c    | 219 +++++++++++++++++++++---
>  include/linux/regmap.h                  |  62 ++++++-
>  include/linux/soundwire/sdw_registers.h |  30 +++-
>  include/sound/sdca_function.h           |  33 +++-
>  sound/soc/codecs/rt722-sdca-sdw.c       | 128 ++++++++------
>  sound/soc/codecs/rt722-sdca-sdw.h       |  99 ++++++-----
>  sound/soc/codecs/rt722-sdca.c           | 135 ++++-----------
>  sound/soc/codecs/rt722-sdca.h           |   4 +-
>  8 files changed, 454 insertions(+), 256 deletions(-)
>
Re: (subset) [PATCH v2 0/6] Expand SoundWire MBQ register map support
Posted by Mark Brown 11 months, 1 week ago
On Tue, 07 Jan 2025 15:44:02 +0000, Charles Keepax wrote:
> The current SDCA MBQ (Multi-Byte Quantities) register map only
> supports 16-bit types, add support for more sizes and then update
> the rt722 driver to use the new support. We also add support for
> the deferring feature of MBQs to allow hardware to indicate it is
> not currently ready to service a read/write.
> 
> Afraid I don't have hardware to test the rt722 change so it is
> only build tested, but I thought it good to include a change to
> demonstrate the new features in use.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/6] soundwire: SDCA: Add additional SDCA address macros
      commit: 7b16e60b31202254c62a29f5c709ffb42684b6f9
[2/6] ASoC: SDCA: Update list of entity_0 controls
      commit: b21468e83b787ab31aa9df8f429d2ca61def0cc9
[3/6] regmap: sdw-mbq: Add support for further MBQ register sizes
      commit: fdd9ef3dce98e035d21c17fac587cb6e3c7706fd
[4/6] regmap: sdw-mbq: Add support for SDCA deferred controls
      commit: 5bc493bf0c37c157bf2eb364e55a1c6f8bc43a69

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: (subset) [PATCH v2 0/6] Expand SoundWire MBQ register map support
Posted by Mark Brown 10 months, 2 weeks ago
On Tue, 07 Jan 2025 15:44:02 +0000, Charles Keepax wrote:
> The current SDCA MBQ (Multi-Byte Quantities) register map only
> supports 16-bit types, add support for more sizes and then update
> the rt722 driver to use the new support. We also add support for
> the deferring feature of MBQs to allow hardware to indicate it is
> not currently ready to service a read/write.
> 
> Afraid I don't have hardware to test the rt722 change so it is
> only build tested, but I thought it good to include a change to
> demonstrate the new features in use.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[5/6] ASoC: rt722-sdca: Add some missing readable registers
      commit: f9a5c4b6afc79073491acdab7f1e943ee3a19fbb
[6/6] ASoC: rt722-sdca: Make use of new expanded MBQ regmap
      commit: 299ce4beaf714abe76e3ad106f2e745748f693e9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark