[PATCH v2 5/7] regulator: tps65215: Update platform_device_id table

Shree Ramamoorthy posted 7 patches 1 year, 1 month ago
There is a newer version of this series
[PATCH v2 5/7] regulator: tps65215: Update platform_device_id table
Posted by Shree Ramamoorthy 1 year, 1 month ago
Add TI TPS65215 PMIC to the existing platform_device_id struct, so the
regulator probe() can match which PMIC chip_data information.

Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
---
 drivers/regulator/tps65219-regulator.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c
index 30928f1f216f..6dc0829cf29a 100644
--- a/drivers/regulator/tps65219-regulator.c
+++ b/drivers/regulator/tps65219-regulator.c
@@ -404,7 +404,8 @@ static int tps65219_regulator_probe(struct platform_device *pdev)
 }
 
 static const struct platform_device_id tps65219_regulator_id_table[] = {
-	{ "tps65219-regulator", },
+	{ "tps65215-regulator", TPS65215 },
+	{ "tps65219-regulator", TPS65219 },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(platform, tps65219_regulator_id_table);
-- 
2.34.1
Re: [PATCH v2 5/7] regulator: tps65215: Update platform_device_id table
Posted by Krzysztof Kozlowski 1 year, 1 month ago
On Fri, Jan 03, 2025 at 05:04:44PM -0600, Shree Ramamoorthy wrote:
> Add TI TPS65215 PMIC to the existing platform_device_id struct, so the
> regulator probe() can match which PMIC chip_data information.

Why is this a separate commit? Adding new device support is one commit -
so the tables, regulator definition and the quirks/ID table.

The next commit will be adding new entry to of_device_id?

Best regards,
Krzysztof
Re: [PATCH v2 5/7] regulator: tps65215: Update platform_device_id table
Posted by Shree Ramamoorthy 1 year, 1 month ago
Hi,


On 1/4/25 4:14 AM, Krzysztof Kozlowski wrote:
> On Fri, Jan 03, 2025 at 05:04:44PM -0600, Shree Ramamoorthy wrote:
>> Add TI TPS65215 PMIC to the existing platform_device_id struct, so the
>> regulator probe() can match which PMIC chip_data information.
> Why is this a separate commit? Adding new device support is one commit -
> so the tables, regulator definition and the quirks/ID table.
>
> The next commit will be adding new entry to of_device_id?
>
> Best regards,
> Krzysztof

I'll reorganize the commits to define and use the new resources &
functions within the same patch.


-- 
Best,
Shree Ramamoorthy
PMIC Software Engineer