dt-bindings: mfd: syscon: Sync compatible lists

[PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

Posted by Andrew Davis 1 year, 1 month ago

This compatible was only added to the list for compatibility with older
dtschema (<2024.02). Add it to the other list also so both new and old
tools work.

Fixes: 0d078d47cd3e ("dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl compatible")
Signed-off-by: Andrew Davis <afd@ti.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 032cdd30d95f1..717b616349e3d 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -214,6 +214,7 @@ properties:
           - ti,am625-dss-oldi-io-ctrl
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
+          - ti,j784s4-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
       - const: syscon
-- 
2.39.2

Re: [PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

Posted by Romain Naour 1 year, 1 month ago

Hello Andrew, All,

Le 03/01/2025 à 18:45, Andrew Davis a écrit :
> This compatible was only added to the list for compatibility with older
> dtschema (<2024.02). Add it to the other list also so both new and old
> tools work.
> 
> Fixes: 0d078d47cd3e ("dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl compatible")
> Signed-off-by: Andrew Davis <afd@ti.com>

Reviewed-by: Romain Naour <romain.naour@smile.fr>

Best regards,
Romain


> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 032cdd30d95f1..717b616349e3d 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -214,6 +214,7 @@ properties:
>            - ti,am625-dss-oldi-io-ctrl
>            - ti,am62p-cpsw-mac-efuse
>            - ti,am654-dss-oldi-io-ctrl
> +          - ti,j784s4-acspcie-proxy-ctrl
>            - ti,j784s4-pcie-ctrl
>            - ti,keystone-pllctrl
>        - const: syscon

Re: [PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

Posted by Krzysztof Kozlowski 1 year, 1 month ago

On Fri, Jan 03, 2025 at 11:45:22AM -0600, Andrew Davis wrote:
> This compatible was only added to the list for compatibility with older
> dtschema (<2024.02). Add it to the other list also so both new and old

That's not a list of compatibles, but just select to apply the schema on
older dtschema.

> tools work.

This compatible was simply never documented and never really worked.
Original patch was probably never tested. :/

> 
> Fixes: 0d078d47cd3e ("dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl compatible")
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

Posted by Siddharth Vadapalli 1 year, 1 month ago

On Fri, Jan 03, 2025 at 11:45:22AM -0600, Andrew Davis wrote:
> This compatible was only added to the list for compatibility with older
> dtschema (<2024.02). Add it to the other list also so both new and old
> tools work.
> 
> Fixes: 0d078d47cd3e ("dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl compatible")
> Signed-off-by: Andrew Davis <afd@ti.com>

Thank you for the fix.

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.

> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 032cdd30d95f1..717b616349e3d 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -214,6 +214,7 @@ properties:
>            - ti,am625-dss-oldi-io-ctrl
>            - ti,am62p-cpsw-mac-efuse
>            - ti,am654-dss-oldi-io-ctrl
> +          - ti,j784s4-acspcie-proxy-ctrl
>            - ti,j784s4-pcie-ctrl
>            - ti,keystone-pllctrl
>        - const: syscon
> -- 
> 2.39.2
>

Re: (subset) [PATCH 1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible

Posted by Lee Jones 1 year ago

On Fri, 03 Jan 2025 11:45:22 -0600, Andrew Davis wrote:
> This compatible was only added to the list for compatibility with older
> dtschema (<2024.02). Add it to the other list also so both new and old
> tools work.
> 
> 

Applied, thanks!

[1/3] dt-bindings: mfd: syscon: Fix ti,j784s4-acspcie-proxy-ctrl compatible
      commit: 756d4b7a873c1170b65ea1e4cf0312f0a3f9976f

--
Lee Jones [李琼斯]