The PCI abstractions do not actually depend on CONFIG_PCI_MSI; it also
breaks drivers that only depend on CONFIG_PCI, hence drop it.

While at it, move the module entry to its correct location.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501030744.4ucqC1cB-lkp@intel.com/
Fixes: 3a9c09193657 ("rust: pci: add basic PCI device / driver abstractions")
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
 rust/kernel/lib.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
index e59250dc6c6e..b7351057ed9c 100644
--- a/rust/kernel/lib.rs
+++ b/rust/kernel/lib.rs
@@ -58,6 +58,8 @@
 pub mod net;
 pub mod of;
 pub mod page;
+#[cfg(CONFIG_PCI)]
+pub mod pci;
 pub mod pid_namespace;
 pub mod platform;
 pub mod prelude;
@@ -84,8 +86,6 @@
 pub use bindings;
 pub mod io;
 pub use macros;
-#[cfg(all(CONFIG_PCI, CONFIG_PCI_MSI))]
-pub mod pci;
 pub use uapi;
 
 #[doc(hidden)]
-- 
2.47.1

On Fri, Jan 03, 2025 at 05:46:01PM +0100, Danilo Krummrich wrote:
> The PCI abstractions do not actually depend on CONFIG_PCI_MSI; it also
> breaks drivers that only depend on CONFIG_PCI, hence drop it.
> 
> While at it, move the module entry to its correct location.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501030744.4ucqC1cB-lkp@intel.com/
> Fixes: 3a9c09193657 ("rust: pci: add basic PCI device / driver abstractions")

Where did that git id come from?  It's
1bd8b6b2c5d38d9881d59928b986eacba40f9da8.  I'll go edit it by hand...

thanks,

greg k-h

On Tue, Jan 07, 2025 at 11:31:26AM +0100, Greg KH wrote:
> On Fri, Jan 03, 2025 at 05:46:01PM +0100, Danilo Krummrich wrote:
> > The PCI abstractions do not actually depend on CONFIG_PCI_MSI; it also
> > breaks drivers that only depend on CONFIG_PCI, hence drop it.
> > 
> > While at it, move the module entry to its correct location.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202501030744.4ucqC1cB-lkp@intel.com/
> > Fixes: 3a9c09193657 ("rust: pci: add basic PCI device / driver abstractions")
> 
> Where did that git id come from?  It's
> 1bd8b6b2c5d38d9881d59928b986eacba40f9da8.  I'll go edit it by hand...

Oops, that's from my tree. I did not rebase to the driver-core tree, sorry.

> 
> thanks,
> 
> greg k-h