drm/tests: helpers: Fix compile wrarning

[PATCH] drm/tests: helpers: Fix compile wrarning

Posted by Yu-Chun Lin 1 year, 1 month ago

Delete one line break to make the format correct, resolving the
following warning during a W=1 build:

>> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a KUnit test

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501032001.O6WY1VCW-lkp@intel.com/
Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Tested-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
---
 drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index 04a6b8cc62ac..3c0b7824c0be 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -320,8 +320,7 @@ static void kunit_action_drm_mode_destroy(void *ptr)
 }
 
 /**
- * drm_kunit_display_mode_from_cea_vic() - return a mode for CEA VIC
-					   for a KUnit test
+ * drm_kunit_display_mode_from_cea_vic() - return a mode for CEA VIC for a KUnit test
  * @test: The test context object
  * @dev: DRM device
  * @video_code: CEA VIC of the mode
-- 
2.43.0

Re: [PATCH] drm/tests: helpers: Fix compile wrarning

Posted by Dmitry Baryshkov 1 year, 1 month ago

On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote:
> Delete one line break to make the format correct, resolving the
> following warning during a W=1 build:
> 
> >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a KUnit test
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501032001.O6WY1VCW-lkp@intel.com/
> Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>

Reviewed where?

> Tested-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
> ---
>  drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

Re: [PATCH] drm/tests: helpers: Fix compile wrarning

Posted by Kuan-Wei Chiu 1 year, 1 month ago

Hi Dmitry,

On Fri, Jan 03, 2025 at 08:14:20PM +0200, Dmitry Baryshkov wrote:
> On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote:
> > Delete one line break to make the format correct, resolving the
> > following warning during a W=1 build:
> > 
> > >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a KUnit test
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202501032001.O6WY1VCW-lkp@intel.com/
> > Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> 
> Reviewed where?
> 
Yu-Chun is a newcomer looking to contribute to Linux and asked for my
help. As suggested in the last section of [1], she asked me to review
her patch privately before sending it to the public mailing list and
include my Reviewed-by tag. This improves patch quality and reduces
the maintainer's workload by minimizing potential issues.

Although I'm not a DRM developer, I have been contributing to Linux for
some time and wanted to provide support.

[1]: Documentation/process/researcher-guidelines.rst

> > Tested-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> > Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
> > ---
> >  drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
Thanks for your review!

Regards,
Kuan-Wei

Re: [PATCH] drm/tests: helpers: Fix compile wrarning

Posted by Dmitry Baryshkov 1 year, 1 month ago

On Sat, Jan 04, 2025 at 05:43:54AM +0800, Kuan-Wei Chiu wrote:
> Hi Dmitry,
> 
> On Fri, Jan 03, 2025 at 08:14:20PM +0200, Dmitry Baryshkov wrote:
> > On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote:
> > > Delete one line break to make the format correct, resolving the
> > > following warning during a W=1 build:
> > > 
> > > >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a KUnit test
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202501032001.O6WY1VCW-lkp@intel.com/
> > > Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> > 
> > Reviewed where?
> > 
> Yu-Chun is a newcomer looking to contribute to Linux and asked for my
> help. As suggested in the last section of [1], she asked me to review
> her patch privately before sending it to the public mailing list and
> include my Reviewed-by tag. This improves patch quality and reduces
> the maintainer's workload by minimizing potential issues.

Good, thanks for the explanation. It's perfectly fine, just wanted to be
sure that this is what actually happened.

> 
> Although I'm not a DRM developer, I have been contributing to Linux for
> some time and wanted to provide support.
> 
> [1]: Documentation/process/researcher-guidelines.rst
> 
> > > Tested-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> > > Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
> > > ---
> > >  drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > 
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >
> Thanks for your review!
> 
> Regards,
> Kuan-Wei

-- 
With best wishes
Dmitry