[v1] selftests: bpf: Migrate test_xdp_redirect.sh to test_progs

[PATCH 0/3] selftests: bpf: Migrate test_xdp_redirect.sh to test_progs

Bastien Curutchet (eBPF Foundation) posted 3 patches 1 year, 1 month ago

Diff against v2
Download series mbox

There is a newer version of this series

tools/testing/selftests/bpf/Makefile               |   1 -
.../selftests/bpf/prog_tests/xdp_do_redirect.c     | 192 +++++++++++++++++++++
.../selftests/bpf/progs/test_xdp_do_redirect.c     |  12 ++
.../selftests/bpf/progs/test_xdp_redirect.c        |  26 ---
tools/testing/selftests/bpf/test_xdp_redirect.sh   |  79 ---------
5 files changed, 204 insertions(+), 106 deletions(-)

Expand all Fold all

[PATCH 0/3] selftests: bpf: Migrate test_xdp_redirect.sh to test_progs

Posted by Bastien Curutchet (eBPF Foundation) 1 year, 1 month ago

Hi all,

This patch series continues the work to migrate the *.sh tests into
prog_tests.

test_xdp_redirect.sh tests the XDP redirections done through
bpf_redirect().

These XDP redirections are already tested by prog_tests/xdp_do_redirect.c
but IMO it doesn't cover the exact same code path because
xdp_do_redirect.c uses bpf_prog_test_run_opts() to trigger redirections
of 'fake packets' while test_xdp_redirect.sh redirects packets coming
from the network. Also, the test_xdp_redirect.sh script tests the
redirections with both SKB and DRV modes while xdp_do_redirect.c only
tests the DRV mode.

The patch series adds two new test cases in prog_tests/xdp_do_redirect.c
to replace the test_xdp_redirect.sh script.

Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>
---
Bastien Curutchet (eBPF Foundation) (3):
      selftests/bpf: test_xdp_redirect: Rename BPF sections
      selftests/bpf: Migrate test_xdp_redirect.sh to xdp_do_redirect.c
      selftests/bpf: Migrate test_xdp_redirect.c to test_xdp_do_redirect.c

 tools/testing/selftests/bpf/Makefile               |   1 -
 .../selftests/bpf/prog_tests/xdp_do_redirect.c     | 192 +++++++++++++++++++++
 .../selftests/bpf/progs/test_xdp_do_redirect.c     |  12 ++
 .../selftests/bpf/progs/test_xdp_redirect.c        |  26 ---
 tools/testing/selftests/bpf/test_xdp_redirect.sh   |  79 ---------
 5 files changed, 204 insertions(+), 106 deletions(-)
---
base-commit: da86bde1e6d1b887efc46af5ee1f9bbccd27233e
change-id: 20241219-xdp_redirect-2b8ec79dc24e

Best regards,
-- 
Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>

Re: [PATCH 0/3] selftests: bpf: Migrate test_xdp_redirect.sh to test_progs

Posted by Bastien Curutchet 1 year, 1 month ago

Hi all,


On 1/3/25 11:10 AM, Bastien Curutchet (eBPF Foundation) wrote:
> Hi all,
> 
> This patch series continues the work to migrate the *.sh tests into
> prog_tests.
> 
> test_xdp_redirect.sh tests the XDP redirections done through
> bpf_redirect().
> 
> These XDP redirections are already tested by prog_tests/xdp_do_redirect.c
> but IMO it doesn't cover the exact same code path because
> xdp_do_redirect.c uses bpf_prog_test_run_opts() to trigger redirections
> of 'fake packets' while test_xdp_redirect.sh redirects packets coming
> from the network. Also, the test_xdp_redirect.sh script tests the
> redirections with both SKB and DRV modes while xdp_do_redirect.c only
> tests the DRV mode.
> 
> The patch series adds two new test cases in prog_tests/xdp_do_redirect.c
> to replace the test_xdp_redirect.sh script.
> 
> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>
> ---

I realize I forgot to mention 'bpf-next', sorry about that.
This work is based on the bpf-next_base branch.

Best regards,
Bastien