[PATCH] microblaze: Use of_property_present() for non-boolean properties

Rob Herring (Arm) posted 1 patch 1 year, 4 months ago
arch/microblaze/kernel/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] microblaze: Use of_property_present() for non-boolean properties
Posted by Rob Herring (Arm) 1 year, 4 months ago
The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/microblaze/kernel/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
index 26c385582c3b..ccb4b4b59bca 100644
--- a/arch/microblaze/kernel/timer.c
+++ b/arch/microblaze/kernel/timer.c
@@ -252,7 +252,7 @@ static int __init xilinx_timer_init(struct device_node *timer)
 	int ret;
 
 	/* If this property is present, the device is a PWM and not a timer */
-	if (of_property_read_bool(timer, "#pwm-cells"))
+	if (of_property_present(timer, "#pwm-cells"))
 		return 0;
 
 	if (initialized)
-- 
2.45.2
Re: [PATCH] microblaze: Use of_property_present() for non-boolean properties
Posted by Michal Simek 1 year, 4 months ago
út 31. 12. 2024 v 17:14 odesílatel Rob Herring (Arm) <robh@kernel.org> napsal:
>
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  arch/microblaze/kernel/timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
> index 26c385582c3b..ccb4b4b59bca 100644
> --- a/arch/microblaze/kernel/timer.c
> +++ b/arch/microblaze/kernel/timer.c
> @@ -252,7 +252,7 @@ static int __init xilinx_timer_init(struct device_node *timer)
>         int ret;
>
>         /* If this property is present, the device is a PWM and not a timer */
> -       if (of_property_read_bool(timer, "#pwm-cells"))
> +       if (of_property_present(timer, "#pwm-cells"))
>                 return 0;
>
>         if (initialized)
> --
> 2.45.2
>

Applied.
M


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs