[v1] MAINTAINERS: Fix list entries with display names

[RESEND PATCH] MAINTAINERS: Fix list entries with display names

Posted by Rob Herring (Arm) 11 months, 3 weeks ago

get_maintainers.pl doesn't expect list entries to have a display name.
Entries with a display name are omitted and print just the description:

 (open list:PIN CONTROLLER - FREESCALE)

These cases are pretty much aliases to a few people, not lists which
are archived and can be subscribed to. Change these cases to be reviewers
instead.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 MAINTAINERS | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 910305c11e8a..e4c98db82a42 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2830,7 +2830,7 @@ ARM/NXP S32G ARCHITECTURE
 R:	Chester Lin <chester62515@gmail.com>
 R:	Matthias Brugger <mbrugger@suse.com>
 R:	Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>
-L:	NXP S32 Linux Team <s32@nxp.com>
+R:	NXP S32 Linux Team <s32@nxp.com>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 F:	arch/arm64/boot/dts/freescale/s32g*.dts*
@@ -16604,8 +16604,8 @@ F:	arch/nios2/
 
 NITRO ENCLAVES (NE)
 M:	Alexandru Ciobotaru <alcioa@amazon.com>
+R:	The AWS Nitro Enclaves Team <aws-nitro-enclaves-devel@amazon.com>
 L:	linux-kernel@vger.kernel.org
-L:	The AWS Nitro Enclaves Team <aws-nitro-enclaves-devel@amazon.com>
 S:	Supported
 W:	https://aws.amazon.com/ec2/nitro/nitro-enclaves/
 F:	Documentation/virt/ne_overview.rst
@@ -16616,8 +16616,8 @@ F:	samples/nitro_enclaves/
 
 NITRO SECURE MODULE (NSM)
 M:	Alexander Graf <graf@amazon.com>
+R:	The AWS Nitro Enclaves Team <aws-nitro-enclaves-devel@amazon.com>
 L:	linux-kernel@vger.kernel.org
-L:	The AWS Nitro Enclaves Team <aws-nitro-enclaves-devel@amazon.com>
 S:	Supported
 W:	https://aws.amazon.com/ec2/nitro/nitro-enclaves/
 F:	drivers/misc/nsm.c
@@ -18429,8 +18429,8 @@ M:	Fabio Estevam <festevam@gmail.com>
 M:	Shawn Guo <shawnguo@kernel.org>
 M:	Jacky Bai <ping.bai@nxp.com>
 R:	Pengutronix Kernel Team <kernel@pengutronix.de>
+R:	NXP S32 Linux Team <s32@nxp.com>
 L:	linux-gpio@vger.kernel.org
-L:	NXP S32 Linux Team <s32@nxp.com>
 S:	Maintained
 F:	Documentation/devicetree/bindings/pinctrl/fsl,*
 F:	Documentation/devicetree/bindings/pinctrl/nxp,s32*
@@ -19565,7 +19565,7 @@ F:	drivers/ras/amd/fmpm.c
 
 RASPBERRY PI PISP BACK END
 M:	Jacopo Mondi <jacopo.mondi@ideasonboard.com>
-L:	Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
+R:	Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml
-- 
2.45.2

Re: [RESEND PATCH] MAINTAINERS: Fix list entries with display names

Posted by Andrew Morton 11 months, 2 weeks ago

On Tue, 31 Dec 2024 09:54:14 -0600 "Rob Herring (Arm)" <robh@kernel.org> wrote:

> get_maintainers.pl doesn't expect list entries to have a display name.
> Entries with a display name are omitted and print just the description:
> 
>  (open list:PIN CONTROLLER - FREESCALE)
> 
> These cases are pretty much aliases to a few people, not lists which
> are archived and can be subscribed to. Change these cases to be reviewers
> instead.

Feels a bit wrong.  Are you sure that *all* of the below "lists" are
not really lists?  If so then OK I suppose.  Or perhaps we should have
a new MAINTAINERS tag to cover this situation.

And shouldn't get_maintainer be made to be more friendly in its
handling of these entries?  Omitting the email address seems kinda dumb.

Re: [RESEND PATCH] MAINTAINERS: Fix list entries with display names

Posted by Rob Herring 11 months, 2 weeks ago

On Thu, Jan 2, 2025 at 5:47 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 31 Dec 2024 09:54:14 -0600 "Rob Herring (Arm)" <robh@kernel.org> wrote:
>
> > get_maintainers.pl doesn't expect list entries to have a display name.
> > Entries with a display name are omitted and print just the description:
> >
> >  (open list:PIN CONTROLLER - FREESCALE)
> >
> > These cases are pretty much aliases to a few people, not lists which
> > are archived and can be subscribed to. Change these cases to be reviewers
> > instead.
>
> Feels a bit wrong.  Are you sure that *all* of the below "lists" are
> not really lists?  If so then OK I suppose.  Or perhaps we should have
> a new MAINTAINERS tag to cover this situation.

They certainly don't look like anything anyone outside those
organizations can subscribe to or would have public archives. Whether
they are lists or aliases internally doesn't matter to us.

> And shouldn't get_maintainer be made to be more friendly in its
> handling of these entries?  Omitting the email address seems kinda dumb.

That's certainly an alternate or additional fix. I was hoping Joe
would know where to fix that rather than me trying to wade thru perl.
:)

Rob

Re: [RESEND PATCH] MAINTAINERS: Fix list entries with display names

Posted by Joe Perches 11 months, 2 weeks ago

On Fri, 2025-01-03 at 08:08 -0600, Rob Herring wrote:
> On Thu, Jan 2, 2025 at 5:47 PM Andrew Morton <[akpm@linux-foundation.org](mailto:akpm@linux-foundation.org)> wrote:
> > On Tue, 31 Dec 2024 09:54:14 -0600 "Rob Herring (Arm)" <[robh@kernel.org](mailto:robh@kernel.org)> wrote:
> > > get_maintainers.pl doesn't expect list entries to have a display name.
> > > Entries with a display name are omitted and print just the description:
> > > 
> > >  (open list:PIN CONTROLLER - FREESCALE)
> > > 
> > > These cases are pretty much aliases to a few people, not lists which
> > > are archived and can be subscribed to. Change these cases to be reviewers
> > > instead.
> > 
> > Feels a bit wrong.  Are you sure that *all* of the below "lists" are
> > not really lists?  If so then OK I suppose.  Or perhaps we should have
> > a new MAINTAINERS tag to cover this situation.
> They certainly don't look like anything anyone outside those
> organizations can subscribe to or would have public archives. Whether
> they are lists or aliases internally doesn't matter to us.
> > And shouldn't get_maintainer be made to be more friendly in its
> > handling of these entries?  Omitting the email address seems kinda dumb.
> > 
[]
> That's certainly an alternate or additional fix. I was hoping Joe
> would know where to fix that rather than me trying to wade thru perl.
> :)

Maybe something like this:
---
 scripts/get_maintainer.pl | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index ee1aed7e090ca..c5486827c81b5 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1332,6 +1332,7 @@ sub add_categories {
 	    my $ptype = $1;
 	    my $pvalue = $2;
 	    if ($ptype eq "L") {
+		my $list_name = "";
 		my $list_address = $pvalue;
 		my $list_additional = "";
 		my $list_role = get_list_role($i);
@@ -1339,10 +1340,16 @@ sub add_categories {
 		if ($list_role ne "") {
 		    $list_role = ":" . $list_role;
 		}
-		if ($list_address =~ m/([^\s]+)\s+(.*)$/) {
+		if ($list_address =~ m/^([^\<]+)\<(\S+@\S+)\>\s*(.*)$/) {
+		    $list_name = $1;
+		    $list_address = $2;
+		    $list_additional = $3;
+		    $list_name =~ s/^\s+|\s+$//g; #trim
+		} elsif ($list_address =~ m/([^\s]+)\s+(.*)$/) {
 		    $list_address = $1;
 		    $list_additional = $2;
 		}
+
 		if ($list_additional =~ m/subscribers-only/) {
 		    if ($email_subscriber_list) {
 			if (!$hash_list_to{lc($list_address)}) {