[PATCH v3 0/3] Add display subsystem dt node on rk3576

Andy Yan posted 3 patches 1 year, 4 months ago
.../boot/dts/rockchip/rk3576-armsom-sige5.dts |  47 +++++++
arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 126 ++++++++++++++++++
2 files changed, 173 insertions(+)
[PATCH v3 0/3] Add display subsystem dt node on rk3576
Posted by Andy Yan 1 year, 4 months ago
From: Andy Yan <andy.yan@rock-chips.com>


As the VOP[0] and HDMI[1] driver have already been submitted for review.
This series enable hdmi display on sige5 board.

[0] https://lore.kernel.org/linux-rockchip/20241231090802.251787-1-andyshrk@163.com/T/#t
[1] https://lore.kernel.org/linux-rockchip/20241231094425.253398-1-andyshrk@163.com/T/#t

Changes in v3:
- Split from https://lore.kernel.org/linux-rockchip/3330586.aeNJFYEL58@diego/T/#t

Andy Yan (3):
  arm64: dts: rockchip: Add vop for rk3576
  arm64: dts: rockchip: Add hdmi for rk3576
  arm64: dts: rockchip: Enable hdmi display on sige5

 .../boot/dts/rockchip/rk3576-armsom-sige5.dts |  47 +++++++
 arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 126 ++++++++++++++++++
 2 files changed, 173 insertions(+)

-- 
2.34.1
Re: [PATCH v3 0/3] Add display subsystem dt node on rk3576
Posted by Heiko Stuebner 1 year, 2 months ago
On Tue, 31 Dec 2024 17:57:17 +0800, Andy Yan wrote:
> As the VOP[0] and HDMI[1] driver have already been submitted for review.
> This series enable hdmi display on sige5 board.
> 
> [0] https://lore.kernel.org/linux-rockchip/20241231090802.251787-1-andyshrk@163.com/T/#t
> [1] https://lore.kernel.org/linux-rockchip/20241231094425.253398-1-andyshrk@163.com/T/#t
> 
> Changes in v3:
> - Split from https://lore.kernel.org/linux-rockchip/3330586.aeNJFYEL58@diego/T/#t
> 
> [...]

Applied, thanks!

[1/3] arm64: dts: rockchip: Add vop for rk3576
      commit: d74b842cab0860e41a45df0dac41e4e56202c766
[2/3] arm64: dts: rockchip: Add hdmi for rk3576
      commit: ad0ea230ab2a3535b186f7fb863b4bca7050e06f
[3/3] arm64: dts: rockchip: Enable hdmi display on sige5
      commit: 2062b91b9f3c6afe9c2a7d1ddf0f3e6af5f3fa31

I've adapted the patches where needed.
- Moved the grf to it's address-related position
- updated the irq names

With all the driver patches in place, dtbscheck for the sige5 is happy.


Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>
Re: [PATCH v3 0/3] Add display subsystem dt node on rk3576
Posted by Rob Herring (Arm) 1 year, 4 months ago
On Tue, 31 Dec 2024 17:57:17 +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> 
> As the VOP[0] and HDMI[1] driver have already been submitted for review.
> This series enable hdmi display on sige5 board.
> 
> [0] https://lore.kernel.org/linux-rockchip/20241231090802.251787-1-andyshrk@163.com/T/#t
> [1] https://lore.kernel.org/linux-rockchip/20241231094425.253398-1-andyshrk@163.com/T/#t
> 
> Changes in v3:
> - Split from https://lore.kernel.org/linux-rockchip/3330586.aeNJFYEL58@diego/T/#t
> 
> Andy Yan (3):
>   arm64: dts: rockchip: Add vop for rk3576
>   arm64: dts: rockchip: Add hdmi for rk3576
>   arm64: dts: rockchip: Enable hdmi display on sige5
> 
>  .../boot/dts/rockchip/rk3576-armsom-sige5.dts |  47 +++++++
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 126 ++++++++++++++++++
>  2 files changed, 173 insertions(+)
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3576-armsom-sige5.dtb' for 20241231095728.253943-1-andyshrk@163.com:

arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: /soc/syscon@26032000: failed to match any schema with compatible: ['rockchip,rk3576-hdptxphy-grf', 'syscon']
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: /soc/vop@27d00000: failed to match any schema with compatible: ['rockchip,rk3576-vop']
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: iommu@27d07e00: compatible: 'oneOf' conditional failed, one must be fixed:
	['rockchip,rk3576-iommu', 'rockchip,rk3568-iommu'] is too long
	'rockchip,rk3576-iommu' is not one of ['rockchip,iommu', 'rockchip,rk3568-iommu']
	'rockchip,rk3576-iommu' is not one of ['rockchip,rk3588-iommu']
	from schema $id: http://devicetree.org/schemas/iommu/rockchip,iommu.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: /soc/iommu@27d07e00: failed to match any schema with compatible: ['rockchip,rk3576-iommu', 'rockchip,rk3568-iommu']
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: /soc/hdmi@27da0000: failed to match any schema with compatible: ['rockchip,rk3576-dw-hdmi-qp']
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: hdmiphy@2b000000: compatible:0: 'rockchip,rk3576-hdptx-phy' is not one of ['rockchip,rk3588-hdptx-phy']
	from schema $id: http://devicetree.org/schemas/phy/rockchip,rk3588-hdptx-phy.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: hdmiphy@2b000000: compatible: ['rockchip,rk3576-hdptx-phy', 'rockchip,rk3588-hdptx-phy'] is too long
	from schema $id: http://devicetree.org/schemas/phy/rockchip,rk3588-hdptx-phy.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: hdmiphy@2b000000: resets: [[17, 428], [17, 450], [17, 451], [17, 452]] is too short
	from schema $id: http://devicetree.org/schemas/phy/rockchip,rk3588-hdptx-phy.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: hdmiphy@2b000000: reset-names:0: 'phy' was expected
	from schema $id: http://devicetree.org/schemas/phy/rockchip,rk3588-hdptx-phy.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: hdmiphy@2b000000: reset-names:1: 'apb' was expected
	from schema $id: http://devicetree.org/schemas/phy/rockchip,rk3588-hdptx-phy.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: hdmiphy@2b000000: reset-names:2: 'init' was expected
	from schema $id: http://devicetree.org/schemas/phy/rockchip,rk3588-hdptx-phy.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: hdmiphy@2b000000: reset-names:3: 'cmn' was expected
	from schema $id: http://devicetree.org/schemas/phy/rockchip,rk3588-hdptx-phy.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: hdmiphy@2b000000: reset-names: ['apb', 'init', 'cmn', 'lane'] is too short
	from schema $id: http://devicetree.org/schemas/phy/rockchip,rk3588-hdptx-phy.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: /soc/hdmiphy@2b000000: failed to match any schema with compatible: ['rockchip,rk3576-hdptx-phy', 'rockchip,rk3588-hdptx-phy']
Re: [PATCH v3 0/3] Add display subsystem dt node on rk3576
Posted by Sebastian Reichel 1 year, 2 months ago
Hello,

On Tue, Dec 31, 2024 at 06:57:21AM -0600, Rob Herring (Arm) wrote:
> On Tue, 31 Dec 2024 17:57:17 +0800, Andy Yan wrote:
> > As the VOP[0] and HDMI[1] driver have already been submitted for review.
> > This series enable hdmi display on sige5 board.
> > 
> > [0] https://lore.kernel.org/linux-rockchip/20241231090802.251787-1-andyshrk@163.com/T/#t
> > [1] https://lore.kernel.org/linux-rockchip/20241231094425.253398-1-andyshrk@163.com/T/#t
> > 
> > Changes in v3:
> > - Split from https://lore.kernel.org/linux-rockchip/3330586.aeNJFYEL58@diego/T/#t
> > 
> > Andy Yan (3):
> >   arm64: dts: rockchip: Add vop for rk3576
> >   arm64: dts: rockchip: Add hdmi for rk3576
> >   arm64: dts: rockchip: Enable hdmi display on sige5
> > 
> >  .../boot/dts/rockchip/rk3576-armsom-sige5.dts |  47 +++++++
> >  arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 126 ++++++++++++++++++
> >  2 files changed, 173 insertions(+)
>
> [...] (a bunch of warnings due to dependency patch series not yet
> being in linux-next)

I think all dependencies have landed now. But it might be sensible
to do a quick resend considering how old this is.

Would be nice to have initial RK3576 HDMI support in 6.15 :)

Greetings,

-- Sebastian
Re: [PATCH v3 0/3] Add display subsystem dt node on rk3576
Posted by Heiko Stübner 1 year, 2 months ago
Am Dienstag, 4. März 2025, 15:47:28 MEZ schrieb Sebastian Reichel:
> Hello,
> 
> On Tue, Dec 31, 2024 at 06:57:21AM -0600, Rob Herring (Arm) wrote:
> > On Tue, 31 Dec 2024 17:57:17 +0800, Andy Yan wrote:
> > > As the VOP[0] and HDMI[1] driver have already been submitted for review.
> > > This series enable hdmi display on sige5 board.
> > > 
> > > [0] https://lore.kernel.org/linux-rockchip/20241231090802.251787-1-andyshrk@163.com/T/#t
> > > [1] https://lore.kernel.org/linux-rockchip/20241231094425.253398-1-andyshrk@163.com/T/#t
> > > 
> > > Changes in v3:
> > > - Split from https://lore.kernel.org/linux-rockchip/3330586.aeNJFYEL58@diego/T/#t
> > > 
> > > Andy Yan (3):
> > >   arm64: dts: rockchip: Add vop for rk3576
> > >   arm64: dts: rockchip: Add hdmi for rk3576
> > >   arm64: dts: rockchip: Enable hdmi display on sige5
> > > 
> > >  .../boot/dts/rockchip/rk3576-armsom-sige5.dts |  47 +++++++
> > >  arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 126 ++++++++++++++++++
> > >  2 files changed, 173 insertions(+)
> >
> > [...] (a bunch of warnings due to dependency patch series not yet
> > being in linux-next)
> 
> I think all dependencies have landed now. But it might be sensible
> to do a quick resend considering how old this is.
> 
> Would be nice to have initial RK3576 HDMI support in 6.15 :)

now we can :-)

The update was not that difficult, so did it myself when applying.


Heiko
Re:Re: [PATCH v3 0/3] Add display subsystem dt node on rk3576
Posted by Andy Yan 1 year, 2 months ago
Hello,

在 2025-03-05 05:16:49,"Heiko Stübner" <heiko@sntech.de> 写道:
>Am Dienstag, 4. März 2025, 15:47:28 MEZ schrieb Sebastian Reichel:
>> Hello,
>> 
>> On Tue, Dec 31, 2024 at 06:57:21AM -0600, Rob Herring (Arm) wrote:
>> > On Tue, 31 Dec 2024 17:57:17 +0800, Andy Yan wrote:
>> > > As the VOP[0] and HDMI[1] driver have already been submitted for review.
>> > > This series enable hdmi display on sige5 board.
>> > > 
>> > > [0] https://lore.kernel.org/linux-rockchip/20241231090802.251787-1-andyshrk@163.com/T/#t
>> > > [1] https://lore.kernel.org/linux-rockchip/20241231094425.253398-1-andyshrk@163.com/T/#t
>> > > 
>> > > Changes in v3:
>> > > - Split from https://lore.kernel.org/linux-rockchip/3330586.aeNJFYEL58@diego/T/#t
>> > > 
>> > > Andy Yan (3):
>> > >   arm64: dts: rockchip: Add vop for rk3576
>> > >   arm64: dts: rockchip: Add hdmi for rk3576
>> > >   arm64: dts: rockchip: Enable hdmi display on sige5
>> > > 
>> > >  .../boot/dts/rockchip/rk3576-armsom-sige5.dts |  47 +++++++
>> > >  arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 126 ++++++++++++++++++
>> > >  2 files changed, 173 insertions(+)
>> >
>> > [...] (a bunch of warnings due to dependency patch series not yet
>> > being in linux-next)
>> 
>> I think all dependencies have landed now. But it might be sensible
>> to do a quick resend considering how old this is.
>> 
>> Would be nice to have initial RK3576 HDMI support in 6.15 :)
>
>now we can :-)
>
>The update was not that difficult, so did it myself when applying.

Thanks for you all, many thanks.
I also sent out a patch for eanble hdmi on rk3576 evb1.


>
>
>Heiko
>
>