[v2] Add HDMI support for rk3576

[PATCH v2 0/3] Add HDMI support for rk3576

Posted by Andy Yan 1 year, 1 month ago

From: Andy Yan <andy.yan@rock-chips.com>


RK3576 HDMI TX Controller is very similar to that of RK3588, but with
some control bits for IO and interrupts status scattered across different
GRF.

PATCH 1/3 is add platform ctrl callback for IO setting and interrupts
status handing.
PATCH 2/3 ~ 3/3 are add support for rk3576

Changes in v2:
- Fix compilation warning: unused variable ‘val’ [-Wunused-variable]

Andy Yan (3):
  drm/rockchip: dw_hdmi_qp: Add platform ctrl callback
  dt-bindings: display: rockchip: Add rk3576 hdmi controller
  drm/rockchip: Add basic RK3576 HDMI output support

 .../rockchip/rockchip,rk3588-dw-hdmi-qp.yaml  |   1 +
 .../gpu/drm/rockchip/dw_hdmi_qp-rockchip.c    | 225 +++++++++++++++---
 2 files changed, 196 insertions(+), 30 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/3] Add HDMI support for rk3576

Posted by Heiko Stuebner 1 year, 1 month ago

On Tue, 31 Dec 2024 17:44:16 +0800, Andy Yan wrote:
> RK3576 HDMI TX Controller is very similar to that of RK3588, but with
> some control bits for IO and interrupts status scattered across different
> GRF.
> 
> PATCH 1/3 is add platform ctrl callback for IO setting and interrupts
> status handing.
> PATCH 2/3 ~ 3/3 are add support for rk3576
> 
> [...]

Applied, thanks!

[1/3] drm/rockchip: dw_hdmi_qp: Add platform ctrl callback
      commit: 3f60dbd40d3f7aca312d1aa1131e204eb97a68b3
[2/3] dt-bindings: display: rockchip: Add rk3576 hdmi controller
      commit: 3a5981b65f77bfb8abcc6f29c13f1b89ce9df3a3
[3/3] drm/rockchip: Add basic RK3576 HDMI output support
      commit: 36439120efbdc62e2f47053e7ddfcc4e34364640

I've fixed some minor stuff
patch1: my review nits (empty line + hardird)
patch3: drop Detlev's Signed-off
patches1+3: fixed some more checkpatch warnings


Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>