[v1] ASoC: SOF: Intel: Use str_yes_no() helper in atom_dump()

[RESEND PATCH] ASoC: SOF: Intel: Use str_yes_no() helper in atom_dump()

Posted by Thorsten Blum 11 months, 3 weeks ago

Remove hard-coded strings by using the str_yes_no() helper function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 sound/soc/sof/intel/atom.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/sound/soc/sof/intel/atom.c b/sound/soc/sof/intel/atom.c
index 30e981c558c6..0d364bcdcfa9 100644
--- a/sound/soc/sof/intel/atom.c
+++ b/sound/soc/sof/intel/atom.c
@@ -78,20 +78,20 @@ void atom_dump(struct snd_sof_dev *sdev, u32 flags)
 	imrd = snd_sof_dsp_read64(sdev, DSP_BAR, SHIM_IMRD);
 	dev_err(sdev->dev,
 		"error: ipc host -> DSP: pending %s complete %s raw 0x%llx\n",
-		(panic & SHIM_IPCX_BUSY) ? "yes" : "no",
-		(panic & SHIM_IPCX_DONE) ? "yes" : "no", panic);
+		str_yes_no(panic & SHIM_IPCX_BUSY),
+		str_yes_no(panic & SHIM_IPCX_DONE), panic);
 	dev_err(sdev->dev,
 		"error: mask host: pending %s complete %s raw 0x%llx\n",
-		(imrx & SHIM_IMRX_BUSY) ? "yes" : "no",
-		(imrx & SHIM_IMRX_DONE) ? "yes" : "no", imrx);
+		str_yes_no(imrx & SHIM_IMRX_BUSY),
+		str_yes_no(imrx & SHIM_IMRX_DONE), imrx);
 	dev_err(sdev->dev,
 		"error: ipc DSP -> host: pending %s complete %s raw 0x%llx\n",
-		(status & SHIM_IPCD_BUSY) ? "yes" : "no",
-		(status & SHIM_IPCD_DONE) ? "yes" : "no", status);
+		str_yes_no(status & SHIM_IPCD_BUSY),
+		str_yes_no(status & SHIM_IPCD_DONE), status);
 	dev_err(sdev->dev,
 		"error: mask DSP: pending %s complete %s raw 0x%llx\n",
-		(imrd & SHIM_IMRD_BUSY) ? "yes" : "no",
-		(imrd & SHIM_IMRD_DONE) ? "yes" : "no", imrd);
+		str_yes_no(imrd & SHIM_IMRD_BUSY),
+		str_yes_no(imrd & SHIM_IMRD_DONE), imrd);
 
 }
 EXPORT_SYMBOL_NS(atom_dump, "SND_SOC_SOF_INTEL_ATOM_HIFI_EP");
-- 
2.47.1

Re: [RESEND PATCH] ASoC: SOF: Intel: Use str_yes_no() helper in atom_dump()

Posted by Mark Brown 11 months, 2 weeks ago

On Mon, 30 Dec 2024 09:57:15 +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: Intel: Use str_yes_no() helper in atom_dump()
      commit: c0641be588c22fdcecdb1e90a64803047d4441f8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [RESEND PATCH] ASoC: SOF: Intel: Use str_yes_no() helper in atom_dump()

Posted by Péter Ujfalusi 11 months, 3 weeks ago


On 30/12/2024 10:57, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.

Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  sound/soc/sof/intel/atom.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/soc/sof/intel/atom.c b/sound/soc/sof/intel/atom.c
> index 30e981c558c6..0d364bcdcfa9 100644
> --- a/sound/soc/sof/intel/atom.c
> +++ b/sound/soc/sof/intel/atom.c
> @@ -78,20 +78,20 @@ void atom_dump(struct snd_sof_dev *sdev, u32 flags)
>  	imrd = snd_sof_dsp_read64(sdev, DSP_BAR, SHIM_IMRD);
>  	dev_err(sdev->dev,
>  		"error: ipc host -> DSP: pending %s complete %s raw 0x%llx\n",
> -		(panic & SHIM_IPCX_BUSY) ? "yes" : "no",
> -		(panic & SHIM_IPCX_DONE) ? "yes" : "no", panic);
> +		str_yes_no(panic & SHIM_IPCX_BUSY),
> +		str_yes_no(panic & SHIM_IPCX_DONE), panic);
>  	dev_err(sdev->dev,
>  		"error: mask host: pending %s complete %s raw 0x%llx\n",
> -		(imrx & SHIM_IMRX_BUSY) ? "yes" : "no",
> -		(imrx & SHIM_IMRX_DONE) ? "yes" : "no", imrx);
> +		str_yes_no(imrx & SHIM_IMRX_BUSY),
> +		str_yes_no(imrx & SHIM_IMRX_DONE), imrx);
>  	dev_err(sdev->dev,
>  		"error: ipc DSP -> host: pending %s complete %s raw 0x%llx\n",
> -		(status & SHIM_IPCD_BUSY) ? "yes" : "no",
> -		(status & SHIM_IPCD_DONE) ? "yes" : "no", status);
> +		str_yes_no(status & SHIM_IPCD_BUSY),
> +		str_yes_no(status & SHIM_IPCD_DONE), status);
>  	dev_err(sdev->dev,
>  		"error: mask DSP: pending %s complete %s raw 0x%llx\n",
> -		(imrd & SHIM_IMRD_BUSY) ? "yes" : "no",
> -		(imrd & SHIM_IMRD_DONE) ? "yes" : "no", imrd);
> +		str_yes_no(imrd & SHIM_IMRD_BUSY),
> +		str_yes_no(imrd & SHIM_IMRD_DONE), imrd);
>  
>  }
>  EXPORT_SYMBOL_NS(atom_dump, "SND_SOC_SOF_INTEL_ATOM_HIFI_EP");

-- 
Péter