sched_ext: idle: use assign_cpu() to update the idle cpumask

[PATCH sched_ext/for-6.14] sched_ext: idle: use assign_cpu() to update the idle cpumask

Andrea Righi posted 1 patch 1 year, 4 months ago

Download mbox

kernel/sched/ext.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

Expand all Fold all

[PATCH sched_ext/for-6.14] sched_ext: idle: use assign_cpu() to update the idle cpumask

Posted by Andrea Righi 1 year, 4 months ago

Use the assign_cpu() helper to set or clear the CPU in the idle mask,
based on the idle condition.

Acked-by: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
 kernel/sched/ext.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 7b229a4fb083..eec4716de225 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -3654,10 +3654,7 @@ void __scx_update_idle(struct rq *rq, bool idle)
 			return;
 	}
 
-	if (idle)
-		cpumask_set_cpu(cpu, idle_masks.cpu);
-	else
-		cpumask_clear_cpu(cpu, idle_masks.cpu);
+	assign_cpu(cpu, idle_masks.cpu, idle);
 
 #ifdef CONFIG_SCHED_SMT
 	if (sched_smt_active()) {
-- 
2.47.1

Re: [PATCH sched_ext/for-6.14] sched_ext: idle: use assign_cpu() to update the idle cpumask

Posted by Tejun Heo 1 year, 4 months ago

On Sat, Dec 28, 2024 at 11:02:50AM +0100, Andrea Righi wrote:
> Use the assign_cpu() helper to set or clear the CPU in the idle mask,
> based on the idle condition.
> 
> Acked-by: Yury Norov <yury.norov@gmail.com>
> Signed-off-by: Andrea Righi <arighi@nvidia.com>

Applied to sched_ext/for-6.14.

Thanks.

-- 
tejun