KVM: SVM: Use str_enabled_disabled() helper in sev_hardware_setup()

[PATCH] KVM: SVM: Use str_enabled_disabled() helper in sev_hardware_setup()

Posted by Thorsten Blum 1 year, 1 month ago

Remove hard-coded strings by using the str_enabled_disabled() helper
function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/x86/kvm/svm/sev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
index 943bd074a5d3..87ed8cde68a7 100644
--- a/arch/x86/kvm/svm/sev.c
+++ b/arch/x86/kvm/svm/sev.c
@@ -3051,11 +3051,11 @@ void __init sev_hardware_setup(void)
 			min_sev_asid, max_sev_asid);
 	if (boot_cpu_has(X86_FEATURE_SEV_ES))
 		pr_info("SEV-ES %s (ASIDs %u - %u)\n",
-			sev_es_supported ? "enabled" : "disabled",
+			str_enabled_disabled(sev_es_supported),
 			min_sev_asid > 1 ? 1 : 0, min_sev_asid - 1);
 	if (boot_cpu_has(X86_FEATURE_SEV_SNP))
 		pr_info("SEV-SNP %s (ASIDs %u - %u)\n",
-			sev_snp_supported ? "enabled" : "disabled",
+			str_enabled_disabled(sev_snp_supported),
 			min_sev_asid > 1 ? 1 : 0, min_sev_asid - 1);
 
 	sev_enabled = sev_supported;
-- 
2.47.1

Re: [PATCH] KVM: SVM: Use str_enabled_disabled() helper in sev_hardware_setup()

Posted by Sean Christopherson 1 year ago

On Fri, 27 Dec 2024 10:44:51 +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.

Applied to kvm-x86 svm, thanks!

[1/1] KVM: SVM: Use str_enabled_disabled() helper in sev_hardware_setup()
      https://github.com/kvm-x86/linux/commit/800173cf7560

--
https://github.com/kvm-x86/linux/tree/next

Re: [PATCH] KVM: SVM: Use str_enabled_disabled() helper in sev_hardware_setup()

Posted by Paluri, PavanKumar 1 year, 1 month ago


On 12/27/2024 3:44 AM, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

LGTM.

Reviewed-by: Pavan Kumar Paluri <papaluri@amd.com>
> ---
>  arch/x86/kvm/svm/sev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 943bd074a5d3..87ed8cde68a7 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -3051,11 +3051,11 @@ void __init sev_hardware_setup(void)
>  			min_sev_asid, max_sev_asid);
>  	if (boot_cpu_has(X86_FEATURE_SEV_ES))
>  		pr_info("SEV-ES %s (ASIDs %u - %u)\n",
> -			sev_es_supported ? "enabled" : "disabled",
> +			str_enabled_disabled(sev_es_supported),
>  			min_sev_asid > 1 ? 1 : 0, min_sev_asid - 1);
>  	if (boot_cpu_has(X86_FEATURE_SEV_SNP))
>  		pr_info("SEV-SNP %s (ASIDs %u - %u)\n",
> -			sev_snp_supported ? "enabled" : "disabled",
> +			str_enabled_disabled(sev_snp_supported),
>  			min_sev_asid > 1 ? 1 : 0, min_sev_asid - 1);
>  
>  	sev_enabled = sev_supported;

Re: [PATCH] KVM: SVM: Use str_enabled_disabled() helper in sev_hardware_setup()

Posted by Nikunj A Dadhania 1 year, 1 month ago

On 12/27/2024 3:14 PM, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Looks good to me.

Reviewed-by: Nikunj A Dadhania <nikunj@amd.com>

> ---
>  arch/x86/kvm/svm/sev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 943bd074a5d3..87ed8cde68a7 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -3051,11 +3051,11 @@ void __init sev_hardware_setup(void)
>  			min_sev_asid, max_sev_asid);
>  	if (boot_cpu_has(X86_FEATURE_SEV_ES))
>  		pr_info("SEV-ES %s (ASIDs %u - %u)\n",
> -			sev_es_supported ? "enabled" : "disabled",
> +			str_enabled_disabled(sev_es_supported),
>  			min_sev_asid > 1 ? 1 : 0, min_sev_asid - 1);
>  	if (boot_cpu_has(X86_FEATURE_SEV_SNP))
>  		pr_info("SEV-SNP %s (ASIDs %u - %u)\n",
> -			sev_snp_supported ? "enabled" : "disabled",
> +			str_enabled_disabled(sev_snp_supported),
>  			min_sev_asid > 1 ? 1 : 0, min_sev_asid - 1);
>  
>  	sev_enabled = sev_supported;