From: Keke Li <keke.li@amlogic.com>
c3-mipi-csi2 is used to receive mipi data from image sensor.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Keke Li <keke.li@amlogic.com>
---
.../bindings/media/amlogic,c3-mipi-csi2.yaml | 131 +++++++++++++++++++++
MAINTAINERS | 6 +
2 files changed, 137 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml
new file mode 100644
index 000000000000..76b68d1e7316
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml
@@ -0,0 +1,131 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic C3 MIPI CSI-2 receiver
+
+maintainers:
+ - Keke Li <keke.li@amlogic.com>
+
+description:
+ MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller.
+ It receives the MIPI data from the image sensor and sends MIPI data
+ to MIPI adapter.
+
+properties:
+ compatible:
+ enum:
+ - amlogic,c3-mipi-csi2
+
+ reg:
+ maxItems: 3
+
+ reg-names:
+ items:
+ - const: aphy
+ - const: dphy
+ - const: host
+
+ power-domains:
+ maxItems: 1
+
+ clocks:
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: vapb
+ - const: phy0
+
+ assigned-clocks: true
+
+ assigned-clock-rates: true
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: input port node, connected to sensor.
+
+ properties:
+ endpoint:
+ $ref: video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ minItems: 1
+ maxItems: 4
+
+ required:
+ - data-lanes
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: output port node
+
+ required:
+ - port@0
+ - port@1
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - power-domains
+ - clocks
+ - clock-names
+ - ports
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h>
+ #include <dt-bindings/power/amlogic,c3-pwrc.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ csi: csi@ff018000 {
+ compatible = "amlogic,c3-mipi-csi2";
+ reg = <0x0 0xff018000 0x0 0x400>,
+ <0x0 0xff019000 0x0 0x300>,
+ <0x0 0xff01a000 0x0 0x100>;
+ reg-names = "aphy", "dphy", "host";
+ power-domains = <&pwrc PWRC_C3_MIPI_ISP_WRAP_ID>;
+ clocks = <&clkc_periphs CLKID_VAPB>,
+ <&clkc_periphs CLKID_CSI_PHY0>;
+ clock-names = "vapb", "phy0";
+ assigned-clocks = <&clkc_periphs CLKID_VAPB>,
+ <&clkc_periphs CLKID_CSI_PHY0>;
+ assigned-clock-rates = <0>, <200000000>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ c3_mipi_csi_in: endpoint {
+ remote-endpoint = <&imx290_out>;
+ data-lanes = <1 2 3 4>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ c3_mipi_csi_out: endpoint {
+ remote-endpoint = <&c3_adap_in>;
+ };
+ };
+ };
+ };
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index d2ab799a0659..2b06962db506 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1243,6 +1243,12 @@ F: Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml
F: drivers/perf/amlogic/
F: include/soc/amlogic/
+AMLOGIC MIPI CSI2 DRIVER
+M: Keke Li <keke.li@amlogic.com>
+L: linux-media@vger.kernel.org
+S: Maintained
+F: Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml
+
AMLOGIC RTC DRIVER
M: Yiting Deng <yiting.deng@amlogic.com>
M: Xianwei Zhao <xianwei.zhao@amlogic.com>
--
2.47.1On 27/12/2024 08:09, Keke Li via B4 Relay wrote: > From: Keke Li <keke.li@amlogic.com> > > c3-mipi-csi2 is used to receive mipi data from image sensor. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Keke Li <keke.li@amlogic.com> > --- > .../bindings/media/amlogic,c3-mipi-csi2.yaml | 131 +++++++++++++++++++++ > MAINTAINERS | 6 + > 2 files changed, 137 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml > new file mode 100644 > index 000000000000..76b68d1e7316 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml > @@ -0,0 +1,131 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic C3 MIPI CSI-2 receiver > + > +maintainers: > + - Keke Li <keke.li@amlogic.com> > + > +description: > + MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller. > + It receives the MIPI data from the image sensor and sends MIPI data > + to MIPI adapter. > + > +properties: > + compatible: > + enum: > + - amlogic,c3-mipi-csi2 > + > + reg: > + maxItems: 3 > + > + reg-names: > + items: > + - const: aphy > + - const: dphy > + - const: host > + > + power-domains: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: vapb > + - const: phy0 > + > + assigned-clocks: true > + > + assigned-clock-rates: true NAK Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak whatever crap past reviewers. Drop all new properties and drop my review tag. Best regards, Krzysztof
Hi Krzysztof Thanks for your reply On 2024/12/27 15:19, Krzysztof Kozlowski wrote: > [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > [ EXTERNAL EMAIL ] > > On 27/12/2024 08:09, Keke Li via B4 Relay wrote: >> From: Keke Li <keke.li@amlogic.com> >> >> c3-mipi-csi2 is used to receive mipi data from image sensor. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Keke Li <keke.li@amlogic.com> >> --- >> .../bindings/media/amlogic,c3-mipi-csi2.yaml | 131 +++++++++++++++++++++ >> MAINTAINERS | 6 + >> 2 files changed, 137 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml >> new file mode 100644 >> index 000000000000..76b68d1e7316 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml >> @@ -0,0 +1,131 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic C3 MIPI CSI-2 receiver >> + >> +maintainers: >> + - Keke Li <keke.li@amlogic.com> >> + >> +description: >> + MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller. >> + It receives the MIPI data from the image sensor and sends MIPI data >> + to MIPI adapter. >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,c3-mipi-csi2 >> + >> + reg: >> + maxItems: 3 >> + >> + reg-names: >> + items: >> + - const: aphy >> + - const: dphy >> + - const: host >> + >> + power-domains: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 2 >> + >> + clock-names: >> + items: >> + - const: vapb >> + - const: phy0 >> + >> + assigned-clocks: true >> + >> + assigned-clock-rates: true > NAK > > Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak > whatever crap past reviewers. > > Drop all new properties and drop my review tag. OK, will drop all new properties and drop your review tag. Thanks > > Best regards, > Krzysztof
Hi Keke, Krzysztof On Fri, Dec 27, 2024 at 03:38:14PM +0800, Keke Li wrote: > Hi Krzysztof > > Thanks for your reply > > On 2024/12/27 15:19, Krzysztof Kozlowski wrote: > > [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > > > [ EXTERNAL EMAIL ] > > > > On 27/12/2024 08:09, Keke Li via B4 Relay wrote: > > > From: Keke Li <keke.li@amlogic.com> > > > > > > c3-mipi-csi2 is used to receive mipi data from image sensor. > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Signed-off-by: Keke Li <keke.li@amlogic.com> > > > --- > > > .../bindings/media/amlogic,c3-mipi-csi2.yaml | 131 +++++++++++++++++++++ > > > MAINTAINERS | 6 + > > > 2 files changed, 137 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml > > > new file mode 100644 > > > index 000000000000..76b68d1e7316 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml > > > @@ -0,0 +1,131 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Amlogic C3 MIPI CSI-2 receiver > > > + > > > +maintainers: > > > + - Keke Li <keke.li@amlogic.com> > > > + > > > +description: > > > + MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller. > > > + It receives the MIPI data from the image sensor and sends MIPI data > > > + to MIPI adapter. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - amlogic,c3-mipi-csi2 > > > + > > > + reg: > > > + maxItems: 3 > > > + > > > + reg-names: > > > + items: > > > + - const: aphy > > > + - const: dphy > > > + - const: host > > > + > > > + power-domains: > > > + maxItems: 1 > > > + > > > + clocks: > > > + maxItems: 2 > > > + > > > + clock-names: > > > + items: > > > + - const: vapb > > > + - const: phy0 > > > + > > > + assigned-clocks: true > > > + > > > + assigned-clock-rates: true > > NAK > > > > Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak > > whatever crap past reviewers. > > > > Drop all new properties and drop my review tag. > > > OK, will drop all new properties and drop your review tag. Thanks > Krzysztof why should new properties added in-between two revisions be dropped ? I understand the "drop my tag if you make changes" but I don't get why the newly added properties should be removed. > > > > Best regards, > > Krzysztof >
On 22/01/2025 14:36, Jacopo Mondi wrote: >>>> + assigned-clocks: true >>>> + >>>> + assigned-clock-rates: true >>> NAK >>> >>> Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak >>> whatever crap past reviewers. >>> >>> Drop all new properties and drop my review tag. >> >> >> OK, will drop all new properties and drop your review tag. Thanks >> > > Krzysztof why should new properties added in-between two revisions be > dropped ? You connected two independent issues. It is not that some new properties should be dropped, because I don't like new stuff. It's that these two particular properties - added in this version, but that's coincidence - are not appropriate and should be dropped because of that reason: not appropriateness. > > I understand the "drop my tag if you make changes" but I don't get why > the newly added properties should be removed. They are neither needed, nor beneficial. Core schema provides them. Best regards, Krzysztof
Hi Krzysztof On Wed, Jan 22, 2025 at 02:48:07PM +0100, Krzysztof Kozlowski wrote: > On 22/01/2025 14:36, Jacopo Mondi wrote: > >>>> + assigned-clocks: true > >>>> + > >>>> + assigned-clock-rates: true > >>> NAK > >>> > >>> Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak > >>> whatever crap past reviewers. > >>> > >>> Drop all new properties and drop my review tag. > >> > >> > >> OK, will drop all new properties and drop your review tag. Thanks > >> > > > > Krzysztof why should new properties added in-between two revisions be > > dropped ? > > You connected two independent issues. Well, it seems Keke did as well: > >> OK, will drop all new properties and drop your review tag. Thanks If new properties get removed, the tag can then stay, right ? > It is not that some new properties should be dropped, because I don't > like new stuff. It's that these two particular properties - added in > this version, but that's coincidence - are not appropriate and should be > dropped because of that reason: not appropriateness. > > > > > I understand the "drop my tag if you make changes" but I don't get why > > the newly added properties should be removed. > > They are neither needed, nor beneficial. Core schema provides them. > Ok, this is the bit I was missing. I thought that having additionalProperties: false in the schema means that properties not explicitly listed are not valid, but schema validation passes without specifying the two properties, so yeah, these should be dropped. > Best regards, > Krzysztof
© 2016 - 2026 Red Hat, Inc.