[v1] auxdisplay: panel: replace struct with union for display configuration

[PATCH] auxdisplay: panel: replace struct with union for display configuration

Atharva Tiwari posted 1 patch 1 year, 1 month ago

Diff against v1
Download mbox

drivers/auxdisplay/panel.c | 1 +--
1 file changed, 1 deletions(-)

Expand all Fold all

[PATCH] auxdisplay: panel: replace struct with union for display configuration

Posted by Atharva Tiwari 1 year, 1 month ago

Well as you said it was better to just remove the todo that just what i
did :)

Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
---
 drivers/auxdisplay/panel.c | 1 +--
 1 file changed, 1 deletions(-)

diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index a731f28455b4..4662f763dac7 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -204,8 +204,7 @@ static struct {
 	int charset;
 	int proto;
 
-	/* TODO: use union here? */
 		int e;
 		int rs;
 		int rw;
-- 
2.39.5

Re: [PATCH] auxdisplay: panel: replace struct with union for display configuration

Posted by Andy Shevchenko 1 year, 1 month ago

On Wed, Dec 25, 2024 at 8:06 PM Atharva Tiwari <evepolonium@gmail.com> wrote:
>
> Well as you said it was better to just remove the todo that just what i
> did :)

Please, follow the "Submitting Patches" and "Linux Kernel patch
submission checklist" documentation and try again after studying that.

-- 
With Best Regards,
Andy Shevchenko