[PATCH] workqueue: add printf attribute to __alloc_workqueue()

Su Hui posted 1 patch 1 year, 1 month ago
kernel/workqueue.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] workqueue: add printf attribute to __alloc_workqueue()
Posted by Su Hui 1 year, 1 month ago
Fix a compiler warning with W=1:
kernel/workqueue.c: error:
function ‘__alloc_workqueue’ might be a candidate for ‘gnu_printf’
format attribute[-Werror=suggest-attribute=format]
 5657 |  name_len = vsnprintf(wq->name, sizeof(wq->name), fmt, args);
      |  ^~~~~~~~

Fixes: 9b59a85a84dc ("workqueue: Don't call va_start / va_end twice")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
 kernel/workqueue.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 8b07576814a5..0c752812ae09 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -5641,6 +5641,7 @@ static void wq_adjust_max_active(struct workqueue_struct *wq)
 	} while (activated);
 }
 
+__printf(1, 0)
 static struct workqueue_struct *__alloc_workqueue(const char *fmt,
 						  unsigned int flags,
 						  int max_active, va_list args)
-- 
2.30.2

Re: [PATCH] workqueue: add printf attribute to __alloc_workqueue()
Posted by Tejun Heo 1 year, 1 month ago
On Tue, Dec 24, 2024 at 12:43:58PM +0800, Su Hui wrote:
> Fix a compiler warning with W=1:
> kernel/workqueue.c: error:
> function ‘__alloc_workqueue’ might be a candidate for ‘gnu_printf’
> format attribute[-Werror=suggest-attribute=format]
>  5657 |  name_len = vsnprintf(wq->name, sizeof(wq->name), fmt, args);
>       |  ^~~~~~~~
> 
> Fixes: 9b59a85a84dc ("workqueue: Don't call va_start / va_end twice")
> Signed-off-by: Su Hui <suhui@nfschina.com>

Applied to wq/for-6.13-fixes.

Thanks.

-- 
tejun