arm64: dts: qcom: qcs8300: add QCrypto nodes

[PATCH v3] arm64: dts: qcom: qcs8300: add QCrypto nodes

Posted by Yuvaraj Ranganathan 1 year, 1 month ago

Add the QCE and Crypto BAM DMA nodes.

Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com>
---
Changes in v3:
 - Wrap the lengthy lines
 - Reduced the patch series as other patch is merged.
 - Link to v2: https://lore.kernel.org/all/20241125111923.2218374-3-quic_yrangana@quicinc.com/

Changes in v2:
 - Set the interconnect tag to QCOM_ICC_TAG_ALWAYS instead of passing 0(no TAG). 
 - Link to v1:  https://lore.kernel.org/all/20241113055830.2918347-1-quic_yrangana@quicinc.com/

---
 arch/arm64/boot/dts/qcom/qcs8300.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
index 73abf2ef9c9f..30c1de1c4ad2 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
@@ -736,6 +736,31 @@ ufs_mem_phy: phy@1d87000 {
 			status = "disabled";
 		};
 
+		cryptobam: dma-controller@1dc4000 {
+			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+			reg = <0x0 0x01dc4000 0x0 0x28000>;
+			interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			qcom,ee = <0>;
+			qcom,controlled-remotely;
+			num-channels = <20>;
+			qcom,num-ees = <4>;
+			iommus = <&apps_smmu 0x480 0x00>,
+				 <&apps_smmu 0x481 0x00>;
+		};
+
+		crypto: crypto@1dfa000 {
+			compatible = "qcom,qcs8300-qce", "qcom,qce";
+			reg = <0x0 0x01dfa000 0x0 0x6000>;
+			dmas = <&cryptobam 4>, <&cryptobam 5>;
+			dma-names = "rx", "tx";
+			iommus = <&apps_smmu 0x480 0x00>,
+				 <&apps_smmu 0x481 0x00>;
+			interconnects = <&aggre2_noc MASTER_CRYPTO_CORE0 QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+			interconnect-names = "memory";
+		};
+
 		tcsr_mutex: hwlock@1f40000 {
 			compatible = "qcom,tcsr-mutex";
 			reg = <0x0 0x01f40000 0x0 0x20000>;
-- 
2.34.1

Re: [PATCH v3] arm64: dts: qcom: qcs8300: add QCrypto nodes

Posted by Rob Herring 1 year ago

On Mon, Dec 23, 2024 at 5:09 AM Yuvaraj Ranganathan
<quic_yrangana@quicinc.com> wrote:
>
> Add the QCE and Crypto BAM DMA nodes.
>
> Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com>
> ---
> Changes in v3:
>  - Wrap the lengthy lines
>  - Reduced the patch series as other patch is merged.
>  - Link to v2: https://lore.kernel.org/all/20241125111923.2218374-3-quic_yrangana@quicinc.com/
>
> Changes in v2:
>  - Set the interconnect tag to QCOM_ICC_TAG_ALWAYS instead of passing 0(no TAG).
>  - Link to v1:  https://lore.kernel.org/all/20241113055830.2918347-1-quic_yrangana@quicinc.com/
>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300.dtsi | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> index 73abf2ef9c9f..30c1de1c4ad2 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> @@ -736,6 +736,31 @@ ufs_mem_phy: phy@1d87000 {
>                         status = "disabled";
>                 };
>
> +               cryptobam: dma-controller@1dc4000 {
> +                       compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> +                       reg = <0x0 0x01dc4000 0x0 0x28000>;
> +                       interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
> +                       #dma-cells = <1>;
> +                       qcom,ee = <0>;
> +                       qcom,controlled-remotely;
> +                       num-channels = <20>;
> +                       qcom,num-ees = <4>;
> +                       iommus = <&apps_smmu 0x480 0x00>,
> +                                <&apps_smmu 0x481 0x00>;
> +               };
> +
> +               crypto: crypto@1dfa000 {
> +                       compatible = "qcom,qcs8300-qce", "qcom,qce";

This doesn't match what the schema says.

You didn't test your schema change with this. That's the *whole* point
of the schemas...

Rob

Re: [PATCH v3] arm64: dts: qcom: qcs8300: add QCrypto nodes

Posted by Bjorn Andersson 1 year, 1 month ago

On Mon, 23 Dec 2024 16:39:36 +0530, Yuvaraj Ranganathan wrote:
> Add the QCE and Crypto BAM DMA nodes.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: qcs8300: add QCrypto nodes
      commit: a86d844099474acf59cfb45f4590800ae4d9365e

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v3] arm64: dts: qcom: qcs8300: add QCrypto nodes

Posted by Krzysztof Kozlowski 1 year ago

On 26/12/2024 19:27, Bjorn Andersson wrote:
> 
> On Mon, 23 Dec 2024 16:39:36 +0530, Yuvaraj Ranganathan wrote:
>> Add the QCE and Crypto BAM DMA nodes.
>>
>>
> 
> Applied, thanks!
> 
> [1/1] arm64: dts: qcom: qcs8300: add QCrypto nodes
>       commit: a86d844099474acf59cfb45f4590800ae4d9365e
So this was applied 3 weeks ago, but Yuvaraj did not come ever with any
testing or fix... So maybe the way is to revert patches which were never
tested?

Best regards,
Krzysztof

Re: [PATCH v3] arm64: dts: qcom: qcs8300: add QCrypto nodes

Posted by Konrad Dybcio 1 year, 1 month ago

On 23.12.2024 12:09 PM, Yuvaraj Ranganathan wrote:
> Add the QCE and Crypto BAM DMA nodes.
> 
> Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad