.../gpib/agilent_82350b/agilent_82350b.c | 21 +++- .../gpib/agilent_82357a/agilent_82357a.c | 13 ++- drivers/staging/gpib/cb7210/cb7210.c | 96 ++++++++++++++----- drivers/staging/gpib/cec/cec_gpib.c | 12 +-- drivers/staging/gpib/common/gpib_os.c | 7 +- drivers/staging/gpib/eastwood/fluke_gpib.c | 28 ++++-- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 45 ++++++--- drivers/staging/gpib/gpio/gpib_bitbang.c | 6 +- drivers/staging/gpib/hp_82335/hp82335.c | 8 +- drivers/staging/gpib/hp_82341/hp_82341.c | 14 ++- drivers/staging/gpib/include/gpibP.h | 2 +- drivers/staging/gpib/ines/ines_gpib.c | 78 ++++++++++----- .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 6 +- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 13 ++- drivers/staging/gpib/pc2/pc2_gpib.c | 30 +++++- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 87 +++++++++++++---- 16 files changed, 355 insertions(+), 111 deletions(-)
The function gpib_register_driver() can fail when kmalloc()
fails but it does not return an error code.
The function pcmcia_register_driver() returns an error code but
most of the times is not handled in gpib.
Modify gpid_register_driver() to return appropriate error code
and also handle the error code returned by pcmcia_register_driver()
incase it fails. When any of these functions fail unwind and
unregister the driver to avoid semi-registered system.
This issue was reported by Coverity Scan.
Report:
CID 1635894: (#1 of 1): 'Constant' variable guards dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return -1;.
Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com>
---
v2 --> v3 : Modified the gpib_register_driver() to return error code,
added error handling to all the places that the
gpib_register_driver() is called.
v1 --> v2 : Replaced the redundant cb_pcmcia_init_module() with
pcmcia_register_driver().
Link to v1 : https://lore.kernel.org/all/20241221022632.20931-1-niharchaithanya@gmail.com/
Link to v2 : https://lore.kernel.org/all/20241221091121.35476-1-niharchaithanya@gmail.com/
---
.../gpib/agilent_82350b/agilent_82350b.c | 21 +++-
.../gpib/agilent_82357a/agilent_82357a.c | 13 ++-
drivers/staging/gpib/cb7210/cb7210.c | 96 ++++++++++++++-----
drivers/staging/gpib/cec/cec_gpib.c | 12 +--
drivers/staging/gpib/common/gpib_os.c | 7 +-
drivers/staging/gpib/eastwood/fluke_gpib.c | 28 ++++--
drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 45 ++++++---
drivers/staging/gpib/gpio/gpib_bitbang.c | 6 +-
drivers/staging/gpib/hp_82335/hp82335.c | 8 +-
drivers/staging/gpib/hp_82341/hp_82341.c | 14 ++-
drivers/staging/gpib/include/gpibP.h | 2 +-
drivers/staging/gpib/ines/ines_gpib.c | 78 ++++++++++-----
.../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 6 +-
drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 13 ++-
drivers/staging/gpib/pc2/pc2_gpib.c | 30 +++++-
drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 87 +++++++++++++----
16 files changed, 355 insertions(+), 111 deletions(-)
diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
index 53006d0cc79c..39420f2b0b32 100644
--- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
+++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
@@ -909,14 +909,25 @@ static int __init agilent_82350b_init_module(void)
int result;
result = pci_register_driver(&agilent_82350b_pci_driver);
- if (result) {
- pr_err("agilent_82350b: pci_driver_register failed!\n");
+ if (result)
return result;
- }
- gpib_register_driver(&agilent_82350b_unaccel_interface, THIS_MODULE);
- gpib_register_driver(&agilent_82350b_interface, THIS_MODULE);
+ result = gpib_register_driver(&agilent_82350b_unaccel_interface, THIS_MODULE);
+ if (result)
+ goto err_unaccel;
+
+ result = gpib_register_driver(&agilent_82350b_interface, THIS_MODULE);
+ if (result)
+ goto err_interface;
+
return 0;
+
+err_interface:
+ gpib_unregister_driver(&agilent_82350b_unaccel_interface);
+err_unaccel:
+ pci_unregister_driver(&agilent_82350b_pci_driver);
+
+ return result;
}
static void __exit agilent_82350b_exit_module(void)
diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
index bf05fb4a736b..60311ce8d164 100644
--- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
+++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
@@ -1691,14 +1691,21 @@ static struct usb_driver agilent_82357a_bus_driver = {
static int __init agilent_82357a_init_module(void)
{
int i;
+ int ret = 0;
pr_info("agilent_82357a_gpib driver loading");
for (i = 0; i < MAX_NUM_82357A_INTERFACES; ++i)
agilent_82357a_driver_interfaces[i] = NULL;
- usb_register(&agilent_82357a_bus_driver);
- gpib_register_driver(&agilent_82357a_gpib_interface, THIS_MODULE);
- return 0;
+ ret = usb_register(&agilent_82357a_bus_driver);
+ if (ret)
+ return ret;
+
+ ret = gpib_register_driver(&agilent_82357a_gpib_interface, THIS_MODULE);
+ if (ret)
+ usb_deregister(&agilent_82357a_bus_driver);
+
+ return ret;
}
static void __exit agilent_82357a_exit_module(void)
diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
index 63df7f3eb3f3..f34654262b78 100644
--- a/drivers/staging/gpib/cb7210/cb7210.c
+++ b/drivers/staging/gpib/cb7210/cb7210.c
@@ -1353,7 +1353,11 @@ static struct pcmcia_driver cb_gpib_cs_driver = {
int cb_pcmcia_init_module(void)
{
- pcmcia_register_driver(&cb_gpib_cs_driver);
+ int ret;
+
+ ret = pcmcia_register_driver(&cb_gpib_cs_driver);
+ if (ret < 0)
+ pr_err("cb_gpib_cs: pcmcia_register_driver failed\n");
return 0;
}
@@ -1506,32 +1510,80 @@ void cb_pcmcia_detach(gpib_board_t *board)
static int __init cb7210_init_module(void)
{
- int err = 0;
- int result;
+ int ret;
- result = pci_register_driver(&cb7210_pci_driver);
- if (result) {
- pr_err("cb7210: pci_driver_register failed!\n");
- return result;
- }
+ ret = pci_register_driver(&cb7210_pci_driver);
+ if (ret)
+ return ret;
+
+ ret = gpib_register_driver(&cb_pci_interface, THIS_MODULE);
+ if (ret)
+ goto err_pci;
+
+ ret = gpib_register_driver(&cb_isa_interface, THIS_MODULE);
+ if (ret)
+ goto err_isa;
+
+ ret = gpib_register_driver(&cb_pci_accel_interface, THIS_MODULE);
+ if (ret)
+ goto err_pci_accel;
+
+ ret = gpib_register_driver(&cb_pci_unaccel_interface, THIS_MODULE);
+ if (ret)
+ goto err_pci_unaccel;
+
+ ret = gpib_register_driver(&cb_isa_accel_interface, THIS_MODULE);
+ if (ret)
+ goto err_isa_accel;
- gpib_register_driver(&cb_pci_interface, THIS_MODULE);
- gpib_register_driver(&cb_isa_interface, THIS_MODULE);
- gpib_register_driver(&cb_pci_accel_interface, THIS_MODULE);
- gpib_register_driver(&cb_pci_unaccel_interface, THIS_MODULE);
- gpib_register_driver(&cb_isa_accel_interface, THIS_MODULE);
- gpib_register_driver(&cb_isa_unaccel_interface, THIS_MODULE);
-
-#ifdef GPIB__PCMCIA
- gpib_register_driver(&cb_pcmcia_interface, THIS_MODULE);
- gpib_register_driver(&cb_pcmcia_accel_interface, THIS_MODULE);
- gpib_register_driver(&cb_pcmcia_unaccel_interface, THIS_MODULE);
- err += cb_pcmcia_init_module();
+ ret = gpib_register_driver(&cb_isa_unaccel_interface, THIS_MODULE);
+ if (ret)
+ goto err_isa_unaccel;
+
+#ifdef GPIB_PCMCIA
+ ret = gpib_register_driver(&cb_pcmcia_interface, THIS_MODULE);
+ if (ret)
+ goto err_pcmcia;
+
+ ret = gpib_register_driver(&cb_pcmcia_accel_interface, THIS_MODULE);
+ if (ret)
+ goto err_pcmcia_accel;
+
+ ret = gpib_register_driver(&cb_pcmcia_unaccel_interface, THIS_MODULE);
+ if (ret)
+ goto err_pcmcia_unaccel;
+
+ ret = pcmcia_register_driver(&cb_gpib_cs_driver);
+ if (ret)
+ goto err_pcmcia_driver;
#endif
- if (err)
- return -1;
return 0;
+
+#ifdef GPIB_PCMCIA
+err_pcmcia_driver:
+ gpib_unregister_driver(&cb_pcmcia_unaccel_interface);
+err_pcmcia_unaccel:
+ gpib_unregister_driver(&cb_pcmcia_accel_interface);
+err_pcmcia_accel:
+ gpib_unregister_driver(&cb_pcmcia_interface);
+err_pcmcia:
+#endif
+ gpib_unregister_driver(&cb_isa_unaccel_interface);
+err_isa_unaccel:
+ gpib_unregister_driver(&cb_isa_accel_interface);
+err_isa_accel:
+ gpib_unregister_driver(&cb_pci_unaccel_interface);
+err_pci_unaccel:
+ gpib_unregister_driver(&cb_pci_accel_interface);
+err_pci_accel:
+ gpib_unregister_driver(&cb_isa_interface);
+err_isa:
+ gpib_unregister_driver(&cb_pci_interface);
+err_pci:
+ pci_unregister_driver(&cb7210_pci_driver);
+
+ return ret;
}
static void __exit cb7210_exit_module(void)
diff --git a/drivers/staging/gpib/cec/cec_gpib.c b/drivers/staging/gpib/cec/cec_gpib.c
index 3dc933deb401..ffa366c30ac5 100644
--- a/drivers/staging/gpib/cec/cec_gpib.c
+++ b/drivers/staging/gpib/cec/cec_gpib.c
@@ -361,17 +361,17 @@ static struct pci_driver cec_pci_driver = {
static int __init cec_init_module(void)
{
- int result;
+ int result = 0;
result = pci_register_driver(&cec_pci_driver);
- if (result) {
- pr_err("cec_gpib: pci_driver_register failed!\n");
+ if (result)
return result;
- }
- gpib_register_driver(&cec_pci_interface, THIS_MODULE);
+ result = gpib_register_driver(&cec_pci_interface, THIS_MODULE);
+ if (result)
+ pci_unregister_driver(&cec_pci_driver);
- return 0;
+ return result;
}
static void cec_exit_module(void)
diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/common/gpib_os.c
index 405237d8cb47..07795df3b721 100644
--- a/drivers/staging/gpib/common/gpib_os.c
+++ b/drivers/staging/gpib/common/gpib_os.c
@@ -2094,18 +2094,19 @@ void init_gpib_descriptor(gpib_descriptor_t *desc)
atomic_set(&desc->io_in_progress, 0);
}
-void gpib_register_driver(gpib_interface_t *interface, struct module *provider_module)
+int gpib_register_driver(gpib_interface_t *interface, struct module *provider_module)
{
struct gpib_interface_list_struct *entry;
entry = kmalloc(sizeof(*entry), GFP_KERNEL);
if (!entry)
- return;
+ return -ENOMEM;
entry->interface = interface;
entry->module = provider_module;
list_add(&entry->list, ®istered_drivers);
- pr_info("gpib: registered %s interface\n", interface->name);
+
+ return 0;
}
EXPORT_SYMBOL(gpib_register_driver);
diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
index 3f938ab0c84d..2efc0226ec2b 100644
--- a/drivers/staging/gpib/eastwood/fluke_gpib.c
+++ b/drivers/staging/gpib/eastwood/fluke_gpib.c
@@ -1154,17 +1154,31 @@ static int __init fluke_init_module(void)
int result;
result = platform_driver_register(&fluke_gpib_platform_driver);
- if (result) {
- pr_err("fluke_gpib: platform_driver_register failed!\n");
+ if (result)
return result;
- }
- gpib_register_driver(&fluke_unaccel_interface, THIS_MODULE);
- gpib_register_driver(&fluke_hybrid_interface, THIS_MODULE);
- gpib_register_driver(&fluke_interface, THIS_MODULE);
+ result = gpib_register_driver(&fluke_unaccel_interface, THIS_MODULE);
+ if (result)
+ goto err_unaccel;
+
+ result = gpib_register_driver(&fluke_hybrid_interface, THIS_MODULE);
+ if (result)
+ goto err_hybrid;
+
+ result = gpib_register_driver(&fluke_interface, THIS_MODULE);
+ if (result)
+ goto err_interface;
- pr_info("fluke_gpib\n");
return 0;
+
+err_interface:
+ gpib_unregister_driver(&fluke_hybrid_interface);
+err_hybrid:
+ gpib_unregister_driver(&fluke_unaccel_interface);
+err_unaccel:
+ platform_driver_unregister(&fluke_gpib_platform_driver);
+
+ return result;
}
static void __exit fluke_exit_module(void)
diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
index 62791db1c34a..5caca0223c66 100644
--- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
+++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
@@ -1690,24 +1690,43 @@ static int __init fmh_gpib_init_module(void)
int result;
result = platform_driver_register(&fmh_gpib_platform_driver);
- if (result) {
- pr_err("fmh_gpib: platform_driver_register failed!\n");
- return result;
- }
+ if (result)
+ goto err_platform_driver;
result = pci_register_driver(&fmh_gpib_pci_driver);
- if (result) {
- pr_err("fmh_gpib: pci_driver_register failed!\n");
- return result;
- }
+ if (result)
+ goto err_pci_driver;
+
+ result = gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE);
+ if (result)
+ goto err_unaccel;
+
+ result = gpib_register_driver(&fmh_gpib_interface, THIS_MODULE);
+ if (result)
+ goto err_interface;
+
+ result = gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE);
+ if (result)
+ goto err_pci_unaccel;
- gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE);
- gpib_register_driver(&fmh_gpib_interface, THIS_MODULE);
- gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE);
- gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE);
+ result = gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE);
+ if (result)
+ goto err_pci;
- pr_info("fmh_gpib\n");
return 0;
+
+err_pci:
+ gpib_unregister_driver(&fmh_gpib_pci_unaccel_interface);
+err_pci_unaccel:
+ gpib_unregister_driver(&fmh_gpib_interface);
+err_interface:
+ gpib_unregister_driver(&fmh_gpib_unaccel_interface);
+err_unaccel:
+ pci_unregister_driver(&fmh_gpib_pci_driver);
+err_pci_driver:
+ platform_driver_unregister(&fmh_gpib_platform_driver);
+
+ return result;
}
static void __exit fmh_gpib_exit_module(void)
diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpib/gpio/gpib_bitbang.c
index a2d562cbd65b..2f1fdb6f0802 100644
--- a/drivers/staging/gpib/gpio/gpib_bitbang.c
+++ b/drivers/staging/gpib/gpio/gpib_bitbang.c
@@ -1341,8 +1341,12 @@ return_to_local : bb_return_to_local,
static int __init bb_init_module(void)
{
- gpib_register_driver(&bb_interface, THIS_MODULE);
+ int result = gpib_register_driver(&bb_interface, THIS_MODULE);
+ if (result) {
+ gpib_unregister_driver(&bb_interface);
+ return result;
+ }
dbg_printk(0, "module loaded with pin map \"%s\"%s\n",
pin_map, (sn7516x_used) ? " and SN7516x driver support" : "");
return 0;
diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib/hp_82335/hp82335.c
index 40afe42aea47..1c44a865ad05 100644
--- a/drivers/staging/gpib/hp_82335/hp82335.c
+++ b/drivers/staging/gpib/hp_82335/hp82335.c
@@ -325,7 +325,13 @@ void hp82335_detach(gpib_board_t *board)
static int __init hp82335_init_module(void)
{
- gpib_register_driver(&hp82335_interface, THIS_MODULE);
+ int result = gpib_register_driver(&hp82335_interface, THIS_MODULE);
+
+ if (result) {
+ gpib_unregister_driver(&hp82335_interface);
+ return result;
+ }
+
return 0;
}
diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpib/hp_82341/hp_82341.c
index 8ad1c885a9fb..daf5f6e02bd5 100644
--- a/drivers/staging/gpib/hp_82341/hp_82341.c
+++ b/drivers/staging/gpib/hp_82341/hp_82341.c
@@ -807,9 +807,17 @@ MODULE_DEVICE_TABLE(pnp, hp_82341_pnp_table);
static int __init hp_82341_init_module(void)
{
- gpib_register_driver(&hp_82341_unaccel_interface, THIS_MODULE);
- gpib_register_driver(&hp_82341_interface, THIS_MODULE);
- return 0;
+ int ret = 0;
+
+ ret = gpib_register_driver(&hp_82341_unaccel_interface, THIS_MODULE);
+ if (ret)
+ return ret;
+
+ ret = gpib_register_driver(&hp_82341_interface, THIS_MODULE);
+ if (ret)
+ gpib_unregister_driver(&hp_82341_unaccel_interface);
+
+ return ret;
}
static void __exit hp_82341_exit_module(void)
diff --git a/drivers/staging/gpib/include/gpibP.h b/drivers/staging/gpib/include/gpibP.h
index 5fc42b645ab7..d0cd42c1a0ad 100644
--- a/drivers/staging/gpib/include/gpibP.h
+++ b/drivers/staging/gpib/include/gpibP.h
@@ -17,7 +17,7 @@
#include <linux/fs.h>
#include <linux/interrupt.h>
-void gpib_register_driver(gpib_interface_t *interface, struct module *mod);
+int gpib_register_driver(gpib_interface_t *interface, struct module *mod);
void gpib_unregister_driver(gpib_interface_t *interface);
struct pci_dev *gpib_pci_get_device(const gpib_board_config_t *config, unsigned int vendor_id,
unsigned int device_id, struct pci_dev *from);
diff --git a/drivers/staging/gpib/ines/ines_gpib.c b/drivers/staging/gpib/ines/ines_gpib.c
index 9d8387c3bf01..dda9205bfd97 100644
--- a/drivers/staging/gpib/ines/ines_gpib.c
+++ b/drivers/staging/gpib/ines/ines_gpib.c
@@ -1227,12 +1227,6 @@ static struct pcmcia_driver ines_gpib_cs_driver = {
.resume = ines_gpib_resume,
};
-int ines_pcmcia_init_module(void)
-{
- pcmcia_register_driver(&ines_gpib_cs_driver);
- return 0;
-}
-
void ines_pcmcia_cleanup_module(void)
{
DEBUG(0, "ines_cs: unloading\n");
@@ -1420,28 +1414,68 @@ void ines_pcmcia_detach(gpib_board_t *board)
static int __init ines_init_module(void)
{
- int err = 0;
+ int ret;
- err = pci_register_driver(&ines_pci_driver);
- if (err) {
- pr_err("ines_gpib: pci_driver_register failed!\n");
- return err;
- }
+ ret = pci_register_driver(&ines_pci_driver);
+ if (ret)
+ return ret;
+
+ ret = gpib_register_driver(&ines_pci_interface, THIS_MODULE);
+ if (ret)
+ goto err_pci;
+
+ ret = gpib_register_driver(&ines_pci_unaccel_interface, THIS_MODULE);
+ if (ret)
+ goto err_pci_unaccel;
+
+ ret = gpib_register_driver(&ines_pci_accel_interface, THIS_MODULE);
+ if (ret)
+ goto err_pci_accel;
+
+ ret = gpib_register_driver(&ines_isa_interface, THIS_MODULE);
+ if (ret)
+ goto err_isa;
- gpib_register_driver(&ines_pci_interface, THIS_MODULE);
- gpib_register_driver(&ines_pci_unaccel_interface, THIS_MODULE);
- gpib_register_driver(&ines_pci_accel_interface, THIS_MODULE);
- gpib_register_driver(&ines_isa_interface, THIS_MODULE);
#ifdef GPIB_PCMCIA
- gpib_register_driver(&ines_pcmcia_interface, THIS_MODULE);
- gpib_register_driver(&ines_pcmcia_unaccel_interface, THIS_MODULE);
- gpib_register_driver(&ines_pcmcia_accel_interface, THIS_MODULE);
- err += ines_pcmcia_init_module();
+ ret = gpib_register_driver(&ines_pcmcia_interface, THIS_MODULE);
+ if (ret)
+ goto err_pcmcia;
+
+ ret = gpib_register_driver(&ines_pcmcia_unaccel_interface, THIS_MODULE);
+ if (ret)
+ goto err_pcmcia_unaccel;
+
+ ret = gpib_register_driver(&ines_pcmcia_accel_interface, THIS_MODULE);
+ if (ret)
+ goto err_pcmcia_accel;
+
+ ret = pcmcia_register_driver(&ines_gpib_cs_driver);
+ if (ret)
+ goto err_pcmcia_driver;
#endif
- if (err)
- return -1;
return 0;
+
+#ifdef GPIB_PCMCIA
+err_pcmcia_driver:
+ gpib_unregister_driver(&ines_pcmcia_accel_interface);
+err_pcmcia_accel:
+ gpib_unregister_driver(&ines_pcmcia_unaccel_interface);
+err_pcmcia_unaccel:
+ gpib_unregister_driver(&ines_pcmcia_interface);
+err_pcmcia:
+#endif
+ gpib_unregister_driver(&ines_isa_interface);
+err_isa:
+ gpib_unregister_driver(&ines_pci_accel_interface);
+err_pci_accel:
+ gpib_unregister_driver(&ines_pci_unaccel_interface);
+err_pci_unaccel:
+ gpib_unregister_driver(&ines_pci_interface);
+err_pci:
+ pci_unregister_driver(&ines_pci_driver);
+
+ return ret;
}
static void __exit ines_exit_module(void)
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 796c3a5be545..3e826ab89bc7 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -1181,7 +1181,11 @@ static int usb_gpib_init_module(struct usb_interface *interface)
return rv;
if (!assigned_usb_minors) {
- gpib_register_driver(&usb_gpib_interface, THIS_MODULE);
+ rv = gpib_register_driver(&usb_gpib_interface, THIS_MODULE);
+ if (rv) {
+ gpib_unregister_driver(&usb_gpib_interface);
+ goto exit;
+ }
} else {
/* check if minor is already registered - maybe useless, but if
* it happens the code is inconsistent somewhere
diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
index b7b6fb1be379..f20a23a023d9 100644
--- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
+++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
@@ -2619,14 +2619,21 @@ static struct usb_driver ni_usb_bus_driver = {
static int __init ni_usb_init_module(void)
{
int i;
+ int ret = 0;
pr_info("ni_usb_gpib driver loading\n");
for (i = 0; i < MAX_NUM_NI_USB_INTERFACES; i++)
ni_usb_driver_interfaces[i] = NULL;
- usb_register(&ni_usb_bus_driver);
- gpib_register_driver(&ni_usb_gpib_interface, THIS_MODULE);
- return 0;
+ ret = usb_register(&ni_usb_bus_driver);
+ if (ret)
+ return ret;
+
+ ret = gpib_register_driver(&ni_usb_gpib_interface, THIS_MODULE);
+ if (ret)
+ usb_deregister(&ni_usb_bus_driver);
+
+ return ret;
}
static void __exit ni_usb_exit_module(void)
diff --git a/drivers/staging/gpib/pc2/pc2_gpib.c b/drivers/staging/gpib/pc2/pc2_gpib.c
index 7b3b34f47341..1d42ced67b2c 100644
--- a/drivers/staging/gpib/pc2/pc2_gpib.c
+++ b/drivers/staging/gpib/pc2/pc2_gpib.c
@@ -635,12 +635,34 @@ void pc2_2a_detach(gpib_board_t *board)
static int __init pc2_init_module(void)
{
- gpib_register_driver(&pc2_interface, THIS_MODULE);
- gpib_register_driver(&pc2a_interface, THIS_MODULE);
- gpib_register_driver(&pc2a_cb7210_interface, THIS_MODULE);
- gpib_register_driver(&pc2_2a_interface, THIS_MODULE);
+ int ret;
+
+ ret = gpib_register_driver(&pc2_interface, THIS_MODULE);
+ if (ret)
+ return ret;
+
+ ret = gpib_register_driver(&pc2a_interface, THIS_MODULE);
+ if (ret)
+ goto err_pc2a;
+
+ ret = gpib_register_driver(&pc2a_cb7210_interface, THIS_MODULE);
+ if (ret)
+ goto err_cb7210;
+
+ ret = gpib_register_driver(&pc2_2a_interface, THIS_MODULE);
+ if (ret)
+ goto err_pc2_2a;
return 0;
+
+err_pc2_2a:
+ gpib_unregister_driver(&pc2a_cb7210_interface);
+err_cb7210:
+ gpib_unregister_driver(&pc2a_interface);
+err_pc2a:
+ gpib_unregister_driver(&pc2_interface);
+
+ return ret;
}
static void __exit pc2_exit_module(void)
diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
index e49a952fa0d8..573544e86598 100644
--- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
+++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
@@ -1523,30 +1523,85 @@ static int __init tnt4882_init_module(void)
int result;
result = pci_register_driver(&tnt4882_pci_driver);
- if (result) {
- pr_err("tnt4882: pci_driver_register failed!\n");
+ if (result)
return result;
- }
- gpib_register_driver(&ni_isa_interface, THIS_MODULE);
- gpib_register_driver(&ni_isa_accel_interface, THIS_MODULE);
- gpib_register_driver(&ni_nat4882_isa_interface, THIS_MODULE);
- gpib_register_driver(&ni_nat4882_isa_accel_interface, THIS_MODULE);
- gpib_register_driver(&ni_nec_isa_interface, THIS_MODULE);
- gpib_register_driver(&ni_nec_isa_accel_interface, THIS_MODULE);
- gpib_register_driver(&ni_pci_interface, THIS_MODULE);
- gpib_register_driver(&ni_pci_accel_interface, THIS_MODULE);
+ result = gpib_register_driver(&ni_isa_interface, THIS_MODULE);
+ if (result)
+ goto err_isa;
+
+ result = gpib_register_driver(&ni_isa_accel_interface, THIS_MODULE);
+ if (result)
+ goto err_isa_accel;
+
+ result = gpib_register_driver(&ni_nat4882_isa_interface, THIS_MODULE);
+ if (result)
+ goto err_nat4882_isa;
+
+ result = gpib_register_driver(&ni_nat4882_isa_accel_interface, THIS_MODULE);
+ if (result)
+ goto err_nat4882_isa_accel;
+
+ result = gpib_register_driver(&ni_nec_isa_interface, THIS_MODULE);
+ if (result)
+ goto err_nec_isa;
+
+ result = gpib_register_driver(&ni_nec_isa_accel_interface, THIS_MODULE);
+ if (result)
+ goto err_nec_isa_accel;
+
+ result = gpib_register_driver(&ni_pci_interface, THIS_MODULE);
+ if (result)
+ goto err_pci;
+
+ result = gpib_register_driver(&ni_pci_accel_interface, THIS_MODULE);
+ if (result)
+ goto err_pci_accel;
+
#ifdef GPIB_PCMCIA
- gpib_register_driver(&ni_pcmcia_interface, THIS_MODULE);
- gpib_register_driver(&ni_pcmcia_accel_interface, THIS_MODULE);
- if (init_ni_gpib_cs() < 0)
- return -1;
+ result = gpib_register_driver(&ni_pcmcia_interface, THIS_MODULE);
+ if (result)
+ goto err_pcmcia;
+
+ result = gpib_register_driver(&ni_pcmcia_accel_interface, THIS_MODULE);
+ if (result)
+ goto err_pcmcia_accel;
+
+ result = init_ni_gpib_cs();
+ if (result)
+ goto err_pcmcia_driver;
#endif
mite_init();
mite_list_devices();
-
return 0;
+
+#ifdef GPIB_PCMCIA
+err_pcmcia_driver:
+ gpib_unregister_driver(&ni_pcmcia_accel_interface);
+err_pcmcia_accel:
+ gpib_unregister_driver(&ni_pcmcia_interface);
+err_pcmcia:
+#endif
+ gpib_unregister_driver(&ni_pci_accel_interface);
+err_pci_accel:
+ gpib_unregister_driver(&ni_pci_interface);
+err_pci:
+ gpib_unregister_driver(&ni_nec_isa_accel_interface);
+err_nec_isa_accel:
+ gpib_unregister_driver(&ni_nec_isa_interface);
+err_nec_isa:
+ gpib_unregister_driver(&ni_nat4882_isa_accel_interface);
+err_nat4882_isa_accel:
+ gpib_unregister_driver(&ni_nat4882_isa_interface);
+err_nat4882_isa:
+ gpib_unregister_driver(&ni_isa_accel_interface);
+err_isa_accel:
+ gpib_unregister_driver(&ni_isa_interface);
+err_isa:
+ pci_unregister_driver(&tnt4882_pci_driver);
+
+ return result;
}
static void __exit tnt4882_exit_module(void)
--
2.34.1Hi Nihar,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Nihar-Chaithanya/staging-gpib-Add-error-handling/20241222-060646
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20241221214822.163667-1-niharchaithanya%40gmail.com
patch subject: [PATCH v3] staging: gpib: Add error handling
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20241222/202412221424.WIjKFIPf-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241222/202412221424.WIjKFIPf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412221424.WIjKFIPf-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/staging/gpib/fmh_gpib/fmh_gpib.c: In function 'fmh_gpib_init_module':
>> drivers/staging/gpib/fmh_gpib/fmh_gpib.c:1694:17: error: label 'err_platform_driver' used but not defined
1694 | goto err_platform_driver;
| ^~~~
vim +/err_platform_driver +1694 drivers/staging/gpib/fmh_gpib/fmh_gpib.c
1687
1688 static int __init fmh_gpib_init_module(void)
1689 {
1690 int result;
1691
1692 result = platform_driver_register(&fmh_gpib_platform_driver);
1693 if (result)
> 1694 goto err_platform_driver;
1695
1696 result = pci_register_driver(&fmh_gpib_pci_driver);
1697 if (result)
1698 goto err_pci_driver;
1699
1700 result = gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE);
1701 if (result)
1702 goto err_unaccel;
1703
1704 result = gpib_register_driver(&fmh_gpib_interface, THIS_MODULE);
1705 if (result)
1706 goto err_interface;
1707
1708 result = gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE);
1709 if (result)
1710 goto err_pci_unaccel;
1711
1712 result = gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE);
1713 if (result)
1714 goto err_pci;
1715
1716 return 0;
1717
1718 err_pci:
1719 gpib_unregister_driver(&fmh_gpib_pci_unaccel_interface);
1720 err_pci_unaccel:
1721 gpib_unregister_driver(&fmh_gpib_interface);
1722 err_interface:
1723 gpib_unregister_driver(&fmh_gpib_unaccel_interface);
1724 err_unaccel:
1725 pci_unregister_driver(&fmh_gpib_pci_driver);
1726 err_pci_driver:
1727 platform_driver_unregister(&fmh_gpib_platform_driver);
1728
1729 return result;
1730 }
1731
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi Nihar,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Nihar-Chaithanya/staging-gpib-Add-error-handling/20241222-060646
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20241221214822.163667-1-niharchaithanya%40gmail.com
patch subject: [PATCH v3] staging: gpib: Add error handling
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20241222/202412221339.S4dQNJOs-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241222/202412221339.S4dQNJOs-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412221339.S4dQNJOs-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/staging/gpib/fmh_gpib/fmh_gpib.c:15:
In file included from drivers/staging/gpib/fmh_gpib/fmh_gpib.h:9:
In file included from include/linux/dmaengine.h:8:
In file included from include/linux/device.h:32:
In file included from include/linux/device/driver.h:21:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/gpib/fmh_gpib/fmh_gpib.c:162:45: warning: bitwise operation between different enumeration types ('enum fmh_gpib_auxmr_bits' and 'enum aux_reg_i_bits') [-Wenum-enum-conversion]
162 | write_byte(&priv->nec7210_priv, AUX_I_REG | LOCAL_PPOLL_MODE_BIT, AUXMR);
| ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/gpib/fmh_gpib/fmh_gpib.c:1694:8: error: use of undeclared label 'err_platform_driver'
1694 | goto err_platform_driver;
| ^
5 warnings and 1 error generated.
vim +/err_platform_driver +1694 drivers/staging/gpib/fmh_gpib/fmh_gpib.c
1687
1688 static int __init fmh_gpib_init_module(void)
1689 {
1690 int result;
1691
1692 result = platform_driver_register(&fmh_gpib_platform_driver);
1693 if (result)
> 1694 goto err_platform_driver;
1695
1696 result = pci_register_driver(&fmh_gpib_pci_driver);
1697 if (result)
1698 goto err_pci_driver;
1699
1700 result = gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE);
1701 if (result)
1702 goto err_unaccel;
1703
1704 result = gpib_register_driver(&fmh_gpib_interface, THIS_MODULE);
1705 if (result)
1706 goto err_interface;
1707
1708 result = gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE);
1709 if (result)
1710 goto err_pci_unaccel;
1711
1712 result = gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE);
1713 if (result)
1714 goto err_pci;
1715
1716 return 0;
1717
1718 err_pci:
1719 gpib_unregister_driver(&fmh_gpib_pci_unaccel_interface);
1720 err_pci_unaccel:
1721 gpib_unregister_driver(&fmh_gpib_interface);
1722 err_interface:
1723 gpib_unregister_driver(&fmh_gpib_unaccel_interface);
1724 err_unaccel:
1725 pci_unregister_driver(&fmh_gpib_pci_driver);
1726 err_pci_driver:
1727 platform_driver_unregister(&fmh_gpib_platform_driver);
1728
1729 return result;
1730 }
1731
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
On Sun, Dec 22, 2024 at 03:18:24AM +0530, Nihar Chaithanya wrote: > The function gpib_register_driver() can fail when kmalloc() > fails but it does not return an error code. > The function pcmcia_register_driver() returns an error code but > most of the times is not handled in gpib. > > Modify gpid_register_driver() to return appropriate error code > and also handle the error code returned by pcmcia_register_driver() > incase it fails. When any of these functions fail unwind and > unregister the driver to avoid semi-registered system. > > This issue was reported by Coverity Scan. > Report: > CID 1635894: (#1 of 1): 'Constant' variable guards dead code (DEADCODE) > dead_error_line: Execution cannot reach this statement: return -1;. > > Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com> > --- > v2 --> v3 : Modified the gpib_register_driver() to return error code, > added error handling to all the places that the > gpib_register_driver() is called. You are doing a lot of different things all at once here. Please break this up into a patch series, only doing one "logical" thing per change please. thanks, greg k-h
© 2016 - 2026 Red Hat, Inc.