1. Patchew
  2. linux
  3. [PATCH 00/20] alienware-wmi driver rework
  4. View patch

[PATCH 18/20] platform/x86: dell: Modify Makefile alignment

Kurt Borja posted 20 patches 1 year, 1 month ago
There is a newer version of this series
[PATCH 18/20] platform/x86: dell: Modify Makefile alignment
Posted by Kurt Borja 1 year, 1 month ago 
Add one more TAB to each line to support upcoming changes.

Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
 drivers/platform/x86/dell/Makefile | 48 +++++++++++++++---------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile
index 03ba459f3d31..d5718ef34c48 100644
--- a/drivers/platform/x86/dell/Makefile
+++ b/drivers/platform/x86/dell/Makefile
@@ -4,27 +4,27 @@
 # Dell x86 Platform-Specific Drivers
 #
 
-obj-$(CONFIG_ALIENWARE_WMI)		+= alienware-wmi.o
-alienware-wmi-objs			:= alienware-wmi-base.o
-alienware-wmi-y				+= alienware-wmi-legacy.o
-alienware-wmi-y				+= alienware-wmi-wmax.o
-obj-$(CONFIG_DCDBAS)			+= dcdbas.o
-obj-$(CONFIG_DELL_LAPTOP)		+= dell-laptop.o
-obj-$(CONFIG_DELL_RBTN)			+= dell-rbtn.o
-obj-$(CONFIG_DELL_RBU)			+= dell_rbu.o
-obj-$(CONFIG_DELL_PC)			+= dell-pc.o
-obj-$(CONFIG_DELL_SMBIOS)		+= dell-smbios.o
-dell-smbios-objs			:= dell-smbios-base.o
-dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)	+= dell-smbios-wmi.o
-dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)	+= dell-smbios-smm.o
-obj-$(CONFIG_DELL_SMO8800)		+= dell-smo8800.o
-obj-$(CONFIG_DELL_SMO8800)		+= dell-lis3lv02d.o
-obj-$(CONFIG_DELL_UART_BACKLIGHT)	+= dell-uart-backlight.o
-obj-$(CONFIG_DELL_WMI)			+= dell-wmi.o
-dell-wmi-objs				:= dell-wmi-base.o
-dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)	+= dell-wmi-privacy.o
-obj-$(CONFIG_DELL_WMI_AIO)		+= dell-wmi-aio.o
-obj-$(CONFIG_DELL_WMI_DESCRIPTOR)	+= dell-wmi-descriptor.o
-obj-$(CONFIG_DELL_WMI_DDV)		+= dell-wmi-ddv.o
-obj-$(CONFIG_DELL_WMI_LED)		+= dell-wmi-led.o
-obj-$(CONFIG_DELL_WMI_SYSMAN)		+= dell-wmi-sysman/
+obj-$(CONFIG_ALIENWARE_WMI)			+= alienware-wmi.o
+alienware-wmi-objs				:= alienware-wmi-base.o
+alienware-wmi-y					+= alienware-wmi-legacy.o
+alienware-wmi-y					+= alienware-wmi-wmax.o
+obj-$(CONFIG_DCDBAS)				+= dcdbas.o
+obj-$(CONFIG_DELL_LAPTOP)			+= dell-laptop.o
+obj-$(CONFIG_DELL_RBTN)				+= dell-rbtn.o
+obj-$(CONFIG_DELL_RBU)				+= dell_rbu.o
+obj-$(CONFIG_DELL_PC)				+= dell-pc.o
+obj-$(CONFIG_DELL_SMBIOS)			+= dell-smbios.o
+dell-smbios-objs				:= dell-smbios-base.o
+dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)		+= dell-smbios-wmi.o
+dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)		+= dell-smbios-smm.o
+obj-$(CONFIG_DELL_SMO8800)			+= dell-smo8800.o
+obj-$(CONFIG_DELL_SMO8800)			+= dell-lis3lv02d.o
+obj-$(CONFIG_DELL_UART_BACKLIGHT)		+= dell-uart-backlight.o
+obj-$(CONFIG_DELL_WMI)				+= dell-wmi.o
+dell-wmi-objs					:= dell-wmi-base.o
+dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)		+= dell-wmi-privacy.o
+obj-$(CONFIG_DELL_WMI_AIO)			+= dell-wmi-aio.o
+obj-$(CONFIG_DELL_WMI_DESCRIPTOR)		+= dell-wmi-descriptor.o
+obj-$(CONFIG_DELL_WMI_DDV)			+= dell-wmi-ddv.o
+obj-$(CONFIG_DELL_WMI_LED)			+= dell-wmi-led.o
+obj-$(CONFIG_DELL_WMI_SYSMAN)			+= dell-wmi-sysman/
-- 
2.47.1
Re: [PATCH 18/20] platform/x86: dell: Modify Makefile alignment
Posted by Armin Wolf 1 year, 1 month ago 
Am 21.12.24 um 06:59 schrieb Kurt Borja:

> Add one more TAB to each line to support upcoming changes.

Please merge this with patch 19.

Thanks,
Armin Wolf

>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
>   drivers/platform/x86/dell/Makefile | 48 +++++++++++++++---------------
>   1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile
> index 03ba459f3d31..d5718ef34c48 100644
> --- a/drivers/platform/x86/dell/Makefile
> +++ b/drivers/platform/x86/dell/Makefile
> @@ -4,27 +4,27 @@
>   # Dell x86 Platform-Specific Drivers
>   #
>
> -obj-$(CONFIG_ALIENWARE_WMI)		+= alienware-wmi.o
> -alienware-wmi-objs			:= alienware-wmi-base.o
> -alienware-wmi-y				+= alienware-wmi-legacy.o
> -alienware-wmi-y				+= alienware-wmi-wmax.o
> -obj-$(CONFIG_DCDBAS)			+= dcdbas.o
> -obj-$(CONFIG_DELL_LAPTOP)		+= dell-laptop.o
> -obj-$(CONFIG_DELL_RBTN)			+= dell-rbtn.o
> -obj-$(CONFIG_DELL_RBU)			+= dell_rbu.o
> -obj-$(CONFIG_DELL_PC)			+= dell-pc.o
> -obj-$(CONFIG_DELL_SMBIOS)		+= dell-smbios.o
> -dell-smbios-objs			:= dell-smbios-base.o
> -dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)	+= dell-smbios-wmi.o
> -dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)	+= dell-smbios-smm.o
> -obj-$(CONFIG_DELL_SMO8800)		+= dell-smo8800.o
> -obj-$(CONFIG_DELL_SMO8800)		+= dell-lis3lv02d.o
> -obj-$(CONFIG_DELL_UART_BACKLIGHT)	+= dell-uart-backlight.o
> -obj-$(CONFIG_DELL_WMI)			+= dell-wmi.o
> -dell-wmi-objs				:= dell-wmi-base.o
> -dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)	+= dell-wmi-privacy.o
> -obj-$(CONFIG_DELL_WMI_AIO)		+= dell-wmi-aio.o
> -obj-$(CONFIG_DELL_WMI_DESCRIPTOR)	+= dell-wmi-descriptor.o
> -obj-$(CONFIG_DELL_WMI_DDV)		+= dell-wmi-ddv.o
> -obj-$(CONFIG_DELL_WMI_LED)		+= dell-wmi-led.o
> -obj-$(CONFIG_DELL_WMI_SYSMAN)		+= dell-wmi-sysman/
> +obj-$(CONFIG_ALIENWARE_WMI)			+= alienware-wmi.o
> +alienware-wmi-objs				:= alienware-wmi-base.o
> +alienware-wmi-y					+= alienware-wmi-legacy.o
> +alienware-wmi-y					+= alienware-wmi-wmax.o
> +obj-$(CONFIG_DCDBAS)				+= dcdbas.o
> +obj-$(CONFIG_DELL_LAPTOP)			+= dell-laptop.o
> +obj-$(CONFIG_DELL_RBTN)				+= dell-rbtn.o
> +obj-$(CONFIG_DELL_RBU)				+= dell_rbu.o
> +obj-$(CONFIG_DELL_PC)				+= dell-pc.o
> +obj-$(CONFIG_DELL_SMBIOS)			+= dell-smbios.o
> +dell-smbios-objs				:= dell-smbios-base.o
> +dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)		+= dell-smbios-wmi.o
> +dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)		+= dell-smbios-smm.o
> +obj-$(CONFIG_DELL_SMO8800)			+= dell-smo8800.o
> +obj-$(CONFIG_DELL_SMO8800)			+= dell-lis3lv02d.o
> +obj-$(CONFIG_DELL_UART_BACKLIGHT)		+= dell-uart-backlight.o
> +obj-$(CONFIG_DELL_WMI)				+= dell-wmi.o
> +dell-wmi-objs					:= dell-wmi-base.o
> +dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)		+= dell-wmi-privacy.o
> +obj-$(CONFIG_DELL_WMI_AIO)			+= dell-wmi-aio.o
> +obj-$(CONFIG_DELL_WMI_DESCRIPTOR)		+= dell-wmi-descriptor.o
> +obj-$(CONFIG_DELL_WMI_DDV)			+= dell-wmi-ddv.o
> +obj-$(CONFIG_DELL_WMI_LED)			+= dell-wmi-led.o
> +obj-$(CONFIG_DELL_WMI_SYSMAN)			+= dell-wmi-sysman/
Re: [PATCH 18/20] platform/x86: dell: Modify Makefile alignment
Posted by Kurt Borja 1 year, 1 month ago 
On Fri, Dec 27, 2024 at 05:05:30AM +0100, Armin Wolf wrote:
> Am 21.12.24 um 06:59 schrieb Kurt Borja:
> 
> > Add one more TAB to each line to support upcoming changes.
> 
> Please merge this with patch 19.

I'm almost certain I read an email in the lists, in which a maintainer
asked these to be separate changes.

I have no problem with stashing them tho.

> 
> Thanks,
> Armin Wolf
> 
> > 
> > Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> > ---
> >   drivers/platform/x86/dell/Makefile | 48 +++++++++++++++---------------
> >   1 file changed, 24 insertions(+), 24 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile
> > index 03ba459f3d31..d5718ef34c48 100644
> > --- a/drivers/platform/x86/dell/Makefile
> > +++ b/drivers/platform/x86/dell/Makefile
> > @@ -4,27 +4,27 @@
> >   # Dell x86 Platform-Specific Drivers
> >   #
> > 
> > -obj-$(CONFIG_ALIENWARE_WMI)		+= alienware-wmi.o
> > -alienware-wmi-objs			:= alienware-wmi-base.o
> > -alienware-wmi-y				+= alienware-wmi-legacy.o
> > -alienware-wmi-y				+= alienware-wmi-wmax.o
> > -obj-$(CONFIG_DCDBAS)			+= dcdbas.o
> > -obj-$(CONFIG_DELL_LAPTOP)		+= dell-laptop.o
> > -obj-$(CONFIG_DELL_RBTN)			+= dell-rbtn.o
> > -obj-$(CONFIG_DELL_RBU)			+= dell_rbu.o
> > -obj-$(CONFIG_DELL_PC)			+= dell-pc.o
> > -obj-$(CONFIG_DELL_SMBIOS)		+= dell-smbios.o
> > -dell-smbios-objs			:= dell-smbios-base.o
> > -dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)	+= dell-smbios-wmi.o
> > -dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)	+= dell-smbios-smm.o
> > -obj-$(CONFIG_DELL_SMO8800)		+= dell-smo8800.o
> > -obj-$(CONFIG_DELL_SMO8800)		+= dell-lis3lv02d.o
> > -obj-$(CONFIG_DELL_UART_BACKLIGHT)	+= dell-uart-backlight.o
> > -obj-$(CONFIG_DELL_WMI)			+= dell-wmi.o
> > -dell-wmi-objs				:= dell-wmi-base.o
> > -dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)	+= dell-wmi-privacy.o
> > -obj-$(CONFIG_DELL_WMI_AIO)		+= dell-wmi-aio.o
> > -obj-$(CONFIG_DELL_WMI_DESCRIPTOR)	+= dell-wmi-descriptor.o
> > -obj-$(CONFIG_DELL_WMI_DDV)		+= dell-wmi-ddv.o
> > -obj-$(CONFIG_DELL_WMI_LED)		+= dell-wmi-led.o
> > -obj-$(CONFIG_DELL_WMI_SYSMAN)		+= dell-wmi-sysman/
> > +obj-$(CONFIG_ALIENWARE_WMI)			+= alienware-wmi.o
> > +alienware-wmi-objs				:= alienware-wmi-base.o
> > +alienware-wmi-y					+= alienware-wmi-legacy.o
> > +alienware-wmi-y					+= alienware-wmi-wmax.o
> > +obj-$(CONFIG_DCDBAS)				+= dcdbas.o
> > +obj-$(CONFIG_DELL_LAPTOP)			+= dell-laptop.o
> > +obj-$(CONFIG_DELL_RBTN)				+= dell-rbtn.o
> > +obj-$(CONFIG_DELL_RBU)				+= dell_rbu.o
> > +obj-$(CONFIG_DELL_PC)				+= dell-pc.o
> > +obj-$(CONFIG_DELL_SMBIOS)			+= dell-smbios.o
> > +dell-smbios-objs				:= dell-smbios-base.o
> > +dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)		+= dell-smbios-wmi.o
> > +dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)		+= dell-smbios-smm.o
> > +obj-$(CONFIG_DELL_SMO8800)			+= dell-smo8800.o
> > +obj-$(CONFIG_DELL_SMO8800)			+= dell-lis3lv02d.o
> > +obj-$(CONFIG_DELL_UART_BACKLIGHT)		+= dell-uart-backlight.o
> > +obj-$(CONFIG_DELL_WMI)				+= dell-wmi.o
> > +dell-wmi-objs					:= dell-wmi-base.o
> > +dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)		+= dell-wmi-privacy.o
> > +obj-$(CONFIG_DELL_WMI_AIO)			+= dell-wmi-aio.o
> > +obj-$(CONFIG_DELL_WMI_DESCRIPTOR)		+= dell-wmi-descriptor.o
> > +obj-$(CONFIG_DELL_WMI_DDV)			+= dell-wmi-ddv.o
> > +obj-$(CONFIG_DELL_WMI_LED)			+= dell-wmi-led.o
> > +obj-$(CONFIG_DELL_WMI_SYSMAN)			+= dell-wmi-sysman/
Re: [PATCH 18/20] platform/x86: dell: Modify Makefile alignment
Posted by Armin Wolf 1 year, 1 month ago 
Am 27.12.24 um 05:57 schrieb Kurt Borja:

> On Fri, Dec 27, 2024 at 05:05:30AM +0100, Armin Wolf wrote:
>> Am 21.12.24 um 06:59 schrieb Kurt Borja:
>>
>>> Add one more TAB to each line to support upcoming changes.
>> Please merge this with patch 19.
> I'm almost certain I read an email in the lists, in which a maintainer
> asked these to be separate changes.
>
> I have no problem with stashing them tho.

I was not aware of that email.

In this case:

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

>> Thanks,
>> Armin Wolf
>>
>>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>>> ---
>>>    drivers/platform/x86/dell/Makefile | 48 +++++++++++++++---------------
>>>    1 file changed, 24 insertions(+), 24 deletions(-)
>>>
>>> diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile
>>> index 03ba459f3d31..d5718ef34c48 100644
>>> --- a/drivers/platform/x86/dell/Makefile
>>> +++ b/drivers/platform/x86/dell/Makefile
>>> @@ -4,27 +4,27 @@
>>>    # Dell x86 Platform-Specific Drivers
>>>    #
>>>
>>> -obj-$(CONFIG_ALIENWARE_WMI)		+= alienware-wmi.o
>>> -alienware-wmi-objs			:= alienware-wmi-base.o
>>> -alienware-wmi-y				+= alienware-wmi-legacy.o
>>> -alienware-wmi-y				+= alienware-wmi-wmax.o
>>> -obj-$(CONFIG_DCDBAS)			+= dcdbas.o
>>> -obj-$(CONFIG_DELL_LAPTOP)		+= dell-laptop.o
>>> -obj-$(CONFIG_DELL_RBTN)			+= dell-rbtn.o
>>> -obj-$(CONFIG_DELL_RBU)			+= dell_rbu.o
>>> -obj-$(CONFIG_DELL_PC)			+= dell-pc.o
>>> -obj-$(CONFIG_DELL_SMBIOS)		+= dell-smbios.o
>>> -dell-smbios-objs			:= dell-smbios-base.o
>>> -dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)	+= dell-smbios-wmi.o
>>> -dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)	+= dell-smbios-smm.o
>>> -obj-$(CONFIG_DELL_SMO8800)		+= dell-smo8800.o
>>> -obj-$(CONFIG_DELL_SMO8800)		+= dell-lis3lv02d.o
>>> -obj-$(CONFIG_DELL_UART_BACKLIGHT)	+= dell-uart-backlight.o
>>> -obj-$(CONFIG_DELL_WMI)			+= dell-wmi.o
>>> -dell-wmi-objs				:= dell-wmi-base.o
>>> -dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)	+= dell-wmi-privacy.o
>>> -obj-$(CONFIG_DELL_WMI_AIO)		+= dell-wmi-aio.o
>>> -obj-$(CONFIG_DELL_WMI_DESCRIPTOR)	+= dell-wmi-descriptor.o
>>> -obj-$(CONFIG_DELL_WMI_DDV)		+= dell-wmi-ddv.o
>>> -obj-$(CONFIG_DELL_WMI_LED)		+= dell-wmi-led.o
>>> -obj-$(CONFIG_DELL_WMI_SYSMAN)		+= dell-wmi-sysman/
>>> +obj-$(CONFIG_ALIENWARE_WMI)			+= alienware-wmi.o
>>> +alienware-wmi-objs				:= alienware-wmi-base.o
>>> +alienware-wmi-y					+= alienware-wmi-legacy.o
>>> +alienware-wmi-y					+= alienware-wmi-wmax.o
>>> +obj-$(CONFIG_DCDBAS)				+= dcdbas.o
>>> +obj-$(CONFIG_DELL_LAPTOP)			+= dell-laptop.o
>>> +obj-$(CONFIG_DELL_RBTN)				+= dell-rbtn.o
>>> +obj-$(CONFIG_DELL_RBU)				+= dell_rbu.o
>>> +obj-$(CONFIG_DELL_PC)				+= dell-pc.o
>>> +obj-$(CONFIG_DELL_SMBIOS)			+= dell-smbios.o
>>> +dell-smbios-objs				:= dell-smbios-base.o
>>> +dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)		+= dell-smbios-wmi.o
>>> +dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)		+= dell-smbios-smm.o
>>> +obj-$(CONFIG_DELL_SMO8800)			+= dell-smo8800.o
>>> +obj-$(CONFIG_DELL_SMO8800)			+= dell-lis3lv02d.o
>>> +obj-$(CONFIG_DELL_UART_BACKLIGHT)		+= dell-uart-backlight.o
>>> +obj-$(CONFIG_DELL_WMI)				+= dell-wmi.o
>>> +dell-wmi-objs					:= dell-wmi-base.o
>>> +dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)		+= dell-wmi-privacy.o
>>> +obj-$(CONFIG_DELL_WMI_AIO)			+= dell-wmi-aio.o
>>> +obj-$(CONFIG_DELL_WMI_DESCRIPTOR)		+= dell-wmi-descriptor.o
>>> +obj-$(CONFIG_DELL_WMI_DDV)			+= dell-wmi-ddv.o
>>> +obj-$(CONFIG_DELL_WMI_LED)			+= dell-wmi-led.o
>>> +obj-$(CONFIG_DELL_WMI_SYSMAN)			+= dell-wmi-sysman/

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.