Add missing parent_map to clocks in SM6350 clock drivers

[PATCH 0/2] Add missing parent_map to clocks in SM6350 clock drivers

Luca Weiss posted 2 patches 1 year, 1 month ago

Download series mbox

drivers/clk/qcom/dispcc-sm6350.c |  7 +++----
drivers/clk/qcom/gcc-sm6350.c    | 22 ++++++++++++++--------
2 files changed, 17 insertions(+), 12 deletions(-)

Expand all Fold all

[PATCH 0/2] Add missing parent_map to clocks in SM6350 clock drivers

Posted by Luca Weiss 1 year, 1 month ago

If a clk_rcg2 has a parent, it should also have parent_map defined,
otherwise we'll get a NULL pointer dereference when calling clk_set_rate
on those clocks.

Correct this on clocks in both gcc-sm6350 and dispcc-sm6350.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Luca Weiss (2):
      clk: qcom: gcc-sm6350: Add missing parent_map for two clocks
      clk: qcom: dispcc-sm6350: Add missing parent_map for a clock

 drivers/clk/qcom/dispcc-sm6350.c |  7 +++----
 drivers/clk/qcom/gcc-sm6350.c    | 22 ++++++++++++++--------
 2 files changed, 17 insertions(+), 12 deletions(-)
---
base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20241220-sm6350-parent_map-c03e9b61a718

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>

Re: [PATCH 0/2] Add missing parent_map to clocks in SM6350 clock drivers

Posted by Bjorn Andersson 1 year, 1 month ago

On Fri, 20 Dec 2024 10:03:29 +0100, Luca Weiss wrote:
> If a clk_rcg2 has a parent, it should also have parent_map defined,
> otherwise we'll get a NULL pointer dereference when calling clk_set_rate
> on those clocks.
> 
> Correct this on clocks in both gcc-sm6350 and dispcc-sm6350.
> 
> 
> [...]

Applied, thanks!

[1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks
      commit: 96fe1a7ee477d701cfc98ab9d3c730c35d966861
[2/2] clk: qcom: dispcc-sm6350: Add missing parent_map for a clock
      commit: d4cdb196f182d2fbe336c968228be00d8c3fed05

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>