Hi Krzysztof,
On 2024/12/19 16:28, Krzysztof Kozlowski wrote:
> On Thu, Dec 19, 2024 at 04:05:51PM +0800, Damon Ding wrote:
>> Compared with RK3288/RK3399, the HBR2 link rate support is the main
>> improvement of RK3588 eDP TX controller, and there are also two
>> independent eDP display interfaces on RK3588 Soc.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Drop, patch was very different.
>
>> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
>>
>> ---
>>
>> Changes in v2:
>> - Add the main defferences of the RK3588 eDP and the previous versions
>> in commit message
>>
>> Changes in v3:
>> - expand the property clock-names, resets and reset-names
>
> Adding new properties invalidates reviews. The patch is entirely, really
> significantly different so keeping the review is not acceptable.
>
>> ---
>> .../display/rockchip/rockchip,analogix-dp.yaml | 14 +++++++++++---
>> 1 file changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
>> index 60dedf9b2be7..4f84e8849876 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
>> @@ -15,6 +15,7 @@ properties:
>> enum:
>> - rockchip,rk3288-dp
>> - rockchip,rk3399-edp
>> + - rockchip,rk3588-edp
>>
>> clocks:
>> minItems: 2
>> @@ -25,16 +26,23 @@ properties:
>> items:
>> - const: dp
>> - const: pclk
>> - - const: grf
>> + - enum:
>> + - grf
>> + - spdif
>
> No, this cannot be flexible for existing variants.
I will drop the 'spdif' because the audio feature has not been added to
the analogix-dp driver in this patch series.
>
>>
>> power-domains:
>> maxItems: 1
>>
>> resets:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>
> No, you must list the items.
>
>>
>> reset-names:
>> - const: dp
>> + minItems: 1
>> + items:
>> + - const: dp
>> + - enum:
>> + - apb
>
> I don't understand what happened here but all this is NAK. Why suddenly
> existing variants became different/changed? Nothing in commit msg
> explains this.
The newly added 'apb' reset is to ensure the APB bus of eDP controller
works well on the RK3588 SoC. I will mention it in commit message in the
next version.
The fixed patch will be like:
@@ -31,10 +32,12 @@ properties:
maxItems: 1
resets:
- maxItems: 1
+ maxItems: 2
reset-names:
- const: dp
+ items:
+ - const: dp
+ - const: apb
rockchip,grf:
$ref: /schemas/types.yaml#/definitions/phandle
And I will add the APB reset operation in Rockchip analogix-dp driver,
which was forgotten in the [PATCH v3 03/15].
Best regards,
Damon