MAINTAINERS: Assume maintainership of PL111

[PATCH] MAINTAINERS: Assume maintainership of PL111

Posted by Linus Walleij 12 months ago

Emma Anholt dropped maintainership for PL111 and I
didn't notice it at the time. I've written part of it
and I'm happy to maintain it, list myself as maintainer
and assume active maintainership.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1e930c7a58b13d8bbe6bf133ba7b36aa24c2b5e0..99dbe95995824cb6bdf9e5865982c92677924fa8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7068,7 +7068,8 @@ T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
 F:	drivers/gpu/drm/sun4i/sun8i*
 
 DRM DRIVER FOR ARM PL111 CLCD
-S:	Orphan
+M:	Linus Walleij <linus.walleij@linaro.org>
+S:	Maintained
 T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
 F:	drivers/gpu/drm/pl111/
 

---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20241219-pl111-maintain-ec7f69230d48

Best regards,
-- 
Linus Walleij <linus.walleij@linaro.org>

Re: [PATCH] MAINTAINERS: Assume maintainership of PL111

Posted by Simona Vetter 12 months ago

On Thu, Dec 19, 2024 at 07:36:05PM +0100, Linus Walleij wrote:
> Emma Anholt dropped maintainership for PL111 and I
> didn't notice it at the time. I've written part of it
> and I'm happy to maintain it, list myself as maintainer
> and assume active maintainership.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Simona Vetter <simona.vetter@ffwll.ch>
> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1e930c7a58b13d8bbe6bf133ba7b36aa24c2b5e0..99dbe95995824cb6bdf9e5865982c92677924fa8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7068,7 +7068,8 @@ T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>  F:	drivers/gpu/drm/sun4i/sun8i*
>  
>  DRM DRIVER FOR ARM PL111 CLCD
> -S:	Orphan
> +M:	Linus Walleij <linus.walleij@linaro.org>
> +S:	Maintained
>  T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>  F:	drivers/gpu/drm/pl111/
>  
> 
> ---
> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> change-id: 20241219-pl111-maintain-ec7f69230d48
> 
> Best regards,
> -- 
> Linus Walleij <linus.walleij@linaro.org>
> 

-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH] MAINTAINERS: Assume maintainership of PL111

Posted by Dmitry Baryshkov 12 months ago

On Thu, Dec 19, 2024 at 07:36:05PM +0100, Linus Walleij wrote:
> Emma Anholt dropped maintainership for PL111 and I
> didn't notice it at the time. I've written part of it
> and I'm happy to maintain it, list myself as maintainer
> and assume active maintainership.

Nice!

Could you please convert it to use DRM_BRIDGE_ATTACH_NO_CONNECTOR?
Likewise pl111_display_enable() should use the bus flags and input
formats of the next bridge rather than the ones of the connector.

> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1e930c7a58b13d8bbe6bf133ba7b36aa24c2b5e0..99dbe95995824cb6bdf9e5865982c92677924fa8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7068,7 +7068,8 @@ T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>  F:	drivers/gpu/drm/sun4i/sun8i*
>  
>  DRM DRIVER FOR ARM PL111 CLCD
> -S:	Orphan
> +M:	Linus Walleij <linus.walleij@linaro.org>
> +S:	Maintained
>  T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>  F:	drivers/gpu/drm/pl111/
>  
> 
> ---
> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> change-id: 20241219-pl111-maintain-ec7f69230d48
> 
> Best regards,
> -- 
> Linus Walleij <linus.walleij@linaro.org>
> 

-- 
With best wishes
Dmitry

Re: [PATCH] MAINTAINERS: Assume maintainership of PL111

Posted by Linus Walleij 12 months ago

On Fri, Dec 20, 2024 at 1:11 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:

> Could you please convert it to use DRM_BRIDGE_ATTACH_NO_CONNECTOR?
> Likewise pl111_display_enable() should use the bus flags and input
> formats of the next bridge rather than the ones of the connector.

I can surely look into it.
Is there some example committ of this type of conversion in the
tree?

Yours,
Linus Walleij

Re: [PATCH] MAINTAINERS: Assume maintainership of PL111

Posted by Dmitry Baryshkov 12 months ago

On Sun, 22 Dec 2024 at 00:26, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Fri, Dec 20, 2024 at 1:11 AM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>
> > Could you please convert it to use DRM_BRIDGE_ATTACH_NO_CONNECTOR?
> > Likewise pl111_display_enable() should use the bus flags and input
> > formats of the next bridge rather than the ones of the connector.
>
> I can surely look into it.
> Is there some example committ of this type of conversion in the
> tree?

I probably can not point to a single commit.
There are a lot of drivers that use DRM_BRIDGE_ATTACH_NO_CONNECTOR and
then create and attach drm_bridge_connector manually. I think one of
the last conversions was done for the imx/ipuv3 drivers (dw_hdmi isn't
converted yet)
For the bus formats it seems we are not there yet. At least panel.c
doesn't propagate panel's flags and formats, so you can ignore that
comment.

-- 
With best wishes
Dmitry