[PATCH linux-pm] thermal: intel: Fix compile issue when CONFIG_NET is not defined

Srinivas Pandruvada posted 1 patch 12 months ago
drivers/thermal/intel/Kconfig                 | 1 +
drivers/thermal/intel/int340x_thermal/Kconfig | 1 +
2 files changed, 2 insertions(+)
[PATCH linux-pm] thermal: intel: Fix compile issue when CONFIG_NET is not defined
Posted by Srinivas Pandruvada 12 months ago
If CONFIG_NET is not defined then THERMAL_NETLINK can't be selected.
Hence add dependency on CONFIG_NET. Othewise it will generate compile
errors while compiling thermal_netlink.c.

Fixes: 4596cbea0ed2 ("thermal: intel: Remove explicit user_space governor selection")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
This commit ID 4596cbea0ed2 is from linux-pm bleeding edge branch of
linux-pm git.

 drivers/thermal/intel/Kconfig                 | 1 +
 drivers/thermal/intel/int340x_thermal/Kconfig | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
index 9c0f66f9defc..e1973c0efe0c 100644
--- a/drivers/thermal/intel/Kconfig
+++ b/drivers/thermal/intel/Kconfig
@@ -22,6 +22,7 @@ config INTEL_TCC
 config X86_PKG_TEMP_THERMAL
 	tristate "X86 package temperature thermal driver"
 	depends on X86_THERMAL_VECTOR
+	depends on NET
 	select THERMAL_NETLINK
 	select INTEL_TCC
 	default m
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index d9a74424c29d..6a0203eaa7f2 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -6,6 +6,7 @@
 config INT340X_THERMAL
 	tristate "ACPI INT340X thermal drivers"
 	depends on X86_64 && ACPI && PCI
+	depends on NET
 	select THERMAL_NETLINK
 	select ACPI_THERMAL_REL
 	select ACPI_FAN
-- 
2.47.1
Re: [PATCH linux-pm] thermal: intel: Fix compile issue when CONFIG_NET is not defined
Posted by Rafael J. Wysocki 12 months ago
On Wed, Dec 18, 2024 at 10:45 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> If CONFIG_NET is not defined then THERMAL_NETLINK can't be selected.
> Hence add dependency on CONFIG_NET. Othewise it will generate compile
> errors while compiling thermal_netlink.c.
>
> Fixes: 4596cbea0ed2 ("thermal: intel: Remove explicit user_space governor selection")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> This commit ID 4596cbea0ed2 is from linux-pm bleeding edge branch of
> linux-pm git.
>
>  drivers/thermal/intel/Kconfig                 | 1 +
>  drivers/thermal/intel/int340x_thermal/Kconfig | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> index 9c0f66f9defc..e1973c0efe0c 100644
> --- a/drivers/thermal/intel/Kconfig
> +++ b/drivers/thermal/intel/Kconfig
> @@ -22,6 +22,7 @@ config INTEL_TCC
>  config X86_PKG_TEMP_THERMAL
>         tristate "X86 package temperature thermal driver"
>         depends on X86_THERMAL_VECTOR
> +       depends on NET
>         select THERMAL_NETLINK
>         select INTEL_TCC
>         default m
> diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
> index d9a74424c29d..6a0203eaa7f2 100644
> --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> @@ -6,6 +6,7 @@
>  config INT340X_THERMAL
>         tristate "ACPI INT340X thermal drivers"
>         depends on X86_64 && ACPI && PCI
> +       depends on NET
>         select THERMAL_NETLINK
>         select ACPI_THERMAL_REL
>         select ACPI_FAN
> --

Applied, but I've just added the missing NET dependency to the
existing "depends on" lines.  Please check my bleeding-edge branch.

Thanks!