[PATCH] [v2] accel/amdxdna: include linux/slab.h

Arnd Bergmann posted 1 patch 12 months ago
drivers/accel/amdxdna/aie2_solver.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] [v2] accel/amdxdna: include linux/slab.h
Posted by Arnd Bergmann 12 months ago
From: Arnd Bergmann <arnd@arndb.de>

This driver fails to build in random configurations:

drivers/accel/amdxdna/aie2_solver.c: In function 'remove_partition_node':
drivers/accel/amdxdna/aie2_solver.c:121:9: error: implicit declaration of function 'kfree' [-Wimplicit-function-declaration]
  121 |         kfree(pt_node);
      |         ^~~~~
drivers/accel/amdxdna/aie2_solver.c: In function 'get_free_partition':
drivers/accel/amdxdna/aie2_solver.c:153:19: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
  153 |         pt_node = kzalloc(sizeof(*pt_node), GFP_KERNEL);

Add the missing include.

Fixes: c88d3325ae69 ("accel/amdxdna: Add hardware resource solver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This one is still needed, I had previously combined two missing includes
in one patch
---
 drivers/accel/amdxdna/aie2_solver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/accel/amdxdna/aie2_solver.c b/drivers/accel/amdxdna/aie2_solver.c
index 1939625d6027..2013d1f13aae 100644
--- a/drivers/accel/amdxdna/aie2_solver.c
+++ b/drivers/accel/amdxdna/aie2_solver.c
@@ -8,6 +8,7 @@
 #include <drm/drm_print.h>
 #include <linux/bitops.h>
 #include <linux/bitmap.h>
+#include <linux/slab.h>
 
 #include "aie2_solver.h"
 
-- 
2.39.5
Re: [PATCH] [v2] accel/amdxdna: include linux/slab.h
Posted by Mario Limonciello 12 months ago
On 12/18/2024 02:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver fails to build in random configurations:
> 
> drivers/accel/amdxdna/aie2_solver.c: In function 'remove_partition_node':
> drivers/accel/amdxdna/aie2_solver.c:121:9: error: implicit declaration of function 'kfree' [-Wimplicit-function-declaration]
>    121 |         kfree(pt_node);
>        |         ^~~~~
> drivers/accel/amdxdna/aie2_solver.c: In function 'get_free_partition':
> drivers/accel/amdxdna/aie2_solver.c:153:19: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
>    153 |         pt_node = kzalloc(sizeof(*pt_node), GFP_KERNEL);
> 
> Add the missing include.
> 
> Fixes: c88d3325ae69 ("accel/amdxdna: Add hardware resource solver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This one is still needed, I had previously combined two missing includes
> in one patch

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

Applied to drm-misc-next.

221e29e197981 accel/amdxdna: include linux/slab.h

> ---
>   drivers/accel/amdxdna/aie2_solver.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/accel/amdxdna/aie2_solver.c b/drivers/accel/amdxdna/aie2_solver.c
> index 1939625d6027..2013d1f13aae 100644
> --- a/drivers/accel/amdxdna/aie2_solver.c
> +++ b/drivers/accel/amdxdna/aie2_solver.c
> @@ -8,6 +8,7 @@
>   #include <drm/drm_print.h>
>   #include <linux/bitops.h>
>   #include <linux/bitmap.h>
> +#include <linux/slab.h>
>   
>   #include "aie2_solver.h"
>