[PATCH 3/3] ext4: remove unneeded forward declaration

Kemeng Shi posted 3 patches 1 year ago
There is a newer version of this series
[PATCH 3/3] ext4: remove unneeded forward declaration
Posted by Kemeng Shi 1 year ago
Remove unneeded forward declaration of ext4_destroy_lazyinit_thread().

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 fs/ext4/super.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 8dfda41dabaa..d294cd43d3f2 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -79,7 +79,6 @@ static int ext4_unfreeze(struct super_block *sb);
 static int ext4_freeze(struct super_block *sb);
 static inline int ext2_feature_set_ok(struct super_block *sb);
 static inline int ext3_feature_set_ok(struct super_block *sb);
-static void ext4_destroy_lazyinit_thread(void);
 static void ext4_unregister_li_request(struct super_block *sb);
 static void ext4_clear_request_list(void);
 static struct inode *ext4_get_journal_inode(struct super_block *sb,
-- 
2.30.0
Re: [PATCH 3/3] ext4: remove unneeded forward declaration
Posted by Jan Kara 12 months ago
On Tue 17-12-24 20:03:56, Kemeng Shi wrote:
> Remove unneeded forward declaration of ext4_destroy_lazyinit_thread().
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 8dfda41dabaa..d294cd43d3f2 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -79,7 +79,6 @@ static int ext4_unfreeze(struct super_block *sb);
>  static int ext4_freeze(struct super_block *sb);
>  static inline int ext2_feature_set_ok(struct super_block *sb);
>  static inline int ext3_feature_set_ok(struct super_block *sb);
> -static void ext4_destroy_lazyinit_thread(void);
>  static void ext4_unregister_li_request(struct super_block *sb);
>  static void ext4_clear_request_list(void);
>  static struct inode *ext4_get_journal_inode(struct super_block *sb,
> -- 
> 2.30.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
Re: [PATCH 3/3] ext4: remove unneeded forward declaration
Posted by Zhang Yi 12 months ago
On 2024/12/17 20:03, Kemeng Shi wrote:
> Remove unneeded forward declaration of ext4_destroy_lazyinit_thread().
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@huawei.com>

> ---
>  fs/ext4/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 8dfda41dabaa..d294cd43d3f2 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -79,7 +79,6 @@ static int ext4_unfreeze(struct super_block *sb);
>  static int ext4_freeze(struct super_block *sb);
>  static inline int ext2_feature_set_ok(struct super_block *sb);
>  static inline int ext3_feature_set_ok(struct super_block *sb);
> -static void ext4_destroy_lazyinit_thread(void);
>  static void ext4_unregister_li_request(struct super_block *sb);
>  static void ext4_clear_request_list(void);
>  static struct inode *ext4_get_journal_inode(struct super_block *sb,