dt-bindings: interrupt-controller: arm,gic: Correct VGIC interrupt description

[PATCH] dt-bindings: interrupt-controller: arm,gic: Correct VGIC interrupt description

Posted by Krzysztof Kozlowski 1 year ago

The description of VGIC interrupt referenced obsolete "see below" after
converting TXT to DT Schema in commit 66ed144f147a ("dt-bindings:
interrupt-controller: Convert ARM GIC to json-schema"), because there is
no dedicated "VGIC" chapter anymore below.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/interrupt-controller/arm,gic.yaml     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
index a2846e493497..7173c4b5a228 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
@@ -110,8 +110,8 @@ properties:
 
   interrupts:
     description: Interrupt source of the parent interrupt controller on
-      secondary GICs, or VGIC maintenance interrupt on primary GIC (see
-      below).
+      secondary GICs, or VGIC maintenance interrupt on primary GIC (see "GICv2
+      with virtualization extensions" paragraph in the "reg" property).
     maxItems: 1
 
   cpu-offset:
-- 
2.43.0

Re: [PATCH] dt-bindings: interrupt-controller: arm,gic: Correct VGIC interrupt description

Posted by Rob Herring (Arm) 12 months ago

On Tue, 17 Dec 2024 07:12:26 +0100, Krzysztof Kozlowski wrote:
> The description of VGIC interrupt referenced obsolete "see below" after
> converting TXT to DT Schema in commit 66ed144f147a ("dt-bindings:
> interrupt-controller: Convert ARM GIC to json-schema"), because there is
> no dedicated "VGIC" chapter anymore below.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/interrupt-controller/arm,gic.yaml     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks!

Re: [PATCH] dt-bindings: interrupt-controller: arm,gic: Correct VGIC interrupt description

Posted by Conor Dooley 1 year ago

On Tue, Dec 17, 2024 at 07:12:26AM +0100, Krzysztof Kozlowski wrote:
> The description of VGIC interrupt referenced obsolete "see below" after
> converting TXT to DT Schema in commit 66ed144f147a ("dt-bindings:
> interrupt-controller: Convert ARM GIC to json-schema"), because there is
> no dedicated "VGIC" chapter anymore below.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/interrupt-controller/arm,gic.yaml     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
> index a2846e493497..7173c4b5a228 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
> @@ -110,8 +110,8 @@ properties:
>  
>    interrupts:
>      description: Interrupt source of the parent interrupt controller on
> -      secondary GICs, or VGIC maintenance interrupt on primary GIC (see
> -      below).
> +      secondary GICs, or VGIC maintenance interrupt on primary GIC (see "GICv2
> +      with virtualization extensions" paragraph in the "reg" property).

I don't think things like this /should/ need a dt ack, even if they
weren't from a dt maintainer - but in case one's expected
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Re: [PATCH] dt-bindings: interrupt-controller: arm,gic: Correct VGIC interrupt description

Posted by Marc Zyngier 1 year ago

On Tue, 17 Dec 2024 06:12:26 +0000,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
> The description of VGIC interrupt referenced obsolete "see below" after
> converting TXT to DT Schema in commit 66ed144f147a ("dt-bindings:
> interrupt-controller: Convert ARM GIC to json-schema"), because there is
> no dedicated "VGIC" chapter anymore below.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/interrupt-controller/arm,gic.yaml     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
> index a2846e493497..7173c4b5a228 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
> @@ -110,8 +110,8 @@ properties:
>  
>    interrupts:
>      description: Interrupt source of the parent interrupt controller on
> -      secondary GICs, or VGIC maintenance interrupt on primary GIC (see
> -      below).
> +      secondary GICs, or VGIC maintenance interrupt on primary GIC (see "GICv2
> +      with virtualization extensions" paragraph in the "reg" property).
>      maxItems: 1
>  
>    cpu-offset:

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.