gpu: host1x: Remove unused host1x_debug_dump_syncpts

[PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts

Posted by linux@treblig.org 1 year ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

host1x_debug_dump_syncpts() has been unused since
commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
fences")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/gpu/host1x/debug.c | 9 ---------
 drivers/gpu/host1x/debug.h | 1 -
 2 files changed, 10 deletions(-)

diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c
index a18cc8d8caf5..6433c00d5d7e 100644
--- a/drivers/gpu/host1x/debug.c
+++ b/drivers/gpu/host1x/debug.c
@@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
 
 	show_all(host1x, &o, true);
 }
-
-void host1x_debug_dump_syncpts(struct host1x *host1x)
-{
-	struct output o = {
-		.fn = write_to_printk
-	};
-
-	show_syncpts(host1x, &o, false);
-}
diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
index 62bd8a091fa7..c43c61d876a9 100644
--- a/drivers/gpu/host1x/debug.h
+++ b/drivers/gpu/host1x/debug.h
@@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
 void host1x_debug_init(struct host1x *host1x);
 void host1x_debug_deinit(struct host1x *host1x);
 void host1x_debug_dump(struct host1x *host1x);
-void host1x_debug_dump_syncpts(struct host1x *host1x);
 
 #endif
-- 
2.47.1

Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts

Posted by Thierry Reding 9 months, 3 weeks ago

On Sun, Dec 15, 2024 at 09:47:50PM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> host1x_debug_dump_syncpts() has been unused since
> commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> fences")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/gpu/host1x/debug.c | 9 ---------
>  drivers/gpu/host1x/debug.h | 1 -
>  2 files changed, 10 deletions(-)

Applied to drm-misc-next, thanks.

Thierry

Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts

Posted by Dr. David Alan Gilbert 9 months, 3 weeks ago

* Thierry Reding (thierry.reding@gmail.com) wrote:
> On Sun, Dec 15, 2024 at 09:47:50PM +0000, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > host1x_debug_dump_syncpts() has been unused since
> > commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> > fences")
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/gpu/host1x/debug.c | 9 ---------
> >  drivers/gpu/host1x/debug.h | 1 -
> >  2 files changed, 10 deletions(-)
> 
> Applied to drm-misc-next, thanks.

Thanks

> Thierry


-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts

Posted by Mikko Perttunen 1 year ago

On 12/16/24 6:47 AM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> host1x_debug_dump_syncpts() has been unused since
> commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> fences")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>   drivers/gpu/host1x/debug.c | 9 ---------
>   drivers/gpu/host1x/debug.h | 1 -
>   2 files changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c
> index a18cc8d8caf5..6433c00d5d7e 100644
> --- a/drivers/gpu/host1x/debug.c
> +++ b/drivers/gpu/host1x/debug.c
> @@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
>   
>   	show_all(host1x, &o, true);
>   }
> -
> -void host1x_debug_dump_syncpts(struct host1x *host1x)
> -{
> -	struct output o = {
> -		.fn = write_to_printk
> -	};
> -
> -	show_syncpts(host1x, &o, false);
> -}
> diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
> index 62bd8a091fa7..c43c61d876a9 100644
> --- a/drivers/gpu/host1x/debug.h
> +++ b/drivers/gpu/host1x/debug.h
> @@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
>   void host1x_debug_init(struct host1x *host1x);
>   void host1x_debug_deinit(struct host1x *host1x);
>   void host1x_debug_dump(struct host1x *host1x);
> -void host1x_debug_dump_syncpts(struct host1x *host1x);
>   
>   #endif

Acked-by: Mikko Perttunen <mperttunen@nvidia.com>

Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts

Posted by Dr. David Alan Gilbert 9 months, 3 weeks ago

Hi,

* Mikko Perttunen (cyndis@kapsi.fi) wrote:
> On 12/16/24 6:47 AM, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > host1x_debug_dump_syncpts() has been unused since
> > commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> > fences")
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >   drivers/gpu/host1x/debug.c | 9 ---------
> >   drivers/gpu/host1x/debug.h | 1 -
> >   2 files changed, 10 deletions(-)
> > 
> > diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c
> > index a18cc8d8caf5..6433c00d5d7e 100644
> > --- a/drivers/gpu/host1x/debug.c
> > +++ b/drivers/gpu/host1x/debug.c
> > @@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
> >   	show_all(host1x, &o, true);
> >   }
> > -
> > -void host1x_debug_dump_syncpts(struct host1x *host1x)
> > -{
> > -	struct output o = {
> > -		.fn = write_to_printk
> > -	};
> > -
> > -	show_syncpts(host1x, &o, false);
> > -}
> > diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
> > index 62bd8a091fa7..c43c61d876a9 100644
> > --- a/drivers/gpu/host1x/debug.h
> > +++ b/drivers/gpu/host1x/debug.h
> > @@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
> >   void host1x_debug_init(struct host1x *host1x);
> >   void host1x_debug_deinit(struct host1x *host1x);
> >   void host1x_debug_dump(struct host1x *host1x);
> > -void host1x_debug_dump_syncpts(struct host1x *host1x);
> >   #endif
> 
> Acked-by: Mikko Perttunen <mperttunen@nvidia.com>

Can this find it's way into drm please.

Thanks,

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/