scripts/checkpatch.pl | 2 +- scripts/spelling.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
The correct SPDX identifier for the 'GNU General Public License v2.0 or later' is GPL-2.0-or-later. Checkpatch.pl uses the misspelled words from spelling.txt both as keys of a hash and as part of a regular expression. For usage in the regular expression special characters like the plus sign need to be escaped. Heinrich Schuchardt (2): checkpatch: allow special characters in spelling.txt scripts/spelling.txt: add GPL-2.0+ scripts/checkpatch.pl | 2 +- scripts/spelling.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.45.2
On Sun, 2024-12-15 at 03:51 +0100, Heinrich Schuchardt wrote: > The correct SPDX identifier for the 'GNU General Public License v2.0 or > later' is GPL-2.0-or-later. I think this unnecessary as there's a separate script to check the appropriate SPDX uses treewide and there isn't a single existing use of "gpl-2.0+' in the tree. > > Checkpatch.pl uses the misspelled words from spelling.txt both as keys of a > hash and as part of a regular expression. For usage in the regular > expression special characters like the plus sign need to be escaped. > > Heinrich Schuchardt (2): > checkpatch: allow special characters in spelling.txt > scripts/spelling.txt: add GPL-2.0+ > > scripts/checkpatch.pl | 2 +- > scripts/spelling.txt | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) >
On 12/15/24 11:51, Joe Perches wrote: > On Sun, 2024-12-15 at 03:51 +0100, Heinrich Schuchardt wrote: >> The correct SPDX identifier for the 'GNU General Public License v2.0 or >> later' is GPL-2.0-or-later. > > I think this unnecessary as there's a separate script > to check the appropriate SPDX uses treewide and there > isn't a single existing use of "gpl-2.0+' in the tree. Hello Joe, In next-20241213 I find 5143 occurrences with git grep -ni 'gpl-2\.0+' | wc -l e.g. Documentation/bpf/prog_lsm.rst:1:.. SPDX-License-Identifier: GPL-2.0+ drivers/ata/sata_rcar.c:1:// SPDX-License-Identifier: GPL-2.0+ Some additions are quite recent: $ git diff HEAD~100 | grep -i 'gpl-2\.0+' | wc -l 63 Best regards Heinrich > > >> >> Checkpatch.pl uses the misspelled words from spelling.txt both as keys of a >> hash and as part of a regular expression. For usage in the regular >> expression special characters like the plus sign need to be escaped. >> >> Heinrich Schuchardt (2): >> checkpatch: allow special characters in spelling.txt >> scripts/spelling.txt: add GPL-2.0+ >> >> scripts/checkpatch.pl | 2 +- >> scripts/spelling.txt | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >
On Sun, 2024-12-15 at 13:41 +0100, Heinrich Schuchardt wrote: > On 12/15/24 11:51, Joe Perches wrote: > > On Sun, 2024-12-15 at 03:51 +0100, Heinrich Schuchardt wrote: > > > The correct SPDX identifier for the 'GNU General Public License v2.0 or > > > later' is GPL-2.0-or-later. > > > > I think this unnecessary as there's a separate script > > to check the appropriate SPDX uses treewide and there > > isn't a single existing use of "gpl-2.0+' in the tree. > > Hello Joe, > > In next-20241213 I find 5143 occurrences with > > git grep -ni 'gpl-2\.0+' | wc -l So no uses of 'gpl-2.0+' but many of 'GPL-2.0+' And perhaps read this: https://lore.kernel.org/all/CAHk-=wi2bdXuYhC9bd9FShtcf_u-6RUb3Qr_aXq3XtbCxR5NGQ@mail.gmail.com/
© 2016 - 2025 Red Hat, Inc.